search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[REVIEW]: Biosensor Framework: A C# Library for Affective Computing #3455

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @wsarce (Walker Arce) Repository: https://github.com/Munroe-Meyer-Institute-VR-Laboratory/Biosensor-Framework Version: 1.0.0 Editor: @osorensen Reviewer: @professoralkmin, @AustinTSchaffer Archive: 10.5281/zenodo.5161984

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ce2098ed62af72faa9a4817dabdc34e3"><img src="https://joss.theoj.org/papers/ce2098ed62af72faa9a4817dabdc34e3/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ce2098ed62af72faa9a4817dabdc34e3/status.svg)](https://joss.theoj.org/papers/ce2098ed62af72faa9a4817dabdc34e3)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@professoralkmin & @AustinTSchaffer, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @professoralkmin

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @AustinTSchaffer

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 3 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1145/3242969.3242985 is OK
- 10.1109/tits.2005.848368 is OK
- 10.1007/978-3-319-91262-2_16 is OK
- 10.1145/2968219.2968306 is OK
- 10.1145/3027063.3053140 is OK
- 10.1016/j.trf.2019.09.015 is OK
- 10.2196/13725 is OK
- 10.24251/hicss.2020.456 is OK
- 10.37896/jxu15.3/018 is OK
- 10.1109/10.979357 is OK
- 10.3390/s121217620 is OK
- 10.1080/19315864.2019.1595233 is OK
- 10.1002/aur.1433 is OK
- 10.1145/3136755.3143025 is OK
- 10.1089/cyber.2019.0093 is OK
- 10.1186/s12984-015-0010-z is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2496

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2496, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
arfon commented 3 years ago

@whedon accept deposit=true

whedon commented 3 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 3 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 3 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/2501
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.03455
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? Notify your editorial technical team...

arfon commented 3 years ago

@professoralkmin, @AustinTSchaffer – many thanks for your reviews here and to @osorensen for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@wsarce – your paper is now accepted and published in JOSS :zap::rocket::boom:

whedon commented 3 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.03455/status.svg)](https://doi.org/10.21105/joss.03455)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.03455">
  <img src="https://joss.theoj.org/papers/10.21105/joss.03455/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.03455/status.svg
   :target: https://doi.org/10.21105/joss.03455

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: