[REVIEW]: nnde: A Python package for solving differential equations using neural networks

whedon commented 3 years ago

Submitting author: @elwinter (Eric Winter) Repository: https://github.com/elwinter/nnde Version: v1.0 Editor: @diehlpk Reviewer: @taless474, @hayesall Archive: 10.5281/zenodo.5879387

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb"><img src="https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb/status.svg)](https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@taless474 & @hayesall, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @taless474

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@elwinter) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @hayesall

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@elwinter) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

diehlpk commented 2 years ago

Ok are there issues open for them, or are they to be handled outside the issue flow? Thanks Eric Get Outlook for Androidhttps://aka.ms/ghei36 … ____ From: Patrick Diehl @.> Sent: Sunday, November 7, 2021 3:19:31 PM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3465) @elwinterhttps://github.com/elwinter I briefly read the paper and have the following remarks, so far [ ] Please add the city, state, and country to the affiliation [ ] Provide some reference to PyTorch and TensorFlow 2. In addition, I think the related work section is really sparse and some mention of other packages and how they differ would be beneficial for the reader. * [ ] You mention that FEM and FDM can be difficult to parallelize. Can you provide some reference for that claim? @Winterhttps://github.com/Winter I think these are the last open items for the paper. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3465 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSFWC4Y6MD7IZFBM2K3NZTUK3NNHANCNFSM5AC2IOEQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I just documented the three issues above in this thread.

elwinter commented 2 years ago

OK thanks, Just wanted to make sure I was not missing anything.

Eric

On Sun, Nov 7, 2021 at 8:37 PM Patrick Diehl @.***> wrote:

Ok are there issues open for them, or are they to be handled outside the issue flow? Thanks Eric Get Outlook for Androidhttps://aka.ms/ghei36 … <#m990835679522565801> ____ From: Patrick Diehl @.> Sent: Sunday, November 7, 2021 3:19:31 PM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3465 https://github.com/openjournals/joss-reviews/issues/3465) @elwinter https://github.com/elwinter https://github.com/elwinter I briefly read the paper and have the following remarks, so far [ ] Please add the city, state, and country to the affiliation [ ] Provide some reference to PyTorch and TensorFlow 2. In addition, I think the related work section is really sparse and some mention of other packages and how they differ would be beneficial for the reader. * [ ] You mention that FEM and FDM can be difficult to parallelize. Can you provide some reference for that claim? @Winter https://github.com/Winter https://github.com/Winter I think these are the last open items for the paper. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3465 (comment) https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-962674280>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC4Y6MD7IZFBM2K3NZTUK3NNHANCNFSM5AC2IOEQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

I just document the three issues above in this thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-962739388, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC2MTFTNZWEXND57SATUK4SVJANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

elwinter commented 2 years ago

Hi Patrick. I have added some text, references, and links to the paper.md that I think address these concerns. I still did not spend a lot of text on other software, due to the space limitation. If you feel this still needs to be changed, please let me know.

I verified that the paper.md & paper.bib render properly in whedon. Please let me know if you or the other reviewers have any questions.

Thanks Eric Winter

On Sun, Nov 7, 2021 at 3:19 PM Patrick Diehl @.***> wrote:

@elwinter https://github.com/elwinter I briefly read the paper and have the following remarks, so far

[ ] Please add the city, state, and country to the affiliation

[ ] Provide some reference to PyTorch and TensorFlow 2. In addition, I think the related work section is really sparse and some mention of other packages and how they differ would be beneficial for the reader.

[ ] You mention that FEM and FDM can be difficult to parallelize. Can you provide some reference for that claim?

@Winter https://github.com/Winter I think these are the last open items for the paper.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-962674280, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC4Y6MD7IZFBM2K3NZTUK3NNHANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

diehlpk commented 2 years ago

@whedon generate pdf

whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

diehlpk commented 2 years ago

Hi Patrick. I have added some text, references, and links to the paper.md that I think address these concerns. I still did not spend a lot of text on other software, due to the space limitation. If you feel this still needs to be changed, please let me know. I verified that the paper.md & paper.bib render properly in whedon. Please let me know if you or the other reviewers have any questions. Thanks Eric Winter … On Sun, Nov 7, 2021 at 3:19 PM Patrick Diehl @.**> wrote: @elwinter https://github.com/elwinter I briefly read the paper and have the following remarks, so far [ ] Please add the city, state, and country to the affiliation [ ] Provide some reference to PyTorch and TensorFlow 2. In addition, I think the related work section is really sparse and some mention of other packages and how they differ would be beneficial for the reader. [ ] You mention that FEM and FDM can be difficult to parallelize. Can you provide some reference for that claim? @Winter https://github.com/Winter I think these are the last open items for the paper. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3465 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC4Y6MD7IZFBM2K3NZTUK3NNHANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@elwinter I am fine with all of your other changes. But I still think have some more details on related work will be helpful to the reader. Might you add some list of similar packages and provide some references?

It reads strange that nnde, TensorFlow, and PyTorch are the only packages.

Or at least make some statement that many more packages are available, but TensorFlow and PyTorch are the most similar ones?

diehlpk commented 2 years ago

@elwinter Do you think we can finish the paper by the end of next week? I would like to finalize the paper and take a new paper.

elwinter commented 2 years ago

Hi Patrick. I thought I had already addressed all of the issues a couple of weeks ago, but now I see a message from you on 15 November. My apologies

I did not see that message originally. I will plan to make further modifications early this week. I too would like to put this one "to bed".... :^)

Take care Eric

On Sun, Nov 28, 2021 at 2:38 PM Patrick Diehl @.***> wrote:

@elwinter https://github.com/elwinter Do you think we can finish the paper by the end of next week? I would like to finalize the paper and take a new paper.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-981139620, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWCYYRMOG3X35UVML5UTUOKAKBANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

diehlpk commented 2 years ago

@elwinter could you please finish the paper this week? I really would like to get this paper out to take a new paper.

diehlpk commented 2 years ago

@elwinter could you please finish the paper this week? I really would like to get this paper out to take a new paper.

elwinter commented 2 years ago

Hi Patrick. I apologize for the delay. I have reworked the paragraph discussing TensorFlow and PyTorch to include a better comparison with nnde. Please let me know what you think.

Thanks Eric

On Mon, Dec 13, 2021 at 11:25 AM Patrick Diehl @.***> wrote:

@elwinter https://github.com/elwinter could you please finish the paper this week? I really would like to get this paper out to take a new paper.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-992646006, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC6ZN253TXQXNS7JZKTUQYM7RANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

diehlpk commented 2 years ago

@whedon generate pdf

whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

diehlpk commented 2 years ago

@elwinter Thanks, the added text provided some benefit to the paper and I can recommend accepting it. Before, I can do that

[ ] Please let me know the final version, including all changes during the JOSS review.
[ ] Please upload this version to Zenodo or FigShare and post the DOI here. Note that the title and the author(s) have to match exactly with the papers.

diehlpk commented 2 years ago

@elwinter Happy New Year. It would be great if you could finish the above tasks soon, so we can publish your paper.

diehlpk commented 2 years ago

@elwinter It would be nice if you could post the DOI and version of the paper. We have some other papers in the pipeline and yours is blocking others to get handled.

diehlpk commented 2 years ago

@elwinter Any update?

diehlpk commented 2 years ago

@elwinter I really need the version and DOI to proceed. It would be bad to get your paper rejected at this stage.

elwinter commented 2 years ago

Sorry for the delay.

Version 1.0 DOI 10.5281/zenodo.5879387

On Tue, Jan 18, 2022 at 11:41 AM Patrick Diehl @.***> wrote:

@elwinter https://github.com/elwinter I really need the version and DOI to proceed. It would be bad to get your paper rejected at this stage.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-1015597361, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWCZ4GVSNS3WQ7OMYYELUWWJ5FANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

diehlpk commented 2 years ago

@whedon set 1.0 as version

whedon commented 2 years ago

OK. 1.0 is the version.

diehlpk commented 2 years ago

@whedon set 10.5281/zenodo.5879387 as archive

whedon commented 2 years ago

OK. 10.5281/zenodo.5879387 is the archive.

diehlpk commented 2 years ago

@elwinter Thanks. However,

Upon successful completion of the review, authors will make a tagged release of the software,

Could you please make a tagged release?

diehlpk commented 2 years ago

@elwinter Could you please check the DOI, it seems this DOI can not be resolved.

diehlpk commented 2 years ago

@elwinter if I do not hear back from you by Friday, we consider rejecting the paper.

elwinter commented 2 years ago

The tagged release was created last week - was there no message sent?

Get Outlook for Androidhttps://aka.ms/ghei36

From: Patrick Diehl @.> Sent: Monday, February 7, 2022 10:32:02 AM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3465)

@elwinterhttps://github.com/elwinter if I do not hear back from you by Friday, we consider rejecting the paper.

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/3465#issuecomment-1031597802, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSFWC6BSYNTUVACSMBCSM3UZ7QXFANCNFSM5AC2IOEQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

elwinter commented 2 years ago

Ahh I see what happened. The tag was created, with associated tarball, but the release was not created, with associated tarball. The latter is now available at:

https://github.com/elwinter/nnde/releases/tag/v1.0

The problem arose because the "Create new release" button on the repo page did not appear in my Chrome browser. I tried using Safari, and it appeared as expected.

Eric

On Mon, Feb 7, 2022 at 1:03 PM Eric Winter @.***> wrote:

The tagged release was created last week - was there no message sent?

Get Outlook for Android https://aka.ms/ghei36

From: Patrick Diehl @.> Sent: Monday, February 7, 2022 10:32:02 AM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention < @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3465)

@elwinter https://github.com/elwinter if I do not hear back from you by Friday, we consider rejecting the paper.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-1031597802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC6BSYNTUVACSMBCSM3UZ7QXFANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

hayesall commented 2 years ago

The DOI/zenodo probably need attention too, the link from earlier still isn't working.

diehlpk commented 2 years ago

@whedon set v1.0 as version

whedon commented 2 years ago

OK. v1.0 is the version.

diehlpk commented 2 years ago

OK. 10.5281/zenodo.5879387 is the archive.

@elwinter If I click on the DOI, I see the following error:

Could you please check why the DOI is not resolved?

elwinter commented 2 years ago

Ok checking that now.

Get Outlook for Androidhttps://aka.ms/ghei36

From: Patrick Diehl @.> Sent: Monday, February 7, 2022 5:11:20 PM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3465)

OK. 10.5281/zenodo.5879387https://doi.org/10.5281/zenodo.5879387 is the archive.

@elwinterhttps://github.com/elwinter If I click on the DOI, I see the following error:

[image]https://user-images.githubusercontent.com/3922435/152880712-266943bd-c852-4c74-9384-c84f14c52f84.png

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/3465#issuecomment-1031986467, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSFWC2PFYL2IIL6GFBLLQTU2A7QRANCNFSM5AC2IOEQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

elwinter commented 2 years ago

OK try again when you have a chance. I had never used Zenodo before. My file was there, and the URI was the same, but I apparently missed another button that said "Publish".

Eric

On Mon, Feb 7, 2022 at 7:23 PM Eric Winter @.***> wrote:

Ok checking that now.

Get Outlook for Android https://aka.ms/ghei36

From: Patrick Diehl @.> Sent: Monday, February 7, 2022 5:11:20 PM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention < @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3465)

OK. 10.5281/zenodo.5879387 https://doi.org/10.5281/zenodo.5879387 is the archive.

@elwinter https://github.com/elwinter If I click on the DOI, I see the following error:

[image: image] https://user-images.githubusercontent.com/3922435/152880712-266943bd-c852-4c74-9384-c84f14c52f84.png

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-1031986467, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC2PFYL2IIL6GFBLLQTU2A7QRANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

diehlpk commented 2 years ago

@elwinter One last thing

`nnde: A Python package for solving differential equations using neural networks`

The apostrophes around nnde``: look strange. Would you mind removing them? You can just change the title without generating a new DOI.

elwinter commented 2 years ago

Done. Sorry, missed that when I pasted in the title.

On Tue, Feb 8, 2022 at 3:19 PM Patrick Diehl @.***> wrote:

@elwinter https://github.com/elwinter One last thing

nnde: A Python package for solving differential equations using neural networks

The apostrophes around nnde: look strange. Would you mind removing them? You can just change the title without generating a new DOI.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3465#issuecomment-1033024906, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC7XZLS2XFLQRNPZL6LU2F3GDANCNFSM5AC2IOEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

diehlpk commented 2 years ago

@whedon check references

whedon commented 2 years ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/72.712178 is OK
- 10.1016/j.jcp.2018.10.045 is OK
- 10.1007/978-94-017-9816-7 is OK

MISSING DOIs

- None

INVALID DOIs

- None

diehlpk commented 2 years ago

@elwinter Now it looks good, and I can recommend the paper for acceptance.

diehlpk commented 2 years ago

@whedon recommend accept

whedon commented 2 years ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

diehlpk commented 2 years ago

@whedon commands

whedon commented 2 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Re-invite a reviewer (if they can't update checklists)
@whedon re-invite @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# All commands can be run on a non-default branch, to do this pass a custom 
# branch name by following the command with `from branch custom-branch-name`.
# For example:

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to do a dry run of accepting the paper and depositing with Crossref
@whedon recommend-accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

EiC TASKS

# Invite an editor to edit a submission (sending them an email)
@whedon invite @editor as editor

# Reject a paper
@whedon reject

# Withdraw a paper
@whedon withdraw

# Ask Whedon to actually accept the paper and deposit with Crossref
@whedon accept deposit=true

diehlpk commented 2 years ago

@whedon recommend-accept

whedon commented 2 years ago

Attempting dry run of processing paper acceptance...

whedon commented 2 years ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/72.712178 is OK
- 10.1016/j.jcp.2018.10.045 is OK
- 10.1007/978-94-017-9816-7 is OK

MISSING DOIs

- None

INVALID DOIs

- None

whedon commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2934

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2934, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

diehlpk commented 2 years ago

@taless474 and @hayesall thanks for your efforts, without you, we can not run JOSS.

elwinter commented 2 years ago

My thanks as well for your patience. This was my first time for lot of this.

Take care Eric

Get Outlook for Androidhttps://aka.ms/ghei36

From: Patrick Diehl @.> Sent: Tuesday, February 8, 2022 5:15:47 PM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3465)

@taless474https://github.com/taless474 and @hayesallhttps://github.com/hayesall thanks for your efforts, without you, we can not run JOSS.

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/3465#issuecomment-1033117525, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSFWC6MJ3IGL6KE3RESOGTU2GIZHANCNFSM5AC2IOEQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

kthyng commented 2 years ago

Hi @elwinter! A few items to finish up:

version and zenodo look good.
Does your co-author want to go by initials only?
In your paper, you shouldn't have an additional seciton underneath the affiliations stating your full listing.
Your reference section is repeated twice — not sure how that is happening!

openjournals / joss-reviews