openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: home2park: An R package to assess the spatial provision of urban parks #3486

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @xp-song (Xiao Ping Song) Repository: https://github.com/ecological-cities/home2park Version: v0.1.0 Editor: @martinfleis Reviewers: @aelissa, @nickbearman Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/16d81fa40c903d4cd5dfa91900b55bb0"><img src="https://joss.theoj.org/papers/16d81fa40c903d4cd5dfa91900b55bb0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/16d81fa40c903d4cd5dfa91900b55bb0/status.svg)](https://joss.theoj.org/papers/16d81fa40c903d4cd5dfa91900b55bb0)

Author instructions

Thanks for submitting your paper to JOSS @xp-song. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @KristinaRiemer.

@xp-song if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

PDF failed to compile for issue #3486 with the following error:

 Can't find any papers to compile :-(
whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.12 s (728.9 files/s, 178483.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            34           1805            484           6847
JavaScript                      12            797            543           3866
Markdown                         6            291              0           1057
CSS                              6            157             77           1045
R                               19            566           1595            998
XML                              2              0              2            525
Rmd                              4            351            398            307
YAML                             5             24              2            183
TeX                              1              0              0            106
SVG                              1              0              1             11
-------------------------------------------------------------------------------
SUM:                            90           3991           3102          14945
-------------------------------------------------------------------------------

Statistical information for the repository '37370b6240173585d70f0c1a' was
gathered on 2021/07/12.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
xpsong                           2          5242             24          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
xpsong                     5218           99.5          0.0               10.44
kthyng commented 3 years ago

@xp-song I think your paper needs to be named paper.md to be found. Mote info here.

kthyng commented 3 years ago

Since this software is on the small side (<1000 lines of code), I am pinging the editorial board to make sure it is in scope in terms of substantial scholarly effort. This process will take 1-2 weeks.

kthyng commented 3 years ago

@whedon query scope

whedon commented 3 years ago

Submission flagged for editorial review.

xp-song commented 3 years ago

@xp-song I think your paper needs to be named paper.md to be found. Mote info here.

Hi @kthyng, thank you for looking into our work. I've fixed this in commit 06f7047

xp-song commented 3 years ago

@xp-song if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Here are several reviewer suggestions based on the provided list:

danielskatz commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 3 years ago

@xp-song - I'm unsure if this is limited to use in Singapore - can you explain if this is correct or not?

xp-song commented 3 years ago

@danielskatz The package can be used anywhere (user provided data), and functions are included to download/process OSM data. So out of the box, it may be used anywhere where OSM is available. The example provided is for the city of Singapore

danielskatz commented 3 years ago

This has passed the scope query, but we don't have editors in this area currently available, so we'll put in on the waiting list for a little bit

xp-song commented 3 years ago

@whedon list editors

whedon commented 3 years ago

Current editors:

@Kevin-Mattheus-Moerman
@KristinaRiemer
@Nikoleta-v3
@VivianePons
@adi3
@ajstewartlang
@arfon
@arokem
@bmcfee
@cMadan
@csoneson
@danielskatz
@dfm
@dhhagan
@diehlpk
@dpsanders
@drvinceknight
@elbeejay
@eloisabentivegna
@emdupre
@fabian-s
@faroit
@fboehm
@fraukewiese
@galessiorob
@gkthiruvathukal
@hugoledoux
@jbytecode
@jedbrown
@jgostick
@jmschrei
@jni
@katyhuff
@kbarnhart
@kellyrowland
@kthyng
@kyleniemeyer
@leouieda
@lorenanicole
@lpantano
@lucydot
@luizirber
@majensen
@marcosvital
@mbobra
@meg-simula
@melissawm
@mikldk
@mjsottile
@oliviaguest
@osorensen
@pdebuyl
@pibion
@poulson
@richardjgowers
@rkurchin
@sbenthall
@sjpfenninger
@taless474
@terrytangyuan
@timtroendle
@vissarion
@will-rowe
@xuanxu
xp-song commented 3 years ago

@danielskatz The research areas that home2park intersect with include topics such as GIS/geospatial analysis (e.g. spatial equity/statistics), human ecology (e.g. human–nature interactions, recreation/leisure), as well as city/urban planning (e.g. landscape ecology/patterns). Some suggested editors are listed below, hope this helps:

danielskatz commented 3 years ago

we don't have editors in this area currently available

"available" is the key word here, meaning free to take on another paper, but thanks for making these explicit suggestions.

arfon commented 3 years ago

@whedon invite @martinfleis as editor

:wave: @martinfleis – would you be willing to edit this submission for JOSS?

whedon commented 3 years ago

@martinfleis has been invited to edit this submission.

martinfleis commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

OK, the editor is @martinfleis

martinfleis commented 3 years ago

👋 Hi @xp-song, I'll be editing your paper.

While I try to get in touch with potential reviewers, can you expand the paper to follow the guidelines?

See the submitting guidelines and a review checklist for details.

Thank you!

martinfleis commented 3 years ago

@whedon assign @aelissa as reviewer

whedon commented 3 years ago

OK, @aelissa is now a reviewer

martinfleis commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

xp-song commented 3 years ago

👋 Hi @xp-song, I'll be editing your paper.

While I try to get in touch with potential reviewers, can you expand the paper to follow the guidelines?

  • The Summary section of your paper should summarise the package. In its current form, it serves as an introduction and a problem statement more than a summary. It should contain a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience.
  • Add State of the field section. You should describe how this software compares to other commonly-used packages, at least within the R ecosystem (and potentially other).

See the submitting guidelines and a review checklist for details.

Thank you!

Thanks for pointing these out, I've updated the paper and added some links to documentation.

xp-song commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

martinfleis commented 3 years ago

@whedon add @nickbearman as reviewer

whedon commented 3 years ago

OK, @nickbearman is now a reviewer

martinfleis commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3609.