search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[REVIEW]: tidygeocoder: An R package for geocoding #3544

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @jessecambon (Jesse Cambon) Repository: https://github.com/jessecambon/tidygeocoder Version: v1.0.3 Editor: @elbeejay Reviewer: @cole-brokamp, @tsamsonov Archive: 10.5281/zenodo.4686074

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c3cf0ab0d656d6398ada74dea81c5fb7"><img src="https://joss.theoj.org/papers/c3cf0ab0d656d6398ada74dea81c5fb7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c3cf0ab0d656d6398ada74dea81c5fb7/status.svg)](https://joss.theoj.org/papers/c3cf0ab0d656d6398ada74dea81c5fb7)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@cole-brokamp & @tsamsonov, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @elbeejay know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @cole-brokamp

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @tsamsonov

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @cole-brokamp, @tsamsonov it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

PDF failed to compile for issue #3544 with the following error: 

 Can't find any papers to compile :-(
whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.29 s (624.5 files/s, 163244.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      24           3075           3499          14545
HTML                            31           1823            423           9689
R                               88           2076           2076           6389
CSS                              9            112             94            853
Rmd                              6            245            400            455
Markdown                         5             76              0            259
JSON                             2              1              0            173
YAML                             3             23              3            155
XML                              1              0              0             66
SVG                              9              0              1             19
-------------------------------------------------------------------------------
SUM:                           178           7431           6496          32603
-------------------------------------------------------------------------------

Statistical information for the repository 'b068bcfca21bdd1afd433314' was
gathered on 2021/07/29.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Jesse Cambon                    12         67978          15249          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Jesse Cambon              52377           77.0          1.8               17.35
elbeejay commented 3 years ago

@cole-brokamp and @tsamsonov thanks for agreeing to review this submission to JOSS. We are currently asking reviewers to try and complete their reviews in 6 weeks.

The JOSS review process is entirely open and transparent, and takes place on GitHub. Review comments can be made as issues in the tidygeocoder repository, please link this review issue when doing so (paste https://github.com/openjournals/joss-reviews/issues/3544 into the issue).

For reference, here are links to the JOSS documentation that may be helpful as you conduct your reviews:

Please feel free to ping me (@elbeejay) if you have any questions/concerns. Thanks again for agreeing to review for JOSS.

elbeejay commented 3 years ago

@whedon generate pdf from branch joss

whedon commented 3 years ago 
Attempting PDF compilation from custom branch joss. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

elbeejay commented 3 years ago

@whedon check references from branch joss

whedon commented 3 years ago 
Attempting to check references... from custom branch joss
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.4686074 is OK
- 10.18637/jss.v059.i10 is OK
- 10.21105/joss.01686 is OK
- 10.1007/s13187-020-01951-7 is OK
- 10.1101/2021.03.02.21252766 is OK
- 10.31234/osf.io/3vsxc is OK
- 10.2139/ssrn.3747263 is OK
- 10.1080/15230406.2013.777138 is OK
- 10.26833/ijeg.629381 is OK
- 10.1101/2021.06.02.21258249 is OK
- 10.32469/10355/81561 is OK
- 10.1201/b22052 is OK
- 10.1201/9780429200717 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:wave: @cole-brokamp, please update us on how your review is going (this is an automated reminder).

whedon commented 3 years ago

:wave: @tsamsonov, please update us on how your review is going (this is an automated reminder).

elbeejay commented 3 years ago

:wave: @cole-brokamp @tsamsonov we are nearing the halfway point in the review process so I just wanted to check in with you both.

Let me know if there are any questions about conducting a JOSS review and I'll do my best to provide clarification. Thanks again for agreeing to review for JOSS.

cole-brokamp commented 3 years ago

Hi @elbeejay, I've initiated my review. These are two very minor changes that can hopefully be addressed easily.

cole-brokamp commented 3 years ago

I've completed my review. As long as the markdown file in the repo makes it into the final PDF here, I am all good to go. Thanks.

elbeejay commented 3 years ago

Great, thanks @cole-brokamp!

elbeejay commented 3 years ago

@whedon generate pdf from branch joss

whedon commented 3 years ago 
Attempting PDF compilation from custom branch joss. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jessecambon commented 3 years ago

We updated the paper to include a comparison to other R packages (state of the field).

jessecambon commented 3 years ago

@whedon generate pdf from branch joss

whedon commented 3 years ago 
Attempting PDF compilation from custom branch joss. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

tsamsonov commented 3 years ago

I've completed my review. Everything is good, I think.

All the best, Tim

elbeejay commented 3 years ago

@whedon generate pdf from branch joss

whedon commented 3 years ago 
Attempting PDF compilation from custom branch joss. Reticulating splines etc...
elbeejay commented 3 years ago

@whedon check references from branch joss

whedon commented 3 years ago 
Attempting to check references... from custom branch joss
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.4686074 is OK
- 10.18637/jss.v059.i10 is OK
- 10.21105/joss.01686 is OK
- 10.1007/s13187-020-01951-7 is OK
- 10.1101/2021.03.02.21252766 is OK
- 10.31234/osf.io/3vsxc is OK
- 10.2139/ssrn.3747263 is OK
- 10.1080/15230406.2013.777138 is OK
- 10.26833/ijeg.629381 is OK
- 10.1101/2021.06.02.21258249 is OK
- 10.32469/10355/81561 is OK
- 10.1201/b22052 is OK
- 10.1201/9780429200717 is OK

MISSING DOIs

- 10.32614/rj-2013-014 may be a valid DOI for title: ggmap: Spatial Visualization with ggplot2

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

elbeejay commented 3 years ago

Hi @jessecambon and coauthors, I'm pleased to see that the reviewers have completed their review of your package. I have a few minor clarifications and changes of my own to request.

Once you have made the above changes, there are just a few things I need from you to set the metadata and mark this as "ready for publication"; please:

Given that the software (as far as I am aware) did not actually change as a part of this review, these steps may already be complete. I just ask that you double-check the metadata to ensure everything is correct, and then list the requested items here. I will then move forward with accepting the submission, thanks!

jessecambon commented 3 years ago

Hi @elbeejay, thanks. I've made those two changes and the Zenodo archive is here (DOI = 10.5281/zenodo.4686074, github release v1.0.3). I double checked the Zenodo metadata and it is correct.

elbeejay commented 3 years ago

@whedon set 10.5281/zenodo.4686074 as archive

whedon commented 3 years ago

OK. 10.5281/zenodo.4686074 is the archive.

elbeejay commented 3 years ago

@whedon generate pdf from branch joss

whedon commented 3 years ago 
Attempting PDF compilation from custom branch joss. Reticulating splines etc...
elbeejay commented 3 years ago

@whedon check references from branch joss

whedon commented 3 years ago 
Attempting to check references... from custom branch joss
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.18637/jss.v059.i10 is OK
- 10.21105/joss.01686 is OK
- 10.1007/s13187-020-01951-7 is OK
- 10.1101/2021.03.02.21252766 is OK
- 10.31234/osf.io/3vsxc is OK
- 10.2139/ssrn.3747263 is OK
- 10.1080/15230406.2013.777138 is OK
- 10.26833/ijeg.629381 is OK
- 10.1101/2021.06.02.21258249 is OK
- 10.32469/10355/81561 is OK
- 10.1201/b22052 is OK
- 10.1201/9780429200717 is OK
- 10.32614/RJ-2013-014 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

elbeejay commented 3 years ago

@whedon recommend-accept

whedon commented 3 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago

PDF failed to compile for issue #3544 with the following error: 

 Can't find any papers to compile :-(
elbeejay commented 3 years ago

@whedon recommend-accept from branch joss

whedon commented 3 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.18637/jss.v059.i10 is OK
- 10.21105/joss.01686 is OK
- 10.1007/s13187-020-01951-7 is OK
- 10.1101/2021.03.02.21252766 is OK
- 10.31234/osf.io/3vsxc is OK
- 10.2139/ssrn.3747263 is OK
- 10.1080/15230406.2013.777138 is OK
- 10.26833/ijeg.629381 is OK
- 10.1101/2021.06.02.21258249 is OK
- 10.32469/10355/81561 is OK
- 10.1201/b22052 is OK
- 10.1201/9780429200717 is OK
- 10.32614/RJ-2013-014 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2571

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2571, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true from branch joss
elbeejay commented 3 years ago

@jessecambon and co-authors: I've recommended that your submission be accepted and published. Final steps will be handled by one of the EiCs. Many thanks to both @cole-brokamp and @tsamsonov for their reviews.

arfon commented 3 years ago

@whedon accept deposit=true from branch joss

whedon commented 3 years ago 
Doing it live! Attempting automated processing of paper acceptance...