openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
714 stars 38 forks source link

[PRE REVIEW]: Bam-readcount - rapid generation of basepair-resolution sequence metrics #3615

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @chrisamiller (Christopher A. Miller) Repository: https://github.com/genome/bam-readcount Version: 1.0 Editor: @lpantano Reviewers: @friedue Managing EiC: Arfon Smith

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1bcbb483ff8b512cc4598e44807ce8a2"><img src="https://joss.theoj.org/papers/1bcbb483ff8b512cc4598e44807ce8a2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1bcbb483ff8b512cc4598e44807ce8a2/status.svg)](https://joss.theoj.org/papers/1bcbb483ff8b512cc4598e44807ce8a2)

Author instructions

Thanks for submitting your paper to JOSS @chrisamiller. Currently, there isn't an JOSS editor assigned to your paper.

@chrisamiller if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

PDF failed to compile for issue #3615 with the following error:

 Can't find any papers to compile :-(
whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.06 s (887.3 files/s, 82996.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CMake                           20            210            404            960
Python                           5            112            223            914
C++                              8            140            111            846
Markdown                         5            100              0            169
C/C++ Header                     5             29              0            128
XSLT                             1              5              0            112
Perl                             2             24              0             96
Dockerfile                       1              9              6             27
YAML                             1              0              0             21
diff                             1              4             16             10
Bourne Shell                     1              0              0              1
-------------------------------------------------------------------------------
SUM:                            50            633            760           3284
-------------------------------------------------------------------------------

Statistical information for the repository 'f0cffad0752c12cffc3802f3' was
gathered on 2021/08/15.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Ajay Khanna                      9           110             47            2.84
Chris Miller                     2             9              1            0.18
Dave Larson                     57          1358            866           40.30
Morgan Taschuk                   1             1              1            0.04
Sam Brightman                    1             4              4            0.14
Travis Abbott                   16          1133            986           38.39
dlarson                          7           973             26           18.10

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Ajay Khanna                  92           83.6         13.3               16.30
Chris Miller                  7           77.8         78.8                0.00
Dave Larson                 865           63.7         83.8                6.47
Morgan Taschuk                1          100.0         72.7                0.00
Sam Brightman                 4          100.0         58.8                0.00
Travis Abbott               546           48.2        102.9                9.89
arfon commented 3 years ago

@whedon generate pdf from branch joss-paper

whedon commented 3 years ago
Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 3 years ago

@whedon check references from branch joss-paper

whedon commented 3 years ago
Attempting to check references... from custom branch joss-paper
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1101/2020.12.16.423064 may be a valid DOI for title: HTSlib: C library for reading/writing high-throughput sequencing data
- 10.1111/gcb.15291 may be a valid DOI for title: Rapid genomic and phenotypic change in response to climate warming in a widespread plant invader
- 10.1186/s12920-019-0508-5 may be a valid DOI for title: NeoMutate: an ensemble machine learning framework for the prediction of somatic mutations in cancer
- 10.1093/bioinformatics/btw536 may be a valid DOI for title: SiNVICT: ultra-sensitive detection of single nucleotide variants and indels in circulating tumour DNA
- 10.1038/s41375-018-0193-y may be a valid DOI for title: Discriminating a common somatic ASXL1 mutation (c.1934dup; p.G646Wfs*12) from artifact in myeloid malignancies using NGS
- 10.1182/blood-2017-03-735654 may be a valid DOI for title: The NCI Genomic Data Commons as an engine for precision medicine
- 10.1002/0471250953.bi1504s44 may be a valid DOI for title: Using VarScan 2 for Germline Variant Calling and Somatic Mutation Detection
- 10.1101/2021.05.06.21256753 may be a valid DOI for title: A direct capture method for purification and detection of viral nucleic acid enables epidemiological surveillance of SARS-CoV-2
- 10.1038/s41598-020-64708-8 may be a valid DOI for title: Detection of low-frequency resistance-mediating SNPs in next-generation sequencing data of Mycobacterium tuberculosis complex strains with binoSNP
- 10.1093/bioinformatics/bty518 may be a valid DOI for title: appreci8: a pipeline for precise variant calling integrating 8 tools
- 10.1101/mcs.a002444 may be a valid DOI for title: Resistance-promoting effects of ependymoma treatment revealed through genomic analysis of multiple recurrences in a single patient
- 10.1038/s41588-018-0257-y may be a valid DOI for title: A deep learning approach to automate refinement of somatic variant calling from cancer sequencing data
- 10.1093/bioinformatics/bty316 may be a valid DOI for title: CONICS integrates scRNA-seq with DNA sequencing to map gene expression to tumor sub-clones

INVALID DOIs

- None
arfon commented 3 years ago

@chrisamiller - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy. For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

While you wait, if you want to fix the DOIs (noting that Whedon's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references.

@whedon generate pdf @whedon check references

chrisamiller commented 3 years ago

Happy to utilize one of the other editors with genomics experience, if that helps things. Yes, we'll get the dois cleaned up - thank you!

kthyng commented 3 years ago

@lpantano Would you be able to edit this submission?

kthyng commented 3 years ago

@whedon invite @lpantano as editor

whedon commented 3 years ago

@lpantano has been invited to edit this submission.

lpantano commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

OK, the editor is @lpantano

whedon commented 3 years ago

PDF failed to compile for issue #3615 with the following error:

 Can't find any papers to compile :-(
apldx commented 3 years ago

@whedon generate pdf from branch joss-paper

whedon commented 3 years ago
Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lpantano commented 3 years ago

@whedon check references from custom branch joss-paper

apldx commented 3 years ago

@whedon check references from branch joss-paper

whedon commented 3 years ago
Attempting to check references... from custom branch joss-paper
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/gigascience/giab007 is OK
- 10.1038/nm.3733 is OK
- 10.1111/gcb.15291 is OK
- 10.1186/s12920-019-0508-5 is OK
- 10.1371/journal.pcbi.1004274 is OK
- 10.1093/bioinformatics/btw536 is OK
- 10.1038/s41375-018-0193-y is OK
- 10.1001/jamaoncol.2016.0494 is OK
- 10.1016/j.cels.2015.08.015 is OK
- 10.1182/blood-2017-03-735654 is OK
- 10.1093/infdis/jiy358 is OK
- 10.1002/0471250953.bi1504s44 is OK
- 10.3390/v12121414 is OK
- 10.1101/2021.05.06.21256753 is OK
- 10.1056/NEJMoa1301689 is OK
- 10.1038/s41598-020-64708-8 is OK
- 10.1093/bioinformatics/bty518 is OK
- 10.1101/mcs.a002444 is OK
- 10.1038/s41588-018-0257-y is OK
- 10.1093/bioinformatics/bty316 is OK

MISSING DOIs

- None

INVALID DOIs

- None
lpantano commented 3 years ago

hi @chrisamiller, would you suggest any reviewer from the list? i keep looking for reviewers meanwhile. thanks!

chrisamiller commented 3 years ago

From a quick look, it seems like any of these folks would have the relevant expertise:

standage afrubin will-rowe ctb iskandr kortschak VivekTodur

Thanks!

lpantano commented 3 years ago

@kortschak, would you like and have time to review this tool? Thanks!

kortschak commented 3 years ago

i'm afraid that I don't have time to do this right now.

lpantano commented 3 years ago

Hi @oliviamr and @iskandr, would you like and have time to review this tool? Thanks! As a reminder, our review process happens in github, read more. JOSS encourages best practices and helps the reviewer with a list to go over during the process to make it as easier as possible.

lpantano commented 3 years ago

@whedon assign @friedue as reviewer

whedon commented 3 years ago

OK, @friedue is now a reviewer

lpantano commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3722.