search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: POWERsim: A nanoPOWER ISA Functional Simulator #3757

Closed whedon closed 2 years ago

whedon commented 3 years ago

Submitting author: @god-s-perfect-idiot (Samar Musthafa) Repository: https://github.com/god-s-perfect-idiot/POWER-sim Version: v0.7x Editor: @jarvist Reviewers: @dilawar, @federeghe Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cd5836e1edd3a9a1826558f9193edfdf"><img src="https://joss.theoj.org/papers/cd5836e1edd3a9a1826558f9193edfdf/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cd5836e1edd3a9a1826558f9193edfdf/status.svg)](https://joss.theoj.org/papers/cd5836e1edd3a9a1826558f9193edfdf)

Author instructions

Thanks for submitting your paper to JOSS @god-s-perfect-idiot. Currently, there isn't an JOSS editor assigned to your paper.

@god-s-perfect-idiot if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

Wordcount for paper.md is 1119

whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.13 s (290.8 files/s, 27056.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          30            373            141           2190
Markdown                         4            153              0            496
Assembly                         3             31             39             82
TeX                              1              3              0             27
-------------------------------------------------------------------------------
SUM:                            38            560            180           2795
-------------------------------------------------------------------------------

Statistical information for the repository '8dda7736badeeb3269853b85' was
gathered on 2021/09/23.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Samar                           19          3650            189           95.57
god-s-perfect-idiot              2            93             85            4.43

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Samar                      3366           92.2         16.1                6.42
god-s-perfect-idiot         103          110.8          0.0                0.00
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 3 years ago

Hi @god-s-perfect-idiot and thanks for your submission. Can you edit your paper to begin with a jargon-free explanation of the purpose of the software that a technical person outside of your field can understand? Also, the statement of need should explain why the software is useful (less jargon and fewer acronyms is always better) as well as the research applications. Thanks.

kthyng commented 3 years ago

I'm going to add the "paused" label in the meantime since this will be a necessary step before determining if the submission is in scope.

god-s-perfect-idiot commented 3 years ago

Hi @kthyng thanks for the review. I shall make the suggested changes to the paper.

god-s-perfect-idiot commented 3 years ago

@kthyng Just to be clear, the suggested changes only apply to Statement of need, or am i required to change the summary as well?

kthyng commented 3 years ago

"Can you edit your paper to begin with a jargon-free explanation of the purpose of the software that a technical person outside of your field can understand?" was meant to refer to the summary and "Also, the statement of need should explain why the software is useful (less jargon and fewer acronyms is always better) as well as the research applications." to the statement of need section.

god-s-perfect-idiot commented 3 years ago

Alright. That is clear. Thank you.

god-s-perfect-idiot commented 3 years ago

@kthyng the suggested changes have been made and the paper was edited. Can you please take another look? Thank you

kthyng commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 3 years ago

@god-s-perfect-idiot I don't see improvement in the paper, just a few small changes. Here are more suggestions:

Summary:

Statement of need:

Please read carefully through our guidelines for what should be in your paper.

god-s-perfect-idiot commented 3 years ago

@kthyng Thanks for the review. I will make these changes. I apologize for not addressing these issues.

god-s-perfect-idiot commented 3 years ago

Hi @kthyng the changes have been made. Can u please re-review? Thanks

kthyng commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 3 years ago

I'm going to remove the paused label and more formally start a scope discussion - I think we'll be able to finish this discussion next week

danielskatz commented 3 years ago

@whedon query scope

whedon commented 3 years ago

Submission flagged for editorial review.

danielskatz commented 3 years ago

@god-s-perfect-idiot - this has passed the scope review. We'll next find an editor.

danielskatz commented 3 years ago

👋 @VivianePons - Would you be able to edit this JOSS submission?

danielskatz commented 3 years ago

@whedon invite @VivianePons as editor

whedon commented 3 years ago

@VivianePons has been invited to edit this submission.

VivianePons commented 3 years ago

Hi Daniel, I am in the middle of an international move and won't have time to look into this before next week. Is that ok?

kyleniemeyer commented 3 years ago

@VivianePons we can find someone else, to allow you to handle the other assignment. Good luck with the move!

@jarvist though this is a bit outside your primary areas of expertise, it seemed like you were familiar with the area—could you edit this one?

kyleniemeyer commented 3 years ago

@whedon invite @jarvist as editor

whedon commented 3 years ago

@jarvist has been invited to edit this submission.

arfon commented 3 years ago

@jarvist has been invited to edit this submission.

:wave: @jarvist – just checking in to see if you think you might be able to edit this one for us?

jarvist commented 3 years ago

Happy to give it a go!

jarvist commented 3 years ago

@whedon assign @jarvist as editor

whedon commented 3 years ago

OK, the editor is @jarvist

jarvist commented 3 years ago

@god-s-perfect-idiot - do you have any suggestions for reviewers? I suppose someone stating VHDL / Verilog experience should at least have an understanding of what this sort of package would be useful for.

god-s-perfect-idiot commented 3 years ago

Hi @jarvist thank you for taking up the editing. I was hoping @jedbrown could take a look as i felt they had the best profile and background for an ISA simulator. But, im not sure if they're available, or if im incorrect on said notion.

jarvist commented 3 years ago

@whedon add @dilawar as reviewer

Thank you Dilawar for offering to review this paper 👋

whedon commented 3 years ago

OK, @dilawar is now a reviewer

jarvist commented 3 years ago

Still searching for a second reviewer.

jedbrown commented 3 years ago

John Gunnels (@jagunnels) has written more POWER assembly than anyone I know, and would be a great reviewer if he's available.

god-s-perfect-idiot commented 2 years ago

Hi. Can I know if this paper is still under review?

jarvist commented 2 years ago

Hi. Can I know if this paper is still under review?

Still under 'pre review'! I've just emailed a potential reviewer. Finding reviewers with the requisite knowledge has been a challenge.

jarvist commented 2 years ago

@whedon add @federeghe as reviewer

Thank you Federico for agreeing to review this paper 👋

whedon commented 2 years ago

OK, @federeghe is now a reviewer

jarvist commented 2 years ago

@whedon start review

OK, with two reviewers we are now good to go.

whedon commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3973.