openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
701 stars 36 forks source link

[PRE REVIEW]: Taichi_LBM3D: A 3D lattice Bolzmann solver in Taichi #3763

Closed whedon closed 2 years ago

whedon commented 2 years ago

Submitting author: @ly16302 (Liang Yang) Repository: https://github.com/yjhp1016/taichi_LBM3D Version: v1.0.0 Editor: Pending Reviewer: Pending Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/11cee02c77e2463b3cef26d5b33e3fc6"><img src="https://joss.theoj.org/papers/11cee02c77e2463b3cef26d5b33e3fc6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/11cee02c77e2463b3cef26d5b33e3fc6/status.svg)](https://joss.theoj.org/papers/11cee02c77e2463b3cef26d5b33e3fc6)

Author instructions

Thanks for submitting your paper to JOSS @ly16302. Currently, there isn't an JOSS editor assigned to your paper.

@ly16302 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 2 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 2 years ago

Wordcount for paper.md is 902

whedon commented 2 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.10 s (60.5 files/s, 17722.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           3            277            120           1033
TeX                              1             18              0            184
Markdown                         2             32              0             95
-------------------------------------------------------------------------------
SUM:                             6            327            120           1312
-------------------------------------------------------------------------------

Statistical information for the repository '296657591a581e5629b641ed' was
gathered on 2021/09/24.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Jianhui                          3           823             20           99.76
Liang Yang                       1             1              1            0.24

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Jianhui                    1429          173.6          0.0                7.70
Liang Yang                    1          100.0          0.1                0.00
whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.camwa.2012.11.022 may be a valid DOI for title: A comparison study of multi-component Lattice Boltzmann models for flow in porous media applications
- 10.1103/physreve.87.013011 may be a valid DOI for title: Predictions of non-Fickian solute transport in different classes of porous media using direct simulation on pore-scale images
- 10.1007/s10596-019-09837-4 may be a valid DOI for title: Image-based simulations of absolute permeability with massively parallel pseudo-compressible stabilised finite element solver
- 10.2514/5.9781600866319.0450.0458 may be a valid DOI for title: Generalized lattice-Boltzmann equations
- 10.1209/0295-5075/17/6/001 may be a valid DOI for title: Lattice BGK models for Navier-Stokes equation
- 10.1016/j.compfluid.2005.08.010 may be a valid DOI for title: An adaptive scheme using hierarchical grids for lattice Boltzmann multi-phase flow simulations
- 10.1002/2013wr013877 may be a valid DOI for title: Quantitative determination of molecular propagator distributions for solute transport in homogeneous and heterogeneous porous media using lattice Boltzmann simulations
- 10.1016/j.advwatres.2008.03.009 may be a valid DOI for title: Prediction of capillary hysteresis in a porous material using lattice-Boltzmann methods and comparison to experimental data and a morphological pore network model
- 10.1145/3388769.3407493 may be a valid DOI for title: The Taichi programming language
- 10.1103/physreve.67.036701 may be a valid DOI for title: Lattice Boltzmann algorithm for surface tension with greatly reduced microcurrents
- 10.1016/s0010-4655(00)00090-4 may be a valid DOI for title: A Galilean invariant model of the lattice Boltzmann method for multiphase fluid flows using free-energy approach
- 10.1103/physreve.47.1815 may be a valid DOI for title: Lattice Boltzmann model for simulating flows with multiple phases and components
- 10.1103/physreve.49.2941 may be a valid DOI for title: Simulation of nonideal gases and liquid-gas phase transitions by the lattice Boltzmann equation
- 10.1103/physreve.75.026702 may be a valid DOI for title: Generalized lattice Boltzmann method with multirange pseudopotential
- 10.1103/physreve.87.013010 may be a valid DOI for title: Phase-field-based lattice Boltzmann finite-difference model for simulating thermocapillary flows

INVALID DOIs

- None
whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 2 years ago

Hi @ly16302 and thanks for your submission. Since the number of lines of code is borderline (around 1000), I am going to ask the greater editorial board to take a look and see if this is in scope. This process will take 1-2 weeks. Thanks for your patience.

kthyng commented 2 years ago

@whedon query scope

whedon commented 2 years ago

Submission flagged for editorial review.

danielskatz commented 2 years ago

👋 @ly16302 - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

danielskatz commented 2 years ago

@whedon reject

whedon commented 2 years ago

Paper rejected.