openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: robustHD: An R package for robust regression with high-dimensional data #3779

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @aalfons (Andreas Alfons) Repository: https://github.com/aalfons/robustHD/ Version: 0.7.0 Editor: @mikldk Reviewers: @valentint, @msalibian Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3929d5aaa6df61cea6e470253df4a258"><img src="https://joss.theoj.org/papers/3929d5aaa6df61cea6e470253df4a258/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3929d5aaa6df61cea6e470253df4a258/status.svg)](https://joss.theoj.org/papers/3929d5aaa6df61cea6e470253df4a258)

Author instructions

Thanks for submitting your paper to JOSS @aalfons. Currently, there isn't an JOSS editor assigned to your paper.

@aalfons if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

Wordcount for paper.md is 1545

whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.06 s (1250.5 files/s, 184250.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               54            566           3707           3816
C++                              8            139            699           1261
Markdown                         2             66              0            253
TeX                              1             14              0            137
C/C++ Header                     8             46             60             95
C                                1              3              1             40
-------------------------------------------------------------------------------
SUM:                            74            834           4467           5602
-------------------------------------------------------------------------------

Statistical information for the repository '69652df2ac313c35c895555d' was
gathered on 2021/09/29.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Andreas Alfons                  45          4408           2075          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Andreas Alfons             2344           53.2         92.2               34.56
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1198/016214507000000950 may be a valid DOI for title: Robust Linear Model Selection Based on Least Angle Regression
- 10.1214/12-aoas575 may be a valid DOI for title: Sparse Least Trimmed Squares Regression for Analyzing High-Dimensional Large Data Sets
- 10.1016/j.csda.2015.02.007 may be a valid DOI for title: Robust Groupwise Least Angle Regression
- 10.1016/j.csda.2017.02.002 may be a valid DOI for title: Robust and Sparse Estimators for Linear Regression Models
- 10.1016/j.chemolab.2017.11.017 may be a valid DOI for title: Robust and Sparse Estimation Methods for High-Dimensional Linear and Logistic Regression
- 10.1080/00401706.2017.1305299 may be a valid DOI for title: Robust Lasso Regression Using Tukey’s Biweight Criterion
- 10.1214/19-aoas1269 may be a valid DOI for title: Robust Elastic Net Estimators for Variable Selection and Identification of Proteomic Biomarkers
- 10.21203/rs.2.15653/v3 may be a valid DOI for title: Dysbiosis, Gut Barrier Dysfunction and Inflammation in Dementia: A Pilot Study
- 10.3389/fevo.2020.583831 may be a valid DOI for title: Chironomidae Morphological Types and Functional Feeding Groups as a Habitat Complexity Vestige

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 3 years ago

👋 @aalfons - while we find an editor, you could work on the possibly missing DOIs that whedon suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @whedon check references to check again, and the command @whedon generate pdf when the references are right to make a new PDF. Whedon commands need to be the first entry in a new comment.

danielskatz commented 3 years ago

👋 @mikldk - would you be able to edit this JOSS submission?

danielskatz commented 3 years ago

@whedon invite @mikldk as editor

whedon commented 3 years ago

@mikldk has been invited to edit this submission.

aalfons commented 3 years ago

@danielskatz - My apologies, I added the DOI URL's instead of just the DOI's. I updated the bib file and I'll try again now to see if I did it correctly.

aalfons commented 3 years ago

@whedon check references

whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1198/016214507000000950 is OK
- 10.1214/12-AOAS575 is OK
- 10.1016/j.csda.2015.02.007 is OK
- 10.1111/j.2517-6161.1996.tb02080.x is OK
- 10.1016/j.csda.2017.02.002 is OK
- 10.1016/j.chemolab.2017.11.017 is OK
- 10.1080/00401706.2017.1305299 is OK
- 10.1214/19-AOAS1269 is OK
- 10.1186/s12877-020-01644-2 is OK
- 10.3389/fevo.2020.583831 is OK
- 10.1158/0008-5472.can-12-1370 is OK

MISSING DOIs

- None

INVALID DOIs

- None
aalfons commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikldk commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

OK, the editor is @mikldk

mikldk commented 3 years ago

@aalfons - thank you for the submission.

Do you have any suggestions for reviewers (here is a list of potential reviewers)?

aalfons commented 3 years ago

@mikldk - thanks for agreeing to be the editor.

msalibian is an expert in the field and one of the authors of the pense package, which I mention in the Related software section. He's on the list of potential reviewers you sent.

ineswilms is also an expert on robust statistics and high-dimensional data. But I have to mention that I recently started a project with her. We have not collaborated earlier, and the joint project is not related to the submitted work. If this is a conflict of interest, I can suggest someone else.

mikldk commented 3 years ago

@aalfons Thanks for your suggestions. I would appreciate if you could suggest an alternative to ineswilms for the reasons you mention, thanks.

aalfons commented 3 years ago

@mikldk - sure: valentint is one of the authors of the robustbase package, which is the main package on robust statistics in R, and he has also written the package rrcovHD which contains functionality such as robust PCA and outlier detection in high dimensions.

mikldk commented 3 years ago

@aalfons. Thanks. A few comments before I invite the reviewers:

aalfons commented 3 years ago

Point 1) Done.

Point 2) I deliberately used lambda in Figure 1 to maintain the connection with argument lambda of function sparseLTS(). However, if you prefer me to use expression(lambda), I can change that.

Point 3) When I checked the word count in paper.md with RStudio before submission, I got 1017 words excluding the metadata, so I was hoping it would still be ok. I designed the two examples to show off most of the functionality of the package (regularization, stepwise variable selection along a sequence, model selection via prediction error and via information criterion, examples of plots) in a rather compact form (6 pages including references). But if you prefer, I can remove the second example (robust groupwise least angle regression) from the paper. In that case I would still put both examples in README.Rmd, to keep the set of examples (that shows off most functionality) together in one place.

@mikldk - please let me know what you think and I'll make the changes accordingly.

mikldk commented 3 years ago

@aalfons Thanks. Ad 2: Fine with me :+1:. Ad 3: Let's hear what the reviewers say. Anyway, I think it would be nice to have the examples in the README, too.

mikldk commented 3 years ago

@msalibian, @valentint: Would you be interested in reviewing this submission to The Journal of Open Source Software? Reviews are open and based on a checklist. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If you have any questions or concerns please let me know.

aalfons commented 3 years ago

@mikldk - great, thanks! I'll add the examples in the README either way. I'll recompile the paper now to have the updated address in there.

aalfons commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

msalibian commented 3 years ago

@mikldk Yes. Sorry I forget if there's anything specific I need to do here to accept. Pls let me know.

aalfons commented 3 years ago

@mikldk - The two examples from the paper are now included in README as well.

@msalibian - Thanks for agreeing to review the paper!

valentint commented 3 years ago

Yes, I would like to review this paper. Is there something else to do to confirm my agreement?

Best regards, Valentin

On Thu, Sep 30, 2021 at 4:21 PM Mikkel Meyer Andersen < @.***> wrote:

@msalibian https://github.com/msalibian, @valentint https://github.com/valentint: Would you be interested in reviewing this submission to The Journal of Open Source Software https://joss.theoj.org/? Reviews are open and based on a checklist. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If you have any questions or concerns please let me know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3779#issuecomment-931368340, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOHVCOKJNOP2LMV7LFUGDLUERW5RANCNFSM5FAEKXZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mikldk commented 3 years ago

@msalibian, @valentint Thanks. No, not yet. I'll create a review issue and the you'll get an invite that you must accept.

mikldk commented 3 years ago

@whedon assign @valentint as reviewer

whedon commented 3 years ago

OK, @valentint is now a reviewer

mikldk commented 3 years ago

@whedon add @msalibian as reviewer

whedon commented 3 years ago

OK, @msalibian is now a reviewer

mikldk commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3786.