[PRE REVIEW]: PICOS: A Python interface to conic optimization solvers

[whedon]

Submitting author: @Viech (Maximilian Stahlberg) Repository: https://gitlab.com/picos-api/picos Version: v2.3 Editor: @melissawm Reviewers: @sfuxy, @marwahaha Managing EiC: Kevin M. Moerman

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bd72442e34002c825f672716b2870c98"><img src="https://joss.theoj.org/papers/bd72442e34002c825f672716b2870c98/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bd72442e34002c825f672716b2870c98/status.svg)](https://joss.theoj.org/papers/bd72442e34002c825f672716b2870c98)

Author instructions

Thanks for submitting your paper to JOSS @Viech. Currently, there isn't an JOSS editor assigned to your paper.

@Viech if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

PDF failed to compile for issue #3835 with the following error:

 Can't find any papers to compile :-(

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.60 s (301.8 files/s, 95674.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         152          10388          13813          27230
reStructuredText                22           1059           1362           2895
YAML                             3             35             72            300
DOS Batch                        1             23              1            166
make                             1             28              6            145
Bourne Shell                     3             32             58             75
-------------------------------------------------------------------------------
SUM:                           182          11565          15312          30811
-------------------------------------------------------------------------------

Statistical information for the repository '2793d92489c8b8b0e5c456ed' was
gathered on 2021/10/19.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Arno Ulbricht                    2           111              7            0.04
Guillaume                       51         31019          53135           25.67
Guillaume Sagnol               157         39135          15114           16.55
Guillaume Sagnol (th            15           949            169            0.34
Jin H. Jung                      1             6              5            0.00
Leonard Kleinhans                1             4              4            0.00
Malte Renken                     1             2              2            0.00
Maximilian Stahlberg           976         93714          64497           48.27
Peter Wittek                    14           286             58            0.10
Petur Helgi                      1             7              2            0.00
Ray Ganardi                      1             1              1            0.00
Seeland                          5           171             20            0.06
Sergio Callegari                 1             5              3            0.00
Shaun Ren                        4            28             18            0.01
Xavier Valcarce                  3            41              7            0.01
bzffourn                         4           188             28            0.07
bzfsagno                        67         23885           4966            8.80
bzfulbri                         1             2              0            0.00
gsagnol                          1             6              2            0.00
paul.fournel@gmail.c             1            87              0            0.03
ziofil                           3            46             36            0.03
Élie Gouzien                     1            17              3            0.01

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Guillaume                    12            0.0         73.8                0.00
Guillaume Sagnol           2180            5.6         19.3                7.98
Maximilian Stahlberg      49109           52.4         21.5               16.49
Peter Wittek                  2            0.7         66.6                0.00
bzfulbri                    125         6250.0         69.3               27.20
Élie Gouzien                  3           17.6         31.6                0.00

[Kevin-Mattheus-Moerman]

@whedon generate pdf from branch joss

[whedon]

Attempting PDF compilation from custom branch joss. Reticulating splines etc...

[whedon]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[Kevin-Mattheus-Moerman]

@whedon check references from branch joss

[whedon]

Attempting to check references... from custom branch joss

[whedon]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK

MISSING DOIs

- 10.1080/23307706.2017.1397554 may be a valid DOI for title: A rewriting system for convex optimization problems
- 10.1007/s12532-011-0026-8 may be a valid DOI for title: Pyomo: modeling and solving mathematical programs in Python

INVALID DOIs

- None

[Kevin-Mattheus-Moerman]

@whedon invite @melissawm as editor

[whedon]

@melissawm has been invited to edit this submission.

[Kevin-Mattheus-Moerman]

@Viech can you work on those potentially missing DOI's :point_up:

[Viech]

Hello!

The two proposed DOIs seem correct; I added both to paper.bib. Note that the journal paper here has a DOI in the URL but doi.org does not recognize it, so I left it without one.

Making my co-author @gsagnol aware of this review.

[Viech]

From the list of reviewers who claim Python as a preferred language, for each group in the order that they appear in the list:

• bleyerj and sfuxy have convex optimization in their topics;
• nmoran, TejasAvinashShetty and marwahaha name quantum information which PICOS offers a few specialized features for;
• sayakpaul has tagged adversarial robustness which fits the recent (D)RO support of PICOS.

So from that list, maybe sfuxy, marwahaha and sayakpaul would be a good trio with diverse perspectives.

[melissawm]

@whedon assign @melissawm as editor

[whedon]

OK, the editor is @melissawm

[melissawm]

Thanks for your patience, I have been out of office.

👋🏻 Hello @sfuxy, @marwahaha, @sayakpaul would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[marwahaha]

I can review sometime in December.

[sayakpaul]

Hi @melissawm. Unfortunately, I will have to pass this one out.

[sfuxy]

Hello Melissa,

Yes, I will be able to start reviewing after thanksgiving. I’m very familiar with conic programming, SOCP/SDP but it’s my first time review with JOSS. If I have questions related to the review process, can I refer them to you?

Thanks, Silvano

Il giorno martedì 9 novembre 2021, Melissa Weber Mendonça < @.***> ha scritto:

Thanks for your patience, I have been out of office.

👋🏻 Hello @sfuxy https://github.com/sfuxy, @marwahaha https://github.com/marwahaha, @sayakpaul https://github.com/sayakpaul would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3835#issuecomment-964225441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGZ2GR2PNLPGYMXOJIPRMLULEYXNANCNFSM5GJLAYSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[melissawm]

Of course, @sfuxy - that is perfectly fine, feel free to ping if you have any questions. If @Viech is ok with the review starting in december, I can assign @marwahaha, otherwise we can try to find another reviewer.

Just for information, I will assign @sfuxy as reviewer but the actual review issue will only start after a second reviewer is decided on.

[melissawm]

@whedon assign @sfuxy as reviewer

[whedon]

OK, @sfuxy is now a reviewer

[Viech]

I'm fine with the review starting in December!

[melissawm]

Great, then I'll add @marwahaha as a reviewer and we can start. This will automatically close this issue, and a new one (where the actual review will happen) will be opened, and you all will be tagged on it. Thanks!

[melissawm]

@whedon add @marwahaha as reviewer

[whedon]

OK, @marwahaha is now a reviewer

[melissawm]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3915.