search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: DEVSIM: A TCAD Semiconductor Device Simulator #3854

Closed whedon closed 2 years ago

whedon commented 3 years ago

Submitting author: @tcaduser (Juan E. Sanchez) Repository: https://github.com/devsim/devsim.git Version: v1.6.0 Editor: @lucydot Reviewers: @jgoldfar, @dalonsoa Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/962b5ad390d866433b5efb68b4b68168"><img src="https://joss.theoj.org/papers/962b5ad390d866433b5efb68b4b68168/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/962b5ad390d866433b5efb68b4b68168/status.svg)](https://joss.theoj.org/papers/962b5ad390d866433b5efb68b4b68168)

Author instructions

Thanks for submitting your paper to JOSS @tcaduser. Currently, there isn't an JOSS editor assigned to your paper.

@tcaduser if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

PDF failed to compile for issue #3854 with the following error: 

 Can't find any papers to compile :-(
whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.41 s (1424.1 files/s, 216174.1 lines/s)
----------------------------------------------------------------------------------
Language                        files          blank        comment           code
----------------------------------------------------------------------------------
C++                               195           8695           4117          42382
C/C++ Header                      194           3372           3045           8817
Python                             90           1423           2319           4529
yacc                                3            148             96           1500
Fortran 77                         15              3           2606           1495
CMake                              32            179            134           1012
Bourne Shell                       37            214            252            859
GLSL                                6             70             32            657
lex                                 3            134             50            475
Markdown                            4            127              0            198
Tcl/Tk                              2             28             41            103
Windows Message File                5             27              0             95
YAML                                2             54            127             88
DOS Batch                           1             11              0             40
C Shell                             1              1              0              7
----------------------------------------------------------------------------------
SUM:                              590          14486          12819          62257
----------------------------------------------------------------------------------

Statistical information for the repository 'f12a855ed53acedc8c5113a0' was
gathered on 2021/10/26.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Juan                             2         65898              0           49.84
Juan E Sanchez                   1            57             48            0.08
Juan E. Sanchez                162         39049          26658           49.70
Juan Sanchez                     3           408             94            0.38

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Juan E. Sanchez           78699          201.5         14.6               13.33
kthyng commented 3 years ago

@whedon generate pdf from branch joss

whedon commented 3 years ago 
Attempting PDF compilation from custom branch joss. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 3 years ago

Hi @lucydot are you interested in editing this submission?

kthyng commented 3 years ago

@whedon invite @lucydot as editor

whedon commented 3 years ago

@lucydot has been invited to edit this submission.

lucydot commented 3 years ago

Hi @kthyng yes I'd be happy to be editor for this 👍

lucydot commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

OK, the editor is @lucydot

lucydot commented 3 years ago

Hi @tcaduser I'll be your editor for this submission 👋

Do you have any suggestions for potential reviewers? If so it'd be useful if you could mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

tcaduser commented 3 years ago

Hi @lucydot, thank you for being editor. Based on the domain topics from people on your list, I think these may be good candidates: MikeHeiber dalonsoa (Their simulator is cited in my work) alvesjnr Jgoldfar

lucydot commented 3 years ago

Hi @tcaduser thanks for the suggestions!

Hi @Jgoldfar and @dalonsoa 👋 are you available to review this submission?

jgoldfar commented 3 years ago

Hi there Lucy, and thanks for thinking of me. I would be able to review this work within the month, if that timeline works for this publication.

dalonsoa commented 3 years ago

Hi @lucydot , same here. Happy to provide a review for this during November.

lucydot commented 2 years ago

hi @jgoldfar and @dalonsoa - thank-you for your speedy responses and for agreeing to review 🎈

lucydot commented 2 years ago

@whedon assign @jgoldfar as reviewer

whedon commented 2 years ago

OK, @jgoldfar is now a reviewer

lucydot commented 2 years ago

@whedon add @dalonsoa as reviewer

whedon commented 2 years ago

OK, @dalonsoa is now a reviewer

lucydot commented 2 years ago

@jgoldfar @dalonsoa thank-you for agreeing to review. I'll ask our bot Whedon to start a review issue thread (this is the pre-review thread) - the review guidelines will be listed at the top of that new thread.

We're asking for reviews to be complete within a 4-6 week period. As the review is usually an iterative process (rather than something you do in one sitting) it's best for reviews to start earlier in that timeline - providing the review through November will work well 👍

lucydot commented 2 years ago

@whedon start review

whedon commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3898.

jgoldfar commented 2 years ago

@whedon re-invite @jgoldfar as reviewer

whedon commented 2 years ago

I'm sorry @jgoldfar, I'm afraid I can't do that. That's something only editors are allowed to do.

jgoldfar commented 2 years ago

Hi @lucydot - I think you may need to run the above command for me to be able to submit my review (found this on https://joss.readthedocs.io/en/latest/whedon.html)

danielskatz commented 2 years ago

@whedon re-invite @jgoldfar as reviewer

whedon commented 2 years ago

OK, the reviewer has been re-invited.

@jgoldfar please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations

danielskatz commented 2 years ago

Sorry, this actually should have been done in the review thread, not here, but I think it will still work.