openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: SimuPy: A python framework for modeling and simulating dynamical systems #386

Closed whedon closed 7 years ago

whedon commented 7 years ago

Submitting author: @sixpearls (Benjamin Margolis) Repository: https://github.com/simupy/simupy Version: v1.0.0 Editor: @cmadan Reviewer: @demotu

Author instructions

Thanks for submitting your paper to JOSS @sixpearls. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@sixpearls if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 7 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands
sixpearls commented 7 years ago

In terms of preferred languages and subject area, @moorepants is probably the best suited reviewer. However, we're at the same institution (and we know each other); I don't know what the JOSS policy is for this situation. In general I would trust @moorepants's ability to determine if he could be fair, especially so with the open discussion format. There are also a number of other reviewers who should be able to provide good feedback in addition to @moorepants.

If possible, I would appreciate it if the reviewer would be willing to work with me to get a DOI by Sept 8th so I can reference it in a conference manuscript. That's pretty soon, so I don't expect that to be treated as a hard constraint.

Thanks! Ben

sixpearls commented 7 years ago

I just wanted to check in, @arfon. Would it be appropriate to suggest other reviewers/editors? I see a number of people familiar using Python and MATLAB (this project could be compared to Simulink) for solving ODE's and doing numerical modeling.

cMadan commented 7 years ago

@whedon assign @cmadan as editor

whedon commented 7 years ago

OK, the editor is @cmadan

cMadan commented 7 years ago

@sixpearls, I'm happy to serve as editor for this submission :)

@moorepants, if you think you can objectively review this project (and are otherwise available), I think it's fine to have you as a reviewer here. If not, perhaps @sixpearls can suggest someone else from the list linked in the first comment here.

moorepants commented 7 years ago

I'd prefer if some other reviewers are asked before me. Ben is a graduate student in my department's program and it would be best if there was a bit more conflict of interest gap between us. If no one else can do it, I may have time to do the review.

sixpearls commented 7 years ago

Thanks, @moorepants. I understand the preference!

It looks like @lheagy, @kyleniemeyer, and @katyhuff are all python users who might be familiar with this type of simulation. Perhaps one of you might be willing to review this?

katyhuff commented 7 years ago

@sixpearls : I can probably do this review, but not for a few weeks -- I'm booked solid for a while. Hopefully @lheagy or @kyleniemeyer will agree to review!

kyleniemeyer commented 7 years ago

@cMadan @sixpearls I could also probably review this, but I'd like to recommend finding a reviewer that isn't a JOSS editor... our plates are already pretty full.

moorepants commented 7 years ago

@sixpearls FYI, I found reviewers for my recent submission by looking for similar software on github and then asking the authors of those packages to review.

lheagy commented 7 years ago

@sixpearls, @cMadan: I would be happy to help with the review but I am travelling for the next 4 weeks so I am going to be slower to respond and am likely not the best choice to take point on the review. If you do find someone else to take point, I am happy to be a second reviewer

sixpearls commented 7 years ago

@katyhuff @kyleniemeyer @lheagy thanks for your responses. Appreciate you all taking the time to respond. Thanks for the suggestion about cross-referencing the editorial board list.

From the list, it looks like @arghdos and @mosteo work in related areas and use python. Beyond that, it would start to be at least a little out of field and/or preferred programming language based on the suggested reviewer list. I'm not sure how much that matters.

@moorepants thanks for the suggestion!

@demotu @siboles @stavness @melund @jslee02 @cybanical @chrisdembia would any of you be willing to review my submission to JOSS? I believe you're all familiar with the journal, but the review guidelines are here.

demotu commented 7 years ago

Yes, I can review your submission; the simupy sounds very interesting.

@demotu https://github.com/demotu

- Marcos Duarte http://demotu.org/

On Wed, Sep 6, 2017 at 1:26 AM, Ben Margolis notifications@github.com wrote:

@katyhuff https://github.com/katyhuff @kyleniemeyer https://github.com/kyleniemeyer @lheagy https://github.com/lheagy thanks for your responses. Appreciate you all taking the time to respond. Thanks for the suggestion about cross-referencing the editorial board list.

From the list, it looks like @arghdos https://github.com/arghdos and @mosteo https://github.com/mosteo work in related areas and use python. Beyond that, it would start to be at least a little out of field and/or preferred programming language based on the suggested reviewer list. I'm not sure how much that matters.

@moorepants https://github.com/moorepants thanks for the suggestion!

@demotu https://github.com/demotu @siboles https://github.com/siboles @stavness https://github.com/stavness @melund https://github.com/melund @jslee02 https://github.com/jslee02 @cybanical https://github.com/cybanical @chrisdembia https://github.com/chrisdembia would any of you be willing to review my submission https://github.com/simupy/simupy to JOSS http://joss.theoj.org/? I believe you're all familiar with the journal, but the review guidelines are here http://joss.theoj.org/about#reviewer_guidelines.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/386#issuecomment-327371057, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHrnZnmT9JIqK8Hv2XpLeMyJgJaaOppks5sfh8QgaJpZM4PHgdR .

cMadan commented 7 years ago

@demotu, great! I'll set you as the reviewer then and start the review process.

If anyone else also wants to contribute to the review, please feel free to also make comments in the review issue.

cMadan commented 7 years ago

@whedon assign @demotu as reviewer

whedon commented 7 years ago

OK, the reviewer is @demotu

cMadan commented 7 years ago

@whedon start review

whedon commented 7 years ago

You didn't say the magic word! Try this:

@whedon start review magic-word=bananas
cMadan commented 7 years ago

@whedon start review magic-word=bananas

whedon commented 7 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/396. Feel free to close this issue now!