[PRE REVIEW]: RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method

whedon commented 3 years ago

Submitting author: @PolymerGuy (Sindre Nordmark Olufsen) Repository: https://github.com/PolymerGuy/recolo Version: v1.0.0 Editor: @Kevin-Mattheus-Moerman Reviewers: @nicoguaro, @corentin-dev Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9c0b1dc9e5e554516bcad0fb918f4708"><img src="https://joss.theoj.org/papers/9c0b1dc9e5e554516bcad0fb918f4708/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9c0b1dc9e5e554516bcad0fb918f4708/status.svg)](https://joss.theoj.org/papers/9c0b1dc9e5e554516bcad0fb918f4708)

Author instructions

Thanks for submitting your paper to JOSS @PolymerGuy. Currently, there isn't an JOSS editor assigned to your paper.

@PolymerGuy if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

whedon commented 3 years ago

Failed to discover a Statement of need section in paper

whedon commented 3 years ago

Wordcount for paper.md is 541

whedon commented 3 years ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/2041419621993492 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1016/j.ijmecsci.2020.106263 is OK
- 10.1007/s00348-019-2850-y is OK
- 10.1007/s11340-019-00530-2 is OK
- 10.1177/2041419616666236 is OK

MISSING DOIs

- None

INVALID DOIs

- None

whedon commented 3 years ago

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.09 s (591.2 files/s, 48752.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          41            804            852           1928
reStructuredText                 6            141             61            248
TeX                              2             10              0            174
Markdown                         2             31              0             98
YAML                             1              9              9             32
DOS Batch                        1              8              1             27
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            54           1007            929           2517
-------------------------------------------------------------------------------

Statistical information for the repository '0f2436c62b2aa78037767362' was
gathered on 2021/10/29.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Sindre Nordmark Oluf           181         12494           8915          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Sindre Nordmark Oluf       3584           28.7          1.8               10.46

whedon commented 3 years ago

PDF failed to compile for issue #3869 with the following error:

 /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/author.rb:72:in `block in build_affiliation_string': Problem with affiliations for Sindre Olufsen, perhaps the affiliations index need quoting? (RuntimeError)
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/author.rb:71:in `each'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/author.rb:71:in `build_affiliation_string'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/author.rb:17:in `initialize'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:205:in `new'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:205:in `block in parse_authors'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:202:in `each'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:202:in `parse_authors'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:93:in `initialize'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in `new'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in `set_paper'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:58:in `prepare'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:131:in `<top (required)>'
    from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
    from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'

kthyng commented 3 years ago

Hi @PolymerGuy! Please take a look at the paper errors above. Also you will need a section entitled "Statement of Need" in your paper.

kthyng commented 3 years ago

Hi @Kevin-Mattheus-Moerman are you interested in editing this submission?

kthyng commented 3 years ago

@whedon invite @Kevin-Mattheus-Moerman as editor

whedon commented 3 years ago

@Kevin-Mattheus-Moerman has been invited to edit this submission.

Kevin-Mattheus-Moerman commented 3 years ago

@whedon assign @Kevin-Mattheus-Moerman as editor

whedon commented 3 years ago

OK, the editor is @Kevin-Mattheus-Moerman

PolymerGuy commented 3 years ago

Hi @kthyng and @Kevin-Mattheus-Moerman ! I have now added the section "Statement of need" and hopefully fixed the bug related to affiliations above. When compiling the paper earlier I didn't get any warnings on this error but I think it's OK now. I'm taking the liberty to recompile the paper in order to uncover any remaining bugs.

PolymerGuy commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 3 years ago

@PolymerGuy I have started to look for reviewers for this submission. If you are able to suggest reviewers at this point that would be helpful. You can mention their github handle here but leave out the @ symbol.

PolymerGuy commented 3 years ago

@Kevin-Mattheus-Moerman From browsing through the list of reviewers, the following persons appear to have similar fields of research: chennachaos thelfer yangbai90 kegiljarhus iammix corentin-dev

Kevin-Mattheus-Moerman commented 3 years ago

@ahojukka5 @azzeddinetiba @jeevanjyoti4 @nicoguaro @ilyasst @diehlpk @thelfer @yangbai90 @kegiljarhus @corentin-dev would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): "RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method".

The smooth review process takes place on GitHub on a dedicated review issues (e.g. here is an example) and focuses on:

Let me know if you have any questions. Note that given the COVID pandemic we can be quite flexible regarding time needed to review. Thanks!

diehlpk commented 3 years ago

@Kevin-Mattheus-Moerman Just realized, you asked for reviewing. I do not have time to review in a timely manner.

nicoguaro commented 3 years ago

@Kevin-Mattheus-Moerman, I think that I can review it.

thelfer commented 3 years ago

@Kevin-Mattheus-Moerman I don't have any specific knowledge of this topic. I would prefer let someone else handle this review.

Kevin-Mattheus-Moerman commented 3 years ago

@whedon assign @nicoguaro as reviewer

whedon commented 3 years ago

OK, @nicoguaro is now a reviewer

Kevin-Mattheus-Moerman commented 3 years ago

@ahojukka5 @azzeddinetiba @jeevanjyoti4 @ilyasst @diehlpk @yangbai90 @kegiljarhus @corentin-dev would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): "RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method".

The smooth review process takes place on GitHub on a dedicated review issues (e.g. here is an example) and focuses on:

Let me know if you have any questions. Note that given the COVID pandemic we can be quite flexible regarding time needed to review. Thanks!

jeevanjyoti4 commented 3 years ago

I am really sorry. But I don't think I have the expertise to properly examine this work.

I hope to be able to contribute to the review process in the future.

Best regards, Jeevan

Dr Jeevanjyoti Chakraborty Assistant Professor Department of Mechanical Engineering Indian Institute of Technology (IIT) Kharagpur Kharagpur - 721302 West Bengal, India http://www.facweb.iitkgp.ac.in/~jeevanjyoti/

On Fri, 19 Nov 2021 at 15:52, Kevin Mattheus Moerman < @.***> wrote:

@ahojukka5 https://github.com/ahojukka5 @azzeddinetiba https://github.com/azzeddinetiba @jeevanjyoti4 https://github.com/jeevanjyoti4 @ilyasst https://github.com/ilyasst @diehlpk https://github.com/diehlpk @yangbai90 https://github.com/yangbai90 @kegiljarhus https://github.com/kegiljarhus @corentin-dev https://github.com/corentin-dev would you be interested in reviewing this work for the Journal of Open Source Software (JOSS) https://joss.theoj.org: "RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method".

The smooth review process https://joss.readthedocs.io/en/latest/reviewer_guidelines.html takes place on GitHub on a dedicated review issues (e.g. here is an example https://github.com/openjournals/joss-reviews/issues/3860) and focuses on:

A short paper https://github.com/openjournals/joss-papers/blob/joss.03869/joss.03869/10.21105.joss.03869.pdf

The software https://github.com/PolymerGuy/recolo

Let me know if you have any questions. Note that given the COVID pandemic we can be quite flexible regarding time needed to review. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3869#issuecomment-973941805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJMS7DCVHGIV2Z2D76MI25LUMYQOPANCNFSM5G7YCOYQ .

Kevin-Mattheus-Moerman commented 2 years ago

@jomorlier @ahojukka5 @azzeddinetiba @ilyasst @diehlpk @yangbai90 @kegiljarhus @corentin-dev would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): "RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method".

The smooth review process takes place on GitHub on a dedicated review issues (e.g. here is an example) and focuses on:

Let me know if you have any questions. Note that given the COVID pandemic we can be quite flexible regarding time needed to review. Thanks!

kegiljarhus commented 2 years ago

Dear Kevin,

Sorry for the late reply on this one. Thank you for considering me as a reviewer, but this falls outside my field of expertise so I hope someone else more suitable can contribute.

Regards, Knut Erik Giljarhus

On Tue, 23 Nov 2021 at 16:30, Kevin Mattheus Moerman < @.***> wrote:

@jomorlier https://github.com/jomorlier @ahojukka5 https://github.com/ahojukka5 @azzeddinetiba https://github.com/azzeddinetiba @ilyasst https://github.com/ilyasst @diehlpk https://github.com/diehlpk @yangbai90 https://github.com/yangbai90 @kegiljarhus https://github.com/kegiljarhus @corentin-dev https://github.com/corentin-dev would you be interested in reviewing this work for the Journal of Open Source Software (JOSS) https://joss.theoj.org: "RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method".

The smooth review process https://joss.readthedocs.io/en/latest/reviewer_guidelines.html takes place on GitHub on a dedicated review issues (e.g. here is an example https://github.com/openjournals/joss-reviews/issues/3860) and focuses on:

A short paper https://github.com/openjournals/joss-papers/blob/joss.03869/joss.03869/10.21105.joss.03869.pdf

The software https://github.com/PolymerGuy/recolo

Let me know if you have any questions. Note that given the COVID pandemic we can be quite flexible regarding time needed to review. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3869#issuecomment-976719665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXB3GF3SP22KK6U2LNBLODUNOXQVANCNFSM5G7YCOYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Kevin-Mattheus-Moerman commented 2 years ago

@jomorlier @ahojukka5 @azzeddinetiba @ilyasst @diehlpk @yangbai90 @corentin-dev would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): "RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method".

The smooth review process takes place on GitHub on a dedicated review issues (e.g. here is an example) and focuses on:

Let me know if you have any questions. Note that given the COVID pandemic we can be quite flexible regarding time needed to review. Thanks!

corentin-dev commented 2 years ago

@Kevin-Mattheus-Moerman I am willing to review this paper. Regards, Corentin

Kevin-Mattheus-Moerman commented 2 years ago

@whedon add @corentin-dev as reviewer

whedon commented 2 years ago

OK, @corentin-dev is now a reviewer

Kevin-Mattheus-Moerman commented 2 years ago

@corentin-dev thanks for agreeing to help with this review! Is it correct that this is you: https://lmrs.univ-rouen.fr/fr/persopage/corentin-lothode, it would be good to confirm (and as a suggestion to perhaps add your full name and affiliation to your GitHub profile).

corentin-dev commented 2 years ago

@Kevin-Mattheus-Moerman done

Kevin-Mattheus-Moerman commented 2 years ago

@whedon start review

whedon commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3980.

openjournals / joss-reviews

[PRE REVIEW]: RECOLO: A Python package for the reconstruction of surface pressure loads from kinematic fields using the virtual fields method #3869

Status

Dr Jeevanjyoti Chakraborty Assistant Professor Department of Mechanical Engineering Indian Institute of Technology (IIT) Kharagpur Kharagpur - 721302 West Bengal, India http://www.facweb.iitkgp.ac.in/~jeevanjyoti/