openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: TriP: A Python package for the kinematic modeling of serial-parallel hybrid robots #3871

Closed whedon closed 2 years ago

whedon commented 3 years ago

Submitting author: @liquidcronos (Jan Baumgärtner) Repository: https://github.com/TriPed-Robot/TriP Version: v1.0.0 Editor: @danielskatz Reviewers: @SeungBack, @bmagyar Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/03c967bcda198bac6af1ef6342507c3f"><img src="https://joss.theoj.org/papers/03c967bcda198bac6af1ef6342507c3f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/03c967bcda198bac6af1ef6342507c3f/status.svg)](https://joss.theoj.org/papers/03c967bcda198bac6af1ef6342507c3f)

Author instructions

Thanks for submitting your paper to JOSS @liquidcronos. Currently, there isn't an JOSS editor assigned to your paper.

@liquidcronos if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.06 s (511.6 files/s, 65275.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            408            532           1128
XML                              1              0              2            792
reStructuredText                 4            219            174            305
Markdown                         5             43              0             94
YAML                             3             17             18             75
make                             1              4              6             10
SVG                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                            30            691            732           2405
-------------------------------------------------------------------------------

Statistical information for the repository '80f7b7f79408c560e6df6fc2' was
gathered on 2021/10/30.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Jan Baumgärnter                 15           343            205            1.42
Jan Baumgärtner                 97         17351           2849           52.34
Torben Miller                   80          2635          15208           46.24

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Jan Baumgärnter            1770          516.0          1.4                7.18
Jan Baumgärtner             161            0.9          0.0               54.66
Torben Miller               137            5.2          5.5                7.30
whedon commented 3 years ago

PDF failed to compile for issue #3871 with the following error:

 Can't find any papers to compile :-(
danielskatz commented 3 years ago

@whedon check references from branch paper

whedon commented 3 years ago
Attempting to check references... from custom branch paper
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.mechatronics.2020.102367 is OK
- 10.1007/s12532-018-0139-4 is OK
- 10.3390/app10072567 is OK
- 10.1007/s11044-005-4196-x is OK
- 10.1109/70.88066 is OK
- 10.1115/1.4005233 is OK
- 10.1007/1-4020-4133-0_2 is OK
- 10.1109/TMECH.2006.871087 is OK

MISSING DOIs

- 10.1016/j.apm.2015.04.020 may be a valid DOI for title: Unified solving inverse dynamics of 6-DOF serial–parallel manipulators
- 10.1007/s12206-016-1036-2 may be a valid DOI for title: Kinematics and dynamics analysis of a novel serial-parallel dynamic simulator
- 10.1109/humanoids.2014.7041473 may be a valid DOI for title: Overview of the torque-controlled humanoid robot TORO
- 10.1109/mra.2011.2181749 may be a valid DOI for title: Moveit![ros topics]

INVALID DOIs

- https://doi.org/10.1016/j.mechmachtheory.2008.03.002 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.rcim.2012.09.016 is INVALID because of 'https://doi.org/' prefix
danielskatz commented 3 years ago

@whedon generate pdf from branch paper

whedon commented 3 years ago
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 3 years ago

👋 @liquidcronos - thanks for your submission. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

In addition, you could work on the possibly missing DOIs that whedon suggests (and incorrect DOIs), but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @whedon check references from branch paper to check again, and the command @whedon generate pdf from branch paper when the references are right to make a new PDF. Whedon commands need to be the first entry in a new comment.

danielskatz commented 3 years ago

@whedon query scope

whedon commented 3 years ago

Submission flagged for editorial review.

liquidcronos commented 3 years ago

Hey @danielskatz thanks for considering TriP. Most of these DOIs seem to be from bibtex entries that aren't used in the paper, I will will these Issues right away.

liquidcronos commented 3 years ago

@whedon check references from branch paper

whedon commented 3 years ago
Attempting to check references... from custom branch paper
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.mechatronics.2020.102367 is OK
- 10.1007/s12532-018-0139-4 is OK
- 10.1109/TMECH.2006.871087 is OK
- 10.1016/j.mechmachtheory.2008.03.002 is OK
- 10.1016/j.rcim.2012.09.016 is OK
- 10.1109/MRA.2011.2181749 is OK

MISSING DOIs

- None

INVALID DOIs

- None
liquidcronos commented 3 years ago

@whedon generate pdf from branch paper

whedon commented 3 years ago
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

liquidcronos commented 3 years ago

Everything seems to check out now

kyleniemeyer commented 3 years ago

Hi @liquidcronos, the editorial board has reviewed your submission and found that it meets our expectations for review, so this will continue. However, we do not have an editor available in this area right now, so I'm going to place this on our waitlist until someone becomes available (hopefully soon!)

Kevin-Mattheus-Moerman commented 2 years ago

@liquidcronos I've checked today (I am AEiC on call this week) and all editors in the robotics domain are still fully occupied with other submissions. I'll check again in a couple of days and we will proceed to invite/assign an editor once they become available.

liquidcronos commented 2 years ago

Thanks for the update @Kevin-Mattheus-Moerman . I have to say I have been really impressed so far with how open this process is!

danielskatz commented 2 years ago

Even though I'm not in the robotics domain, I'll go ahead and take this to edit

danielskatz commented 2 years ago

@whedon assign me as editor

whedon commented 2 years ago

OK, the editor is @danielskatz

danielskatz commented 2 years ago

👋 @liquidcronos - the next step is to find at least two reviewers. If you have any suggestions for potential reviewers, please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

liquidcronos commented 2 years ago

Hey @danielskatz thanks for the update, I have looked at the list and I found a number of suitable reviewers: sea-bass, nnadeau, CameronDevine, SeungBack and carlosjoserg

danielskatz commented 2 years ago

Thanks @liquidcronos - note that I've changed the title of this submission to fix a spelling error (seriell should be serial) - Can you do this in the paper.md as well?

danielskatz commented 2 years ago

👋 @sea-bass & @nnadeau - Would one or both of you be willing to review this JOSS submission?

liquidcronos commented 2 years ago

Thanks @liquidcronos - note that I've changed the title of this submission to fix a spelling error (seriell should be serial) - Can you do this in the paper.md as well?

Yeah, that the german spelling... Thanks for letting me know, it should be fixed now.

danielskatz commented 2 years ago

@whedon generate pdf from branch paper

whedon commented 2 years ago
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

engnadeau commented 2 years ago

unfortunately i'm not available at the moment

danielskatz commented 2 years ago

👋 @CameronDevine & @SeungBack - Would one or both of you be willing to review this JOSS submission?

SeungBack commented 2 years ago

Thank you for the suggestions, and I will participate in reviewing this paper.

CameronDevine commented 2 years ago

@danielskatz Unfortunately I don't have time at the moment.

danielskatz commented 2 years ago

Thanks @SeungBack - I'll add you in the system, but we won't start the review until we find one more reviewer.

danielskatz commented 2 years ago

@whedon assign @SeungBack as reviewer

whedon commented 2 years ago

OK, @SeungBack is now a reviewer

danielskatz commented 2 years ago

👋 @sea-bass - Would you be willing to review this JOSS submission? (just checking again)

sea-bass commented 2 years ago

wave @sea-bass & @nnadeau - Would one or both of you be willing to review this JOSS submission?

Hi all -- unfortunately I am unable to review at the moment. Thank you for asking!

danielskatz commented 2 years ago

👋 @carlosjoserg - Would you be willing to review this JOSS submission?

CameronDevine commented 2 years ago

In case they are interested, in the past I have reviewed similar submissions with @adi3 and @trallard and have had a similar submission of my own reviewed by @bmagyar and @amjaeger17.

danielskatz commented 2 years ago

Thanks @CameronDevine!!

danielskatz commented 2 years ago

👋 @adi3 and @trallard - Would one of you be willing to review this JOSS submission?

danielskatz commented 2 years ago

👋 @bmagyar and @amjaeger17 - Would one of you be willing to review this JOSS submission?

bmagyar commented 2 years ago

Happy to review this one!

danielskatz commented 2 years ago

Thanks @bmagyar - I'll add you and we'll get started!