openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: NeuralFieldEq.jl: A flexible solver to compute Neural Field Equations in several scenarios #3886

Closed whedon closed 2 years ago

whedon commented 2 years ago

Submitting author: @tiagoseq (Tiago Sequeira) Repository: https://github.com/tiagoseq/NeuralFieldEq.jl Version: v0.1.2 Editor: @jarvist Reviewers: @rougier, @gdetor Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/85354f0f2b6244439e90d51fe28a9ef5"><img src="https://joss.theoj.org/papers/85354f0f2b6244439e90d51fe28a9ef5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/85354f0f2b6244439e90d51fe28a9ef5/status.svg)](https://joss.theoj.org/papers/85354f0f2b6244439e90d51fe28a9ef5)

Author instructions

Thanks for submitting your paper to JOSS @tiagoseq. Currently, there isn't an JOSS editor assigned to your paper.

@tiagoseq if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 2 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 2 years ago

Wordcount for paper.md is 1046

whedon commented 2 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.08 s (497.8 files/s, 231814.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSS                              2            701             49          14825
Julia                           14            190            158            845
Markdown                         7            141              0            538
JavaScript                       5             44             78            511
HTML                             5             34              0            233
TeX                              1             13              0            120
YAML                             3              0              1            114
TOML                             2              5              0             20
JSON                             1              0              0              7
-------------------------------------------------------------------------------
SUM:                            40           1128            286          17213
-------------------------------------------------------------------------------

Statistical information for the repository 'f7f106851943d798c2b1f437' was
gathered on 2021/11/03.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
tiagoseq                         1           633              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
tiagoseq                    633          100.0          0.0               12.32
whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/JPROC.2004.840301 is OK
- 10.1002/cne.21974 is OK
- 10.1016/S0006-3495(72)86068-5 is OK
- 10.1103/PhysRevE.82.055701 is OK
- 10.1007/978-3-642-54593-1_6 is OK
- 10.3389/fninf.2015.00025 is OK
- 10.1186/2190-8567-4-1 is OK
- 10.1137/141000671 is OK
- 10.1109/ICSTCC.2019.8885972 is OK

MISSING DOIs

- 10.1007/bf00337259 may be a valid DOI for title: Dynamics of pattern formation in lateral.inhibition type neural fields

INVALID DOIs

- https://doi.org/10.1113/jphysiol.1952.sp004764 is INVALID because of 'https://doi.org/' prefix
whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 2 years ago

@tiagoseq - thanks for your submission. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

In addition, you could work on the possibly missing DOI that whedon suggests and the incorrect DOI, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @whedon check references to check again, and the command @whedon generate pdf when the references are right to make a new PDF. Whedon commands need to be the first entry in a new comment.

danielskatz commented 2 years ago

@whedon query scope

whedon commented 2 years ago

Submission flagged for editorial review.

tiagoseq commented 2 years ago

Hello, Some time ago, Nicolas Rougier suggested that I should submit the solver to JOSS and indicate him as a reviewer. Because the method implemented is based on the novel technique presented in this paper https://hal.inria.fr/hal-00872132 authored by Axel Hutt and Nicolas Rougier.

This solver handles with several types of Neural Field equations, being user friendly, easy to use and efficient as possible. As far as I can tell, there isn't other piece of software that brings together this features.

I will check the issues with DOI and update the .bib file.

Thank you, Tiago

Em qua., 3 de nov. de 2021 às 13:35, Daniel S. Katz < @.***> escreveu:

@tiagoseq https://github.com/tiagoseq - thanks for your submission. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort criterion for review by JOSS. You should hear back in a week or so.

In addition, you could work on the possibly missing DOI that whedon suggests and the incorrect DOI, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @whedon check references to check again, and the command @whedon generate pdf when the references are right to make a new PDF. Whedon commands need to be the first entry in a new comment.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3886#issuecomment-959092883, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARTOGDGQGX6GSQSD7XQKIODUKFCEBANCNFSM5HI55QTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kyleniemeyer commented 2 years ago

Hi @tiagoseq, we are going to proceed with review of your submission.

@drvinceknight do you think you could edit this submission? The author has one reviewer suggestion already.

kyleniemeyer commented 2 years ago

@whedon invite @drvinceknight as editor

whedon commented 2 years ago

@drvinceknight has been invited to edit this submission.

arfon commented 2 years ago

I've just emailed Vince directly to see if he might be able to take on this submission. If we don't hear back in a few days, we'll look for an alternative editor.

Kevin-Mattheus-Moerman commented 2 years ago

@arfon I'll proceed to invite an alternative editor

Kevin-Mattheus-Moerman commented 2 years ago

@jarvist it looks like this, although a neuroscientific application, might be a good editor for this. Are you able to help?

Kevin-Mattheus-Moerman commented 2 years ago

@whedon invite @jarvist as editor

whedon commented 2 years ago

@jarvist has been invited to edit this submission.

Kevin-Mattheus-Moerman commented 2 years ago

@jarvist could you help edit this work?

jarvist commented 2 years ago

@whedon assign @jarvist as editor

Yep, can do!

whedon commented 2 years ago

OK, the editor is @jarvist

jarvist commented 2 years ago

@tiagoseq do you have any reviewer suggestions? From looking at the fairly specialist problem domain, and the fairly specialist language (Julia), I suppose it might be easiest to find two reviewers with complementary scientific + programming language specific (+ PDE?) skills.

tiagoseq commented 2 years ago

Yes I've a suggestion for a reviewer is Nicolas P. Rougier, before submitting the paper I've talked with Rougier and he volunteered to be the reviewer.

In the meanwhile I'll check and correct the missing and invalid DOIs. Thank you

tiagoseq commented 2 years ago

@whedon check references

whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1113/jphysiol.1952.sp004764 is OK
- 10.1109/JPROC.2004.840301 is OK
- 10.1002/cne.21974 is OK
- 10.1016/S0006-3495(72)86068-5 is OK
- 10.1103/PhysRevE.82.055701 is OK
- 10.1007/978-3-642-54593-1_6 is OK
- 10.3389/fninf.2015.00025 is OK
- 10.1186/2190-8567-4-1 is OK
- 10.1007/BF00337259 is OK
- 10.1137/141000671 is OK
- 10.1109/ICSTCC.2019.8885972 is OK

MISSING DOIs

- None

INVALID DOIs

- None
tiagoseq commented 2 years ago

@whedon generate pdf

whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jarvist commented 2 years ago

@whedon invite @rougier as reviewer

OK! Let's ask Nicolas directly here, as he seems to be a regular user of GitHub.

We need at least two reviewers for JOSS. As Nicolas appears to be a domain expert, I suppose someone with PDE / Julia experience would be complementary.

whedon commented 2 years ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
jarvist commented 2 years ago

Ah sorry Whedon, I thought you could send them a ping.

rougier commented 2 years ago

I can review but I might be a bit late (note before end of December I would say)

jarvist commented 2 years ago

Great! As Tiago has already spoken with you, I presume such a timeline will be fine.

jarvist commented 2 years ago

@whedon assign @rougier as reviewer

whedon commented 2 years ago

OK, @rougier is now a reviewer

rougier commented 2 years ago

@gdetor or @sje30 might be interested in reviewing this as well.

gdetor commented 2 years ago

@rougier I could review it

jarvist commented 2 years ago

@whedon add @gdetor as reviewer

Great! Thank you Georgios.

whedon commented 2 years ago

OK, @gdetor is now a reviewer

jarvist commented 2 years ago

@whedon start review

Let's get this party started!

whedon commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3974.