openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
715 stars 38 forks source link

[PRE REVIEW]: CR-Sparse: Hardware accelerated functional algorithms for sparse signal processing in Python using JAX #3913

Closed whedon closed 2 years ago

whedon commented 2 years ago

Submitting author: @shailesh1729 (Shailesh Kumar) Repository: https://github.com/carnotresearch/cr-sparse Version: v0.2.1 Editor: @pdebuyl Reviewers: @Saran-nns, @mirca Managing EiC: Kyle Niemeyer

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ebd4e5ca27a5db705b1dc382b64e0bed"><img src="https://joss.theoj.org/papers/ebd4e5ca27a5db705b1dc382b64e0bed/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ebd4e5ca27a5db705b1dc382b64e0bed/status.svg)](https://joss.theoj.org/papers/ebd4e5ca27a5db705b1dc382b64e0bed)

Author instructions

Thanks for submitting your paper to JOSS @shailesh1729. Currently, there isn't an JOSS editor assigned to your paper.

@shailesh1729 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 2 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 2 years ago

Wordcount for paper.md is 4567

whedon commented 2 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.37 s (1025.9 files/s, 129110.6 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                          295           4312           8807          16578
TeX                               2            484              1           3212
reStructuredText                 54           1290           1498           1047
Markdown                          7            200              0            894
Jupyter Notebook                  9              0           8309            616
YAML                              4              9              7            148
JavaScript                        1              6             16            117
CSS                               1              9              0             37
JSON                              2              0              0             33
DOS Batch                         1              8              1             26
make                              1              5              7             13
Bourne Again Shell                1              2              0              3
Bourne Shell                      1              1              0              2
--------------------------------------------------------------------------------
SUM:                            379           6326          18646          22726
--------------------------------------------------------------------------------

Statistical information for the repository '58a6fcc132f55844517058c3' was
gathered on 2021/11/12.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Shailesh Kumar                 586         33402           3397          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Shailesh Kumar            30005           89.8          2.8               22.73
whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1145/3088525.3088527 may be a valid DOI for title: A computational model for TensorFlow: an introduction
- 10.1109/iccv.2001.937651 may be a valid DOI for title: Lambertian reflectance and linear subspaces
- 10.1109/jstsp.2010.2042411 may be a valid DOI for title: Normalized iterative hard thresholding: Guaranteed stability and performance
- 10.1109/wvm.1991.212809 may be a valid DOI for title: Factorization-based segmentation of motions
- 10.21236/ada521441 may be a valid DOI for title: Analysis of orthogonal matching pursuit using the restricted isometry property
- 10.1007/978-1-4419-7011-4 may be a valid DOI for title: Sparse and redundant representations
- 10.1109/tpami.2013.57 may be a valid DOI for title: Sparse subspace clustering: Algorithm, theory, and applications
- 10.1109/cvpr.2003.1211332 may be a valid DOI for title: Clustering appearances of objects under varying illumination conditions
- 10.1109/iccv.2001.937679 may be a valid DOI for title: Motion segmentation by subspace separation and model selection
- 10.1109/tpami.2005.92 may be a valid DOI for title: Acquiring linear subspaces for face recognition under variable lighting
- 10.21105/joss.01237 may be a valid DOI for title: PyWavelets: A Python package for wavelet analysis
- 10.1109/acssc.1993.342465 may be a valid DOI for title: Orthogonal matching pursuit: Recursive function approximation with applications to wavelet decomposition
- 10.1109/34.584098 may be a valid DOI for title: A paraperspective factorization method for shape and motion recovery
- 10.1007/bf00129684 may be a valid DOI for title: Shape and motion from image streams under orthography: a factorization method
- 10.1109/tit.2004.834793 may be a valid DOI for title: Greed is good: Algorithmic results for sparse approximation
- 10.1109/cvpr.2016.425 may be a valid DOI for title: Scalable sparse subspace clustering by orthogonal matching pursuit
- 10.1007/s11263-012-0535-6 may be a valid DOI for title: Hybrid linear modeling via local best-fit flats

INVALID DOIs

- None
kyleniemeyer commented 2 years ago

Hi @shailesh1729, while we are getting started with this submission, can you please check the missing DOIs in your references and add those where appropriate?

kyleniemeyer commented 2 years ago

@whedon invite @pdebuyl as editor

@pdebuyl could you edit this submission?

whedon commented 2 years ago

@pdebuyl has been invited to edit this submission.

shailesh1729 commented 2 years ago

Hi, I have updated the DOIs as reported missing.

shailesh1729 commented 2 years ago

@whedon generate pdf

whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

shailesh1729 commented 2 years ago

@whedon commands

whedon commented 2 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository
shailesh1729 commented 2 years ago

@whedon check references

whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1145/3088525.3088527 is OK
- 10.1109/ICCV.2001.937651 is OK
- 10.1016/j.acha.2009.04.002 is OK
- 10.1109/jstsp.2010.2042411 is OK
- 10.1109/wvm.1991.212809 is OK
- 10.1023/A:1008000628999 is OK
- 10.1109/tit.2009.2016006 is OK
- 10.1109/tit.2010.2054653 is OK
- 10.1007/978-1-4419-7011-4 is OK
- 10.1109/cvprw.2009.5206547 is OK
- 10.1109/tpami.2013.57 is OK
- 10.1109/CVPR.2003.1211332 is OK
- 10.1109/iccv.2001.937679 is OK
- 10.1109/tpami.2005.92 is OK
- 10.21105/joss.01237 is OK
- 10.1016/b978-0-12-374370-1.x0001-8 is OK
- 10.1016/j.acha.2008.07.002 is OK
- 10.1109/acssc.1993.342465 is OK
- 10.1109/34.584098 is OK
- 10.1007/bf00129684 is OK
- 10.1175/1520-0477(1998)079<0061:APGTWA>2.0.CO;2 is OK
- 10.1109/TIT.2004.834793 is OK
- 10.1109/MSP.2010.939739 is OK
- 10.1109/CVPR.2016.425 is OK
- 10.1007/s11263-012-0535-6 is OK

MISSING DOIs

- None

INVALID DOIs

- None
pdebuyl commented 2 years ago

@kyleniemeyer yes I'll edit

pdebuyl commented 2 years ago

@whedon assign me as editor

whedon commented 2 years ago

OK, the editor is @pdebuyl

pdebuyl commented 2 years ago

@saran-nns @mirca would you review the article "CR-Sparse: Hardware accelerated functional algorithms for sparse signal processing in Python using JAX" for the Journal of Open Source Software?

Saran-nns commented 2 years ago

Hi @pdebuyl yes I'd be happy to review

pdebuyl commented 2 years ago

Hi @Saran-nns thanks for accepting!

pdebuyl commented 2 years ago

@whedon assign @Saran-nns as reviewer

whedon commented 2 years ago

OK, @Saran-nns is now a reviewer

mirca commented 2 years ago

@pdebuyl Sure, I'm able to review it.

pdebuyl commented 2 years ago

Hi @mirca thanks for accepting!

pdebuyl commented 2 years ago

@whedon add @mirca as reviewer

whedon commented 2 years ago

OK, @mirca is now a reviewer

pdebuyl commented 2 years ago

@whedon start review

whedon commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3917.