openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: bittrex: A R Client for the Bittrex Crypto-Currency Exchange #393

Closed whedon closed 7 years ago

whedon commented 7 years ago

Submitting author: @kaneplusplus (Michael Kane) Repository: https://github.com/ropensci/bittrex/ Version: v0.1.6 Editor: @arfon Reviewer: @arfon

Author instructions

Thanks for submitting your paper to JOSS @kaneplusplus. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@kaneplusplus if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 7 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @arfon it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
arfon commented 7 years ago

👋 @kaneplusplus - thanks for your submission to JOSS. We've recently tightened up our submission criteria for JOSS (this pre-dates your submission to rOpensci). Would you be able to add some extra language to this paper.md to address the submission criteria. In particular, this item:

  • Your software should have an obvious research application

Could you confirm here that there is a research application for this software (and explain what that application is in the paper)? The section 'what should my paper contain' has some guidance for the sort of content we're looking to be present in the paper.md.

Many thanks!

kaneplusplus commented 7 years ago

@arfon Yes, this is not problem and I'm happy to make this clearer. I confirm this does have research applications. A few financial/economics research areas and topics include:

I will clean this up and revise paper.md in the next couple of days and follow up.

kaneplusplus commented 7 years ago

@afron The extra language has been added. Please let me know if you need anything else.

arfon commented 7 years ago

@afron The extra language has been added. Please let me know if you need anything else.

@kaneplusplus many thanks.

arfon commented 7 years ago

@kaneplusplus - could you link to the rOpensci onboarding thread here please?

karthik commented 7 years ago

@arfon https://github.com/ropensci/onboarding/issues/120

arfon commented 7 years ago

@whedon set @arfon as reviewer

arfon commented 7 years ago

@whedon start review magic-word=bananas

arfon commented 7 years ago

@whedon assign @arfon as reviewer

whedon commented 7 years ago

OK, the reviewer is @arfon

arfon commented 7 years ago

@whedon start review magic-word=bananas

whedon commented 7 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/402. Feel free to close this issue now!