search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
717 stars 38 forks source link

[REVIEW]: Elephas: Distributed Deep Learning with Keras & Spark #4073

Closed whedon closed 1 year ago

whedon commented 2 years ago

Submitting author: !--author-handle-->@maxpumperla<!--end-author-handle-- (Max Pumperla) Repository: https://github.com/danielenricocahall/elephas Branch with paper.md (empty if default branch): mp_joss_paper Version: 3.4.7 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @sepandhaghighi, @nmoran Archive: 10.5281/zenodo.7435012

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b"><img src="https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b/status.svg)](https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@marksantcroos & @burch-cm, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @taless474 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

whedon commented 2 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @marksantcroos, @burch-cm it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 2 years ago

PDF failed to compile for issue #4073 with the following error: 

 Can't find any papers to compile :-(
whedon commented 2 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.07 s (1015.4 files/s, 73307.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          47            722            421           2591
Markdown                        12             89              0            254
Jupyter Notebook                 1              0            495             88
YAML                             3              4              1             70
Dockerfile                       1             14              4             55
INI                              1              3              0              7
Bourne Shell                     1              3              3              4
Groovy                           1              2              5              2
-------------------------------------------------------------------------------
SUM:                            67            837            929           3071
-------------------------------------------------------------------------------

Statistical information for the repository '4edeb354999f132b47760c26' was
gathered on 2022/01/18.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
10056727                         1             1              1            0.01
A-Fayez92                        1             1              1            0.01
Alberto Fumagalli                1             1              1            0.01
Ana Maria Martinez F             4             6              9            0.10
Gaurav Yeole                     1             1              1            0.01
Ivan Montero                     1             2              0            0.01
JONATHAN-DS\Jonathan             2            22             32            0.36
Jose Alvarez                     2             3              2            0.03
Liang-Chi Hsieh                  1             4              4            0.05
Max                              2             2              0            0.01
Max Pumperla                   187          6976           3035           67.14
Oscar Pan                       21           193             92            1.91
Samangooei                       5            82             45            0.85
Willem Meints                    1            11              2            0.09
Yuan Yifan                       1             4              3            0.05
danielenricocahall             101          1855           2424           28.70
ivanmontero                      1             4              1            0.03
jordan vega                      2            20              2            0.15
spencerimp                       1            62              5            0.45

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
JONATHAN-DS\Jonathan          5           22.7         42.4                0.00
Jose Alvarez                  2           66.7         32.5                0.00
Liang-Chi Hsieh               3           75.0         67.8               33.33
Max Pumperla               2506           35.9         43.9                8.90
Oscar Pan                   139           72.0          5.0                4.32
Samangooei                    4            4.9         59.9                0.00
Yuan Yifan                    2           50.0         12.6                0.00
danielenricocahall         1059           57.1          6.5                5.19
jordan vega                  14           70.0         33.2                0.00
whedon commented 2 years ago

:wave: @marksantcroos, please update us on how your review is going (this is an automated reminder).

whedon commented 2 years ago

:wave: @burch-cm, please update us on how your review is going (this is an automated reminder).

taless474 commented 2 years ago

@marksantcroos, how is the review going?

taless474 commented 2 years ago

@burch-cm, how is the review going?

taless474 commented 2 years ago

@marksantcroos, how is the review going?

taless474 commented 2 years ago

@burch-cm, how is the review going?

taless474 commented 2 years ago

@marksantcroos, @burch-cm, please update on your reviews.

taless474 commented 2 years ago

@marksantcroos, @burch-cm, please update on your reviews.

taless474 commented 2 years ago

@marksantcroos, would you please update on your review?

taless474 commented 2 years ago

@burch-cm, would you please update your review?

taless474 commented 2 years ago

@marksantcroos, @burch-cm, any updates?

taless474 commented 2 years ago

@marksantcroos, @burch-cm, any updates?

arfon commented 2 years ago

@taless474 – if you haven't already, I would recommend emailing the reviewers directly incase they are missing these notifications on GitHub.

taless474 commented 2 years ago

@arfon I emailed them on August 2nd. I will send another email today.

burch-cm commented 2 years ago

Hello, I got the email, and I've been unable to install the software or resolve the dependency issues. While I am still interested in helping with reviews, I don't currently have the technical expertise to troubleshoot the issues with Spark/PySpark/Java and I'm sure this will cause even more delays.

Please remove me as a reviewer at this time. Thank you.

arfon commented 1 year ago

:wave: @taless474 – it looks like this submission could do with new reviewers at this stage. What do you think?

arfon commented 1 year ago

@editorialbot assign @diehlpk as editor

:wave: folks – @diehlpk has kindly volunteered to step in as the handling editor here as @taless474 is not currently available to edit. Thanks Patrick!

editorialbot commented 1 year ago

Assigned! @diehlpk is now the editor

diehlpk commented 1 year ago

@editorialbot remove @burch-cm as reviwer

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

diehlpk commented 1 year ago

@editorialbot remove @burch-cm as reviewer

editorialbot commented 1 year ago

@burch-cm removed from the reviewers list!

diehlpk commented 1 year ago

@marksantcroos Are you still available? If I do not hear back from you by October 21th, I will remove you as a reviewer.

diehlpk commented 1 year ago

@maxpumperla Could you please recommend some new reviewers?

maxpumperla commented 1 year ago

@diehlpk @arfon I could go through the list of reviewers yet again, but I don't think I have any relation to anyone on it. Isn't the appointment of reviewers something you (as part of the journal) are better equipped to handle?

diehlpk commented 1 year ago

Sure, I will have a look. Sometimes it can help if the authors recommend some reviewers.

maxpumperla commented 1 year ago

thank you for your help!

diehlpk commented 1 year ago

@editorialbot remove @marksantcroos as reviewer

editorialbot commented 1 year ago

@marksantcroos removed from the reviewers list!

diehlpk commented 1 year ago

@nilesh-patil would you have time to review this paper?

diehlpk commented 1 year ago

@sssomani would you mind reviewing this paper?

diehlpk commented 1 year ago

@sepandhaghighi would you mind reviewing this paper?

sepandhaghighi commented 1 year ago

@sepandhaghighi would you mind reviewing this paper?

💯 Why not? I'm available for the reviewing

diehlpk commented 1 year ago

@editorialbot add @sepandhaghighi as reviewer

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

diehlpk commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @diehlpk, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for archive
@editorialbot set 10.21105/zenodo.12345 as archive

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Open the review issue
@editorialbot start review
diehlpk commented 1 year ago

@editorialbot add @sepandhaghighi as reviewer

editorialbot commented 1 year ago

@sepandhaghighi added to the reviewers list!

sepandhaghighi commented 1 year ago

@diehlpk Thanks 💯 Before I start reviewing, please address these questions.

  1. Where is my checklist?
  2. It seems recently this project moved to another repo, is it okay? @maxpumperla

SH

diehlpk commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @diehlpk, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for archive
@editorialbot set 10.21105/zenodo.12345 as archive

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Open the review issue
@editorialbot start review
diehlpk commented 1 year ago

@diehlpk Thanks 💯 Before I start reviewing, please address these questions.

  1. Where is my checklist?
  2. It seems recently this project moved to another repo, is it okay? @maxpumperla

SH

Please run

Adds a checklist for the reviewer using this command

@editorialbot generate my checklist

to generate your list.

sepandhaghighi commented 1 year ago

Review checklist for @sepandhaghighi

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

maxpumperla commented 1 year ago

@sepandhaghighi moving forward this project will be maintained by Daniel Cahill. He decided to create this own fork. The important bit is that a) the info on the repo is still valid b) the project is considered feature-complete with the 3.0 release and c) the software will always be available as elephas package. Thanks for this question, though!

diehlpk commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf. Paper file not found.