[REVIEW]: Elephas: Distributed Deep Learning with Keras & Spark

[whedon]

Submitting author: !--author-handle-->@maxpumperla<!--end-author-handle-- (Max Pumperla) Repository: https://github.com/danielenricocahall/elephas Branch with paper.md (empty if default branch): mp_joss_paper Version: 3.4.7 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @sepandhaghighi, @nmoran Archive: 10.5281/zenodo.7435012

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b"><img src="https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b/status.svg)](https://joss.theoj.org/papers/328ce9586713a195b27a55658885cd5b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@marksantcroos & @burch-cm, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

1. Make sure you're logged in to your GitHub account
2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @taless474 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[diehlpk]

@danielenricocahall It looks good now. Please generate the following:

• [x] A release including all changes made during the review and post the number here.
• [x] Upload the release to Zenodo or FigShare and post the DOI here. Please note that the paper's title and authors have to match with the archive.

[danielenricocahall]

Sure!

Release number: 3.4.7 Zenodo DOI: 10.5281/zenodo.7435012

[diehlpk]

@editorialbot set 3.4.7 as version

[editorialbot]

Done! version is now 3.4.7

[diehlpk]

@editorialbot set 10.5281/zenodo.7435012 as archive

[editorialbot]

Done! Archive is now 10.5281/zenodo.7435012

[diehlpk]

@danielenricocahall the title of the archive is wrong and it should read

Elephas: Distributed Deep Learning with Keras & Spark

You can edit the title and there is no need for a new DOI.

[danielenricocahall]

@diehlpk done!

[diehlpk]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1145/3357223.3362707 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3805, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[arfon]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3812
1. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04073
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[danielenricocahall]

Wooo! This is exciting! Everything looks good except on the DOI it looks like it links to the old repository - is there any way to edit that? I'm not sure where that was set or if we missed something.

[danielenricocahall]

Also, just realized we didn't change the API documentation link to https://danielenricocahall.github.io/elephas/ instead of the old page (http://maxpumperla.com/elephas/). Is there any way we could edit that too?

[arfon]

Wooo! This is exciting! Everything looks good except on the DOI it looks like it links to the old repository - is there any way to edit that? I'm not sure where that was set or if we missed something.

Could you be be more specific here, i.e., what link is wrong and where?

Also, just realized we didn't change the API documentation link to https://danielenricocahall.github.io/elephas/ instead of the old page (http://maxpumperla.com/elephas/). Is there any way we could edit that too?

Yes, just update your paper and we can re-accept

[danielenricocahall]

Sure! Specifically, I mean on https://joss.theoj.org/papers/10.21105/joss.04073, the "Software Repository" button links to https://github.com/maxpumperla/elephas instead of https://github.com/danielenricocahall/elephas, the currently active fork. It's linked correctly in the actual paper (the "Repository" link goes to https://github.com/danielenricocahall/elephas). And sure thing, will edit now.

[arfon]

Ah right. We can fix that.

[arfon]

@editorialbot set https://github.com/danielenricocahall/elephas as repository

[editorialbot]

Done! repository is now https://github.com/danielenricocahall/elephas

[danielenricocahall]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[arfon]

@editorialbot reaccept

[editorialbot]

Rebuilding paper!

[editorialbot]

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/3818

[arfon]

@danielenricocahall – can you take a look and see if things are looking better for the doc now?

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04073/status.svg)](https://doi.org/10.21105/joss.04073)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04073">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04073/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04073/status.svg
   :target: https://doi.org/10.21105/joss.04073

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

[danielenricocahall]

@danielenricocahall – can you take a look and see if things are looking better for the doc now?

@arfon checking now. The link is correct now (thank you!). It looks like the hyperlinks are still out-of-date though. Is it because the new pdf wasn't successfully published before the reaccept?

[danielenricocahall]

Seems to be working now actually - thank you for everything!