openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems #4131

Closed whedon closed 2 years ago

whedon commented 2 years ago

Submitting author: !--author-handle-->@DCoppitters<!--end-author-handle-- (Diederik Coppitters) Repository: https://github.com/rheia-framework/RHEIA Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: !--editor-->@fraukewiese<!--end-editor-- Reviewers: @andr1976, @ClaraBuettner Managing EiC: Kevin M. Moerman

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3fd7e487df85a808f1005a447f731f12"><img src="https://joss.theoj.org/papers/3fd7e487df85a808f1005a447f731f12/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3fd7e487df85a808f1005a447f731f12/status.svg)](https://joss.theoj.org/papers/3fd7e487df85a808f1005a447f731f12)

Author instructions

Thanks for submitting your paper to JOSS @DCoppitters. Currently, there isn't an JOSS editor assigned to your paper.

@DCoppitters if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 2 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 2 years ago

Wordcount for paper.md is 1043

whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.energy.2020.118798 is OK
- 10.1016/j.fuel.2020.117049 is OK
- 10.1115/1.4044491 is OK
- 10.1016/j.energy.2021.120692 is OK
- 10.1016/j.egypro.2019.01.549 is OK
- 10.1016/j.apenergy.2019.04.101 is OK
- 10.1016/j.apenergy.2017.03.132 is OK
- 10.3390/app10196653 is OK
- 10.1007/s11831-017-9240-5 is OK
- 10.2514/6.2017-3827 is OK
- 10.3390/en14134027 is OK
- 10.1016/j.jcp.2016.12.015 is OK
- 10.21105/joss.00884 is OK
- 10.21105/joss.00676 is OK
- 10.1016/j.jocs.2015.08.008 is OK
- 10.21105/joss.00825 is OK

MISSING DOIs

- 10.1061/9780784413609.257 may be a valid DOI for title: UQLab: A framework for uncertainty quantification in Matlab

INVALID DOIs

- 10.5555/2503308.2503311 is INVALID
whedon commented 2 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.20 s (276.0 files/s, 112318.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              6              6              6           7477
Python                          27           1806           3246           3201
TeX                              2            293              0           2622
reStructuredText                15            999           1141           1363
Markdown                         2             29              0            124
DOS Batch                        1              8              1             26
TOML                             1              1              0             17
make                             1              4              6              9
-------------------------------------------------------------------------------
SUM:                            55           3146           4400          14839
-------------------------------------------------------------------------------

Statistical information for the repository 'efbd7e41bb5dea7f7b560a43' was
gathered on 2022/02/04.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Diederik Coppitters             32         10618           2363           99.51
Tsiri                           14            31             33            0.49

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Diederik Coppitters        8253           77.7          1.3               14.89
whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 2 years ago

@whedon invite @fraukewiese as editor

:wave: @fraukewiese do you think you can handle this submission? Thanks!

whedon commented 2 years ago

@fraukewiese has been invited to edit this submission.

fraukewiese commented 2 years ago

Yes, I can edit this submission.

fraukewiese commented 2 years ago

@whedon assign me as editor

whedon commented 2 years ago

OK, the editor is @fraukewiese

fraukewiese commented 2 years ago

@DCoppitters : Do you have suggestions for reviewers of our submission?

DCoppitters commented 2 years ago

Dear @fraukewiese,

Many thanks for editing the submission. I went through the list of potential reviewers and suggest the following reviewers: brynpickering sevberg fneum timtroendle

Best regards,

@DCoppitters

fraukewiese commented 2 years ago

@andr1976, @sevberg, @brynpickering – would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems

andr1976 commented 2 years ago

@fraukewiese, sorry for the late reply, let me see if I can squeeze it into my schedule, give me a few days and I will revert with a answer,

fraukewiese commented 2 years ago

Thanks @andr1976 for the reply. Hope you can make it, just let us know.

fraukewiese commented 2 years ago

@sevberg, @brynpickering – would one of you be willing to review this submission for JOSS?

brynpickering commented 2 years ago

Sorry @fraukewiese, I have no time to dedicate to this submission at the moment.

fraukewiese commented 2 years ago

@andr1976 @sevberg - would one of you be willing to review this submission for JOSS?

andr1976 commented 2 years ago

@fraukewiese , I can review :-)

fraukewiese commented 2 years ago

@andr1976 : Thank you very much! I will add you as reviewer. The review will start as soon as we have found a second reviewer.

fraukewiese commented 2 years ago

@editorialbot add @andr1976 as reviewer

editorialbot commented 2 years ago

@andr1976 added to the reviewers list!

fraukewiese commented 2 years ago

@sevberg @fneum @timtroendle : Would any of you be willing to review this submission?

timtroendle commented 2 years ago

Hello @fraukewiese, unfortunately, I won't have time to review this.

fneum commented 2 years ago

Hello @fraukewiese, unfortunately, I won't have time to review this either.

fraukewiese commented 2 years ago

@wholmgren, @EricaEgg, @kramea – would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems

fraukewiese commented 2 years ago

@DCoppitters : Do you have any additional suggestions for reviewers?

fraukewiese commented 2 years ago

@wholmgren, @EricaEgg, @kramea - to make sure you have seen this request, I send it again: – would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems

wholmgren commented 2 years ago

@fraukewiese sorry I am overextended right now

EricaEgg commented 2 years ago

Apologies, I am also not able to review right now.

On Wed, Apr 20, 2022 at 3:02 AM fraukewiese @.***> wrote:

@wholmgren https://github.com/wholmgren, @EricaEgg https://github.com/EricaEgg, @kramea https://github.com/kramea - to make sure you have seen this request, I send it again: – would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems https://github.com/rheia-framework/RHEIA

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/4131#issuecomment-1103743450, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCPASTBOQ3S7VRQ62KMRPLVF7I25ANCNFSM5NRRROUA . You are receiving this because you were mentioned.Message ID: @.***>

-- Erica Eggleton she/her/hers PhD Candidate Schwartz Research Group https://uwemilab.github.io/ Department of Chemical Engineering https://www.cheme.washington.edu/ University of Washington

fraukewiese commented 2 years ago

@ClaraBuettner , @kramea: – would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems

fraukewiese commented 2 years ago

Sorry @DCoppitters that it is taking that long to find reviewer. I am currently also trying to reach out to potential reviewer via mail. If you have any additional suggestions for reviewer, please let me know.

ClaraBuettner commented 2 years ago

Hi @fraukewiese, sorry for the late reply. I can review this.

kramea commented 2 years ago

Sorry, do not have time right now to review this properly.

fraukewiese commented 2 years ago

Thanks @ClaraBuettner ! I will add you as reviewer. And then start the review.

fraukewiese commented 2 years ago

@editorialbot add @ClaraBuettner as reviewer

editorialbot commented 2 years ago

@ClaraBuettner added to the reviewers list!

fraukewiese commented 2 years ago

@editorialbot start review

editorialbot commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4370.

fraukewiese commented 2 years ago

@andr1976 @ClaraBuettner – thanks a lot for agreeing to review here! See you over in https://github.com/openjournals/joss-reviews/issues/4370 where the actual review will take place.