search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: tukey_hsd: An Accurate Implementation of the Tukey Honestly Significant Difference Test in Python #4159

Closed whedon closed 2 years ago

whedon commented 2 years ago

Submitting author: !--author-handle-->@mdhaber<!--end-author-handle-- (Matt Haberland) Repository: https://github.com/mdhaber/scipy/ Branch with paper.md (empty if default branch): joss_studentized_range Version: 1.8.0 Editor: !--editor-->@mikldk<!--end-editor-- Reviewers: @mcavs, @acolum Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0a44b6cb3110427bc140af380488ed25"><img src="https://joss.theoj.org/papers/0a44b6cb3110427bc140af380488ed25/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0a44b6cb3110427bc140af380488ed25/status.svg)](https://joss.theoj.org/papers/0a44b6cb3110427bc140af380488ed25)

Author instructions

Thanks for submitting your paper to JOSS @mdhaber. Currently, there isn't an JOSS editor assigned to your paper.

@mdhaber if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
acolum commented 2 years ago

@mikldk I'm interested.

mikldk commented 2 years ago

@editorialbot add @acolum as reviewer

editorialbot commented 2 years ago

@acolum added to the reviewers list!

mikldk commented 2 years ago

@editorialbot start review

editorialbot commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4383.

mdhaber commented 2 years ago

@mikldk Since the relevant code is integrated into the (very large) SciPy library, would it be appropriate to copy https://github.com/openjournals/joss-reviews/issues/4159#issuecomment-1039235888 and https://github.com/openjournals/joss-reviews/issues/4159#issuecomment-1039328191 over to the new issue to help with review?

mikldk commented 2 years ago

@mikldk Since the relevant code is integrated into the (very large) SciPy library, would it be appropriate to copy #4159 (comment) and #4159 (comment) over to the new issue to help with review?

Good idea, thanks. I have made this comment in the review. You are welcome to insert your answer there, too, if you like.