openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: SNIK Graph—Visualizing Knowledge about Management of Hospital Information Systems #4163

Closed whedon closed 2 years ago

whedon commented 2 years ago

Submitting author: !--author-handle-->@KonradHoeffner<!--end-author-handle-- (Konrad Höffner) Repository: https://github.com/snikproject/snik-graph Branch with paper.md (empty if default branch): Version: 3.0.0 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/699b504c9abf47a002f379e7331c5833"><img src="https://joss.theoj.org/papers/699b504c9abf47a002f379e7331c5833/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/699b504c9abf47a002f379e7331c5833/status.svg)](https://joss.theoj.org/papers/699b504c9abf47a002f379e7331c5833)

Author instructions

Thanks for submitting your paper to JOSS @KonradHoeffner. Currently, there isn't an JOSS editor assigned to your paper.

@KonradHoeffner if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 2 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 2 years ago

Wordcount for paper.md is 815

whedon commented 2 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.06 s (1110.5 files/s, 109745.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TypeScript                      45            251           1025           4191
HTML                             5             14             20            359
JSON                             5              0              0            256
CSS                              4             28              0            200
Markdown                         3             67              0            196
TeX                              1             13              0            121
JavaScript                       3              5              6             72
YAML                             2             13              0             65
Dockerfile                       1              1              0             11
Bourne Shell                     1              1              0              3
-------------------------------------------------------------------------------
SUM:                            70            393           1051           5474
-------------------------------------------------------------------------------

Statistical information for the repository '1d823d4fe644388943c2c1cb' was
gathered on 2022/02/14.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Konrad Hoeffner                 42          1189          27200           35.67
Konrad Höffner                 648         22136          20753           53.88
T-P-1                            3             7              6            0.02
Thomas Pause                    28           469            422            1.12
ThomasPause                    108          4148           3267            9.32

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Konrad Höffner               17            0.1          0.1                0.00
whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3233/978-1-61499-678-1-349 is OK

MISSING DOIs

- 10.1093/bioinformatics/btv557 may be a valid DOI for title: Cytoscape.js: A graph theory library for visualisation and analysis
- 10.1145/75335.75352 may be a valid DOI for title: A new approach to text searching
- 10.1145/2362499.2362532 may be a valid DOI for title: LodLive, Exploring the Web of Data
- 10.1109/jcsse.2018.8457325 may be a valid DOI for title: VizLOD: Schema Extraction And Visualization Of Linked Open Data

INVALID DOIs

- None
whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 2 years ago

👋 @KonradHoeffner - thanks for your submission. I'm going to ask the JOSS editors to discuss if it is research software as defined by JOSS. You should hear back in a week or so.

In addition, you could work on the possibly missing DOIs that whedon suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @whedon check references to check again, and the command @whedon generate pdf when the references are right to make a new PDF. Whedon commands need to be the first entry in a new comment.

danielskatz commented 2 years ago

@whedon query scope

whedon commented 2 years ago

Submission flagged for editorial review.

KonradHoeffner commented 2 years ago

@danielskatz thanks! I verified and added the missing DOIs and hope it counts as research software, as we are actively using it in research and teaching. If the issue is that it comes preconfigured for only one knowledge base I can also add another one if that helps.

KonradHoeffner commented 2 years ago

@whedon check references

whedon commented 2 years ago

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "journal" (NAME) ["@", #, {:title=>["Cytoscape.js: {A} graph theory library for visualisation and analysis"], :author=>["Franz, Max and Lopes, Christian T and Huck, Gerardo and Dong, Yue and Sumer, Onur and Bader, Gary D"], :doi=>["10.1093/bioinformatics/btv557"]}]

KonradHoeffner commented 2 years ago

@whedon check references

whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/bioinformatics/btv557 is OK
- 10.1145/75335.75352 is OK
- 10.3233/978-1-61499-678-1-349 is OK
- 10.1145/2362499.2362532 is OK
- 10.1109/jcsse.2018.8457325 is OK

MISSING DOIs

- None

INVALID DOIs

- None
KonradHoeffner commented 2 years ago

@whedon generate pdf

whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

KonradHoeffner commented 2 years ago

I'm going to ask the JOSS editors to discuss if it is research software as defined by JOSS. You should hear back in a week or so.

@danielskatz: Is there a decision yet whether it counts as research software?

danielskatz commented 2 years ago

@KonradHoeffner - JOSS AEiCs rotate, so I'll ask the currently on-duty @openjournals/joss-eics to update you

kyleniemeyer commented 2 years ago

Hello @KonradHoeffner, the JOSS editorial board reviewed your submission, and unfortunately have found it out of scope for review by JOSS since it is primarily focused on visualization, which is outside our definition of research software. It also seems a bit focused on teaching, which is similarly outside scope for us. You might consider JOSE, our sibling journal focused on educational software (among other things).

Otherwise, one possible alternative to JOSS is to follow GitHub's guide on how to create a permanent archive and DOI for your software. This DOI can then be used by others to cite your work.

kyleniemeyer commented 2 years ago

@editorialbot reject

editorialbot commented 2 years ago

Paper rejected.

KonradHoeffner commented 2 years ago

Thanks for the advice! I will definitely consider submitting a paper to JOSE.