openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: mlmtools: An R-Based Toolkit for lme4 Multilevel Models #4258

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@lj5yn<!--end-author-handle-- (Laura Jamison) Repository: https://github.com/lj5yn/mlmtools Branch with paper.md (empty if default branch): Version: 0.0.0.9000 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aeed8bc96bc72fd17b841eba5cccfefb"><img src="https://joss.theoj.org/papers/aeed8bc96bc72fd17b841eba5cccfefb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aeed8bc96bc72fd17b841eba5cccfefb/status.svg)](https://joss.theoj.org/papers/aeed8bc96bc72fd17b841eba5cccfefb)

Author instructions

Thanks for submitting your paper to JOSS @lj5yn. Currently, there isn't an JOSS editor assigned to your paper.

@lj5yn if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.05 s (836.2 files/s, 120595.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            14            663            176           1700
R                               11            217            395            844
CSS                              3             99             48            428
JavaScript                       3             64             32            256
TeX                              1             32              1            252
Markdown                         2             41              0            157
YAML                             2              2              4             23
SVG                              1              0              1             11
Rmd                              1             15             19              0
-------------------------------------------------------------------------------
SUM:                            38           1133            676           3671
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 1306

editorialbot commented 2 years ago

Failed to discover a valid open source license

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/0304-4076(86)90002-3 is OK
- 10.1007/978-1-4899-3242-6 is OK
- 10.18637/jss.v023.i07 is OK
- 10.1007/978-0-387-21706-2 is OK
- 10.18637/jss.v032.i10 is OK
- 10.18637/jss.v027.i08 is OK

MISSING DOIs

- 10.1037/e494732006-007 may be a valid DOI for title: Effects of teachers’ mathematical knowledge for teaching on student achievement
- 10.32614/rj-2017-066 may be a valid DOI for title: glmmTMB balances speed and flexibility among packages for zero-inflated generalized linear mixed modeling
- 10.1007/s11336-013-9328-2 may be a valid DOI for title: A nondegenerate penalized likelihood estimator for variance parameters in multilevel models
- 10.1111/j.1541-0420.2006.00588_16.x may be a valid DOI for title: Multilevel and longitudinal modeling using Stata
- 10.1080/00401706.1994.10485413 may be a valid DOI for title: Hierarchical linear models: Applications and data analysis methods
- 10.1080/00273171.2018.1516541 may be a valid DOI for title: Estimating Complex Measurement and Growth Models Using the R Package PLmixed

INVALID DOIs

- None
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 2 years ago

Hi @lj5yn and thanks for your submission! Because of its relatively small size, I am going to ping the greater editorial board to make sure it is in scope for JOSS before proceeding with review. This process will take 1-2 weeks, thanks.

kthyng commented 2 years ago

@editorialbot query scope

editorialbot commented 2 years ago

Submission flagged for editorial review.

danielskatz commented 2 years ago

👋 @lj5yn - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

(Also, one editor suggests "levelCompare is implemented incorrectly and uses the wrong statistical test.")

danielskatz commented 2 years ago

@editorialbot reject

editorialbot commented 2 years ago

Paper rejected.

bbachilles commented 2 years ago

@danielskatz I'd respectfully ask you to reconsider this decision. According to the linked source on substantial scholarly effort, it says that package/software would qualify if it "makes addressing research challenges significantly better (e.g., faster, easier, simpler)." This is exactly the point of the mlmtools package, which brings together a suite of pre-model and post-model processing tools for users of the lme4 package for multilevel models in R. We saw the issue raised about levelCompare and planned to address the issue. Additionally, there were functions that we considered adding to the package but did not for a variety of reasons. Had we added even one of them, this would have pushed the code count above 1,000. We are happy to augment the package further if that would help our case. Thank you very much for considering our request.

danielskatz commented 2 years ago

@bbachilles: That the software "makes addressing research challenges significantly better (e.g., faster, easier, simpler)" is necessary but not sufficient. The other part of this statement is that the software should "be a significant contribution", and this is the main concern of the editors.

You are certainly welcome to expand the software to make the contribution larger and to resubmit. If you do, please include the URL of this issue in your submission.

bbachilles commented 2 years ago

@danielskatz Thank you very much for clarifying and leaving the door open for a resubmission (with further additions to the package).