openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: DIANNA: Deep Insight And Neural Network Analysis #4263

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@elboyran<!--end-author-handle-- (Elena Ranguelova) Repository: https://github.com/dianna-ai/dianna Branch with paper.md (empty if default branch): Version: v.0.4.0 Editor: !--editor-->@taless474<!--end-editor-- Reviewers: @Athene-ai, @sara-02 Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f0592c1aecb3711e068b58970588f185"><img src="https://joss.theoj.org/papers/f0592c1aecb3711e068b58970588f185/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f0592c1aecb3711e068b58970588f185/status.svg)](https://joss.theoj.org/papers/f0592c1aecb3711e068b58970588f185)

Author instructions

Thanks for submitting your paper to JOSS @elboyran. Currently, there isn't an JOSS editor assigned to your paper.

@elboyran if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.23 s (276.5 files/s, 30444.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          21            293            474            858
Jupyter Notebook                12             11           3045            496
TeX                              1             39              0            404
Markdown                         7            129              0            382
YAML                            14             50              9            349
reStructuredText                 3             78             63            121
DOS Batch                        1              8              1             27
JSON                             1              0              0             26
Bourne Shell                     1              8              5             18
TOML                             1              5              0             18
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            63            625           3603           2709
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 1450

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1098/rsta.2019.0054 is OK
- 10.1145/3328485 is OK
- 10.1109/ACCESS.2020.3047960 is OK
- 10.1109/ACCESS.2020.3031477 is OK
- 10.23919/MIPRO.2018.8400040 is OK
- 10.2139/ssrn.3503603 is OK
- 10.5281/zenodo.6303282 is OK
- 10.5281/zenodo.4724125 is OK
- 10.5281/zenodo.5012825 is OK
- 10.5281/zenodo.5061353 is OK
- 10.18653/v1/P17-1057 is OK
- 10.7275/extq-7546 is OK

MISSING DOIs

- 10.18653/v1/n16-3020 may be a valid DOI for title: "Why Should I Trust You?": Explaining the Predictions of Any Classifier
- 10.1007/978-3-642-33709-3_36 may be a valid DOI for title: Leafsnap: A Computer Vision System for Automatic Plant Species Identification
- 10.18653/v1/p19-1647 may be a valid DOI for title: Symbolic inductive bias for visually grounded learning of spoken language
- 10.18653/v1/k17-1037 may be a valid DOI for title: Encoding of phonology in a recurrent neural model of grounded speech
- 10.1613/jair.1.12967 may be a valid DOI for title: Visually grounded models of spoken language: A survey of datasets, architectures and evaluation techniques

INVALID DOIs

- https://doi.org/10.1016/j.jbusres.2020.09.009 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 2 years ago

👋 @elboyran - thanks for your submission. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

danielskatz commented 2 years ago

@editorialbot query scope

editorialbot commented 2 years ago

Submission flagged for editorial review.

elboyran commented 2 years ago

@danielskatz, thank you for your message. I would like to point out that the set of Jupyter notebooks are an integral part of the package, not only the pure Python number of lines, so they should be taken into account in the total lines of code.

Kevin-Mattheus-Moerman commented 2 years ago

@elboyran the board has reviewed this work and have determined it may be in scope for JOSS. I have therefore removed the query-scope label and we will now proceed to find a handling editor.

Kevin-Mattheus-Moerman commented 2 years ago

@editorialbot invite @taless474 as editor

:wave: @taless474 do you think you can help edit this work?

editorialbot commented 2 years ago

Invitation to edit this submission sent!

taless474 commented 2 years ago

@editorialbot commands

editorialbot commented 2 years ago

Hello @taless474, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author or reviewer to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for archive
@editorialbot set 10.21105/zenodo.12345 as archive

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Open the review issue
@editorialbot start review
taless474 commented 2 years ago

@editorialbot assign me as editor

editorialbot commented 2 years ago

Assigned! @taless474 is now the editor

Athene-ai commented 2 years ago

I would like to review this submission

taless474 commented 2 years ago

@editorialbot add @Athene-ai as reviewer

editorialbot commented 2 years ago

@Athene-ai added to the reviewers list!

taless474 commented 2 years ago

Thank you @Athene-ai Hi @elboyran, thank you for your submission. Will you please introduce to us a list of potential reviewers? We need another reviewer on this work

elboyran commented 2 years ago

Dear @taless474 , sorry for the very late reply. I had some family health circumstances because of which I had to take a relatively long lave. As far as I remember when submitting I have suggested reviewer from the long list available. Did that information appear correctly? Do you need yet another suggestion from me (mine was based only on the very profiles of reviewers I have looked into)?

taless474 commented 2 years ago

@elboyran May I ask you to mention a few of them (most related ones) with their Github ids here?

taless474 commented 2 years ago

@ionlights Are you interested in reviewing this?

sara-02 commented 2 years ago

@taless474 @elboyran I am interested in reviewing this, not my exact area of expertise but I am interested in this project and using it for my own research.

taless474 commented 2 years ago

@sara-02 great!

taless474 commented 2 years ago

@editorialbot add @sara-02 as reviewer

editorialbot commented 2 years ago

@sara-02 added to the reviewers list!

taless474 commented 2 years ago

@editorialbot start review

editorialbot commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4493.