openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: TrackerControl: Transparency and Choice around App Tracking #4270

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@kasnder<!--end-author-handle-- (Konrad Kollnig) Repository: https://github.com/TrackerControl/tracker-control-android Branch with paper.md (empty if default branch): master Version: 2022061501 Editor: !--editor-->@sbenthall<!--end-editor-- Reviewers: @gradvohl, @gcdeshpande Archive: 10.5281/zenodo.6645297

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/dbc6b091eb510b47b80b59ada8afd9d1"><img src="https://joss.theoj.org/papers/dbc6b091eb510b47b80b59ada8afd9d1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/dbc6b091eb510b47b80b59ada8afd9d1/status.svg)](https://joss.theoj.org/papers/dbc6b091eb510b47b80b59ada8afd9d1)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@gradvohl & @gcdeshpande, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sbenthall know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @gcdeshpande

πŸ“ Checklist for @gradvohl

editorialbot commented 2 years ago

Done! Archive is now 10.5281/zenodo.6645297

sbenthall commented 2 years ago

@editorialbot set 2022061501 as version

editorialbot commented 2 years ago

Done! version is now 2022061501

sbenthall commented 2 years ago

Apologies @kasnder I've been traveling. Thanks for the nudge. I recommend this submission for acceptance.

sbenthall commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1145/2462456.2464460 is OK
- 10.1145/2787394.2787396 is OK
- 10.1145/2808117.2808120 is OK
- 10.1515/popets-2018-0035 is OK
- 10.1515/popets-2018-0021 is OK
- 10.1145/3173574.3173967 is OK
- 10.1145/3025453.3025556 is OK
- 10.1145/2906388.2906392 is OK
- 10.1515/popets-2018-0035 is OK
- 10.2478/popets-2020-0017 is OK
- 10.1145/3176246 is OK
- 10.1145/3278532.3278558 is OK
- 10.1145/2591971.2592003 is OK
- 10.1145/3201064.3201089 is OK
- 10.14722/ndss.2018.23009 is OK
- 10.2478/popets-2022-0033 is OK
- 10.14763/2021.4.1611 is OK
- 10.1007/978-3-030-78120-0_15 is OK

MISSING DOIs

- 10.1145/3531146.3533116 may be a valid DOI for title: Goodbye Tracking? Impact of iOS App Tracking Transparency and Privacy Labels

INVALID DOIs

- None
editorialbot commented 2 years ago

:warning: Error prepararing paper acceptance. The generated XML metadata file is invalid.

ID ref-nomoads_2018 already defined
danielskatz commented 2 years ago

πŸ‘‹ @kasnder - There's a duplicate bib entry for nomoads_2018 (lines 64 and 128 of paper.bib) - please remove one of the two.

danielskatz commented 2 years ago

Also, the missing DOI that edtorialbot suggests appears to be correct, so please add it to the bib file

kasnder commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1145/2462456.2464460 is OK
- 10.1145/2787394.2787396 is OK
- 10.1145/2808117.2808120 is OK
- 10.1515/popets-2018-0035 is OK
- 10.1515/popets-2018-0021 is OK
- 10.1145/3173574.3173967 is OK
- 10.1145/3025453.3025556 is OK
- 10.1145/2906388.2906392 is OK
- 10.2478/popets-2020-0017 is OK
- 10.1145/3176246 is OK
- 10.1145/3278532.3278558 is OK
- 10.1145/2591971.2592003 is OK
- 10.1145/3201064.3201089 is OK
- 10.14722/ndss.2018.23009 is OK
- 10.1145/3531146.3533116 is OK
- 10.2478/popets-2022-0033 is OK
- 10.14763/2021.4.1611 is OK
- 10.1007/978-3-030-78120-0_15 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3370, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 2 years ago

@kasnder - I'm the AEiC this week, and I'll now proofread your paper, and then let you know if any changes are needed before publishing

kasnder commented 2 years ago

@kasnder - I'm the AEiC this week, and I'll now proofread your paper, and then let you know if any changes are needed before publishing

Great, @danielskatz. Thanks for taking your time and being so swift!

danielskatz commented 2 years ago

I've suggested a bunch of small changes in https://github.com/TrackerControl/tracker-control-android/pull/323 - please merge this or let me know what you disagree with, then we can proceed

kasnder commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kasnder commented 2 years ago

@editorialbot generate pdf

kasnder commented 2 years ago

@danielskatz, looks good to me now. And thanks for your feedback!

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 2 years ago

@editorialbot accept

editorialbot commented 2 years ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 years ago

🐦🐦🐦 πŸ‘‰ Tweet for this paper πŸ‘ˆ 🐦🐦🐦

editorialbot commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3371
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04270
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

danielskatz commented 2 years ago

Congratulations to @kasnder (Konrad Kollnig) and co-author!!

And thanks to @gradvohl and @gcdeshpande for reviewing, and to @sbenthall for editing! We couldn't do this without you

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04270/status.svg)](https://doi.org/10.21105/joss.04270)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04270">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04270/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04270/status.svg
   :target: https://doi.org/10.21105/joss.04270

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

kasnder commented 2 years ago

Thanks a lot for your support. It's substantially improved our project! @gradvohl @gcdeshpande @sbenthall @danielskatz