search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
708 stars 37 forks source link

[REVIEW]: DIRECT: Deep Image REConstruction Toolkit #4278

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@georgeyiasemis<!--end-author-handle-- (George Yiasemis) Repository: https://github.com/NKI-AI/direct Branch with paper.md (empty if default branch): joss-submission Version: v1.0.1 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @estenhl, @sairamgeethanath Archive: 10.5281/zenodo.6594702

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/150119fd46692dad9448a26eca669a77"><img src="https://joss.theoj.org/papers/150119fd46692dad9448a26eca669a77/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/150119fd46692dad9448a26eca669a77/status.svg)](https://joss.theoj.org/papers/150119fd46692dad9448a26eca669a77)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@estenhl & @sairamgeethanath, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @estenhl

šŸ“ Checklist for @sairamgeethanath

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1117/12.2609876 is OK
- 10.1109/tmi.2021.3075856 is OK
- 10.48550/ARXIV.2011.07952 is OK
- 10.48550/ARXIV.1910.08952 is OK
- 10.1007/978-3-030-59713-9_7 is OK
- 10.1016/j.media.2019.01.005 is OK
- 10.1109/tmi.2018.2799231 is OK
- 10.1002/mrm.27201 is OK
- 10.1109/cvpr46437.2021.00523 is OK
- 10.48550/ARXIV.1811.08839 is OK
- 10.48550/ARXIV.2111.09639 is OK
- 10.1088/0031-9155/52/7/r01 is OK
- 10.1109/TIT.2006.871582 is OK
- 10.1002/mrm.21391 is OK
- 10.1109/TIT.2005.862083 is OK
- 10.1002/mrm.10171 is OK
- 10.1002/(sici)1522-2594(199911)42:5<952::aid-mrm16>3.0.co;2-s is OK
- 10.1109/msp.2019.2950640 is OK
- 10.48550/ARXIV.2109.08618 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/3244

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3244, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 2 years ago

šŸ‘‹ @georgeyiasemis - I'm the AEiC on duty this week, and I have a few small changes for the paper before we publish it. Please merge https://github.com/NKI-AI/direct/pull/206 or let me know what you disagree with.

georgeyiasemis commented 2 years ago

šŸ‘‹ @georgeyiasemis - I'm the AEiC on duty this week, and I have a few small changes for the paper before we publish it. Please merge NKI-AI/direct#206 or let me know what you disagree with.

Hi @danielskatz. Thanks for that. Merged it !

danielskatz commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1117/12.2609876 is OK
- 10.1109/tmi.2021.3075856 is OK
- 10.48550/ARXIV.2011.07952 is OK
- 10.48550/ARXIV.1910.08952 is OK
- 10.1007/978-3-030-59713-9_7 is OK
- 10.1016/j.media.2019.01.005 is OK
- 10.1109/tmi.2018.2799231 is OK
- 10.1002/mrm.27201 is OK
- 10.1109/cvpr46437.2021.00523 is OK
- 10.48550/ARXIV.1811.08839 is OK
- 10.48550/ARXIV.2111.09639 is OK
- 10.1088/0031-9155/52/7/r01 is OK
- 10.1109/TIT.2006.871582 is OK
- 10.1002/mrm.21391 is OK
- 10.1109/TIT.2005.862083 is OK
- 10.1002/mrm.10171 is OK
- 10.1002/(sici)1522-2594(199911)42:5<952::aid-mrm16>3.0.co;2-s is OK
- 10.1109/msp.2019.2950640 is OK
- 10.48550/ARXIV.2109.08618 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/3247

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3247, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 2 years ago

@editorialbot accept

editorialbot commented 2 years ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 years ago

šŸ¦šŸ¦šŸ¦ šŸ‘‰ Tweet for this paper šŸ‘ˆ šŸ¦šŸ¦šŸ¦

editorialbot commented 2 years ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3248
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04278
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

danielskatz commented 2 years ago

Congratulations to @georgeyiasemis (George Yiasemis) and co-authors!!

And thanks to @estenhl and @sairamgeethanath for reviewing, and @osorensen for editing! We couldn't do this without you

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04278/status.svg)](https://doi.org/10.21105/joss.04278)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04278">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04278/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04278/status.svg
   :target: https://doi.org/10.21105/joss.04278

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: