search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
718 stars 38 forks source link

[REVIEW]: adaptr: an R package for simulating and comparing adaptive clinical trials #4284

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@agranholm<!--end-author-handle-- (Anders Granholm) Repository: https://github.com/INCEPTdk/adaptr Branch with paper.md (empty if default branch): joss-paper Version: v1.0.0 Editor: !--editor-->@fabian-s<!--end-editor-- Reviewers: @elimillera, @stmcg Archive: 10.5281/zenodo.6490087

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e070045b6998360d93eed06c95ba44a7"><img src="https://joss.theoj.org/papers/e070045b6998360d93eed06c95ba44a7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e070045b6998360d93eed06c95ba44a7/status.svg)](https://joss.theoj.org/papers/e070045b6998360d93eed06c95ba44a7)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@elimillera & @stmcg, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fabian-s know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @stmcg

📝 Checklist for @elimillera

editorialbot commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3179
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04284
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 2 years ago

@openjournals/dev @arfon - note that the title in JOSS metadata includes some quote marks that seem to also be in the suggested citation, while the PDF does not have the quote marks. Any thoughts on how this should be handled?

danielskatz commented 2 years ago

In any case, congratulations to @agranholm (Anders Granholm) and co-authors!!

And thanks to @elimillera and @stmcg for reviewing, and @fabian-s for editing. We couldn't do this without you.

I am, however, going to leave this open for now until we resolve the quotes in the title issue

agranholm commented 2 years ago

Amazing, thanks!

@danielskatz We stylized the package name as code using backticks throughout the paper, this seems to be what causes the problem in the title in the metadata (and the font in the title appears unchanged despite the formatting) - maybe the easiest solution is just if we remove the backticks around the package name in the title and keep them in the body of the text (where the formatting works)?

danielskatz commented 2 years ago

@agranholm - yes, why don't you make that change, then @arfon will be able to regenerate and redeposit the paper (or maybe I will be able to do this)

agranholm commented 2 years ago

@danielskatz Done! Let me know if anything else is needed from our side.

danielskatz commented 2 years ago

@editorialbot re-accept

editorialbot commented 2 years ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

arfon commented 2 years ago

@editorialbot reaccept

editorialbot commented 2 years ago 
Rebuilding paper!
editorialbot commented 2 years ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/3180

danielskatz commented 2 years ago

Thanks @arfon! 👋 @agranholm - everything looks good now

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04284/status.svg)](https://doi.org/10.21105/joss.04284)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04284">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04284/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04284/status.svg
   :target: https://doi.org/10.21105/joss.04284

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: