search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
704 stars 37 forks source link

[REVIEW]: Swalbe.jl: A lattice Boltzmann solver for thin film hydrodynamics #4312

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@Zitzeronion<!--end-author-handle-- (Stefan Zitz) Repository: https://jugit.fz-juelich.de/compflu/swalbe.jl/ Branch with paper.md (empty if default branch): master Version: 0.1.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: @mbernaschi, @lnacquaroli Archive: 10.5281/zenodo.7030890

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/414a5b53a41e05a250a352360a7da337"><img src="https://joss.theoj.org/papers/414a5b53a41e05a250a352360a7da337/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/414a5b53a41e05a250a352360a7da337/status.svg)](https://joss.theoj.org/papers/414a5b53a41e05a250a352360a7da337)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mbernaschi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @mbernaschi

📝 Checklist for @lnacquaroli

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago

Downloading of the repository failed. Please make sure the URL is correct.

editorialbot commented 2 years ago

:warning: Error prepararing paper acceptance.

arfon commented 2 years ago

Hrm. Looks like the GitLab instance is down (https://jugit.fz-juelich.de/compflu/swalbe.jl/):

Screenshot 2022-09-04 at 08 22 31
Zitzeronion commented 2 years ago

Interesting the link works for me right now. 🤔

arfon commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/nmat788 is OK
- 10.1103/RevModPhys.81.739 is OK
- 10.1357/002224099764805174 is OK
- 10.1017/jfm.2019.595 is OK
- 10.1137/141000671 is OK
- 10.5281/zenodo.4907285 is OK
- 10.1103/RevModPhys.69.931 is OK
- 10.1109/TPDS.2018.2872064 is OK
- 10.1016/j.advengsoft.2019.02.002 is OK
- 10.1103/PhysRevE.100.033313 is OK
- 10.1103/PhysRevE.104.034801 is OK
- 10.1103/PhysRevFluids.1.073901 is OK
- 10.1103/PhysRevLett.119.204501 is OK
- 10.1103/PhysRevE.63.011208 is OK
- 10.1007/s002110000197 is OK
- 10.1073/pnas.1820487116 is OK
- 10.1063/1.4863318 is OK
- 10.1021/la301353f is OK
- 10.1017/jfm.2015.590 is OK
- 10.1017/S002211209900662X is OK
- 10.1103/PhysRevLett.111.144502 is OK
- 10.1017/jfm.2015.590 is OK
- 10.1017/jfm.2013.375 is OK
- 10.1103/PhysRevLett.109.184502 is OK
- 10.1103/PhysRevLett.95.164503 is OK
- 10.1103/PhysRevLett.124.194502 is OK
- 10.1063/1.5119014 is OK
- 10.1063/1.4824108 is OK

MISSING DOIs

- 10.1038/144993a0 may be a valid DOI for title: The mathematical theory of non-uniform gases

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3492, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 2 years ago

@Zitzeronion – I found a few typos and formatting issues with your paper. Can you use this gist for your paper.md: https://gist.github.com/arfon/27653e1abe815a9863c38db30026ec67

Zitzeronion commented 2 years ago

Thanks a lot @arfon for the gist and your editorial work. I've copied the gist, and I'm sorry for using the wrong markdown style, see commit 1382c.

The missing DOI for Sidney Chapmans: "The mathematical theory of non-uniform gases" is not 10.1038/144993a0. I couldn't find a DOI for that work, only an ISBN 9780521408448 of the third edition.

arfon commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3494, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 2 years ago

@editorialbot accept

editorialbot commented 2 years ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3495
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04312
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 2 years ago

@mbernaschi, @lnacquaroli – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@Zitzeronion – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04312/status.svg)](https://doi.org/10.21105/joss.04312)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04312">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04312/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04312/status.svg
   :target: https://doi.org/10.21105/joss.04312

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: