search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
709 stars 38 forks source link

[REVIEW]: islatu: A Python package for the reduction of reflectometry data #4397

Closed editorialbot closed 1 year ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@RBrearton<!--end-author-handle-- (Richard Brearton) Repository: https://github.com/RBrearton/islatu Branch with paper.md (empty if default branch): islatu_paper Version: 1.0.7 Editor: !--editor-->@jgostick<!--end-editor-- Reviewers: @andyfaff, @daguiam Archive: 10.5281/zenodo.7105217

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/faf72abfe010ef11ae4b56bdd7c92f0f"><img src="https://joss.theoj.org/papers/faf72abfe010ef11ae4b56bdd7c92f0f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/faf72abfe010ef11ae4b56bdd7c92f0f/status.svg)](https://joss.theoj.org/papers/faf72abfe010ef11ae4b56bdd7c92f0f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@andyfaff, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jgostick know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @andyfaff

šŸ“ Checklist for @daguiam

jgostick commented 2 years ago

Thanks @danielskatz, I guess we just have to deal with the doi thing and i'll be ready for 'dry run' acceptance time!

RBrearton commented 2 years ago

Hi there, I've just updated the DOI's (the Rigaku paper doesn't have a DOI). I've also added Tim as an author on the Zenodo repository (@danielskatz is right about authorship; the place for tracking commits to source code is github, not Zenodo).

jgostick commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41586-020-2649-2 is OK
- 10.1107/S1600576714027575 is OK
- 10.1107/S1600577516009875 is OK
- 10.5281/zenodo.7105217 is OK
- 10.1016/j.nima.2014.07.029 is OK
- 10.1107/S0021889807045086 is OK
- 10.1107/S1600576718017296 is OK
- 10.1107/S0021889806005073 is OK
- 10.1107/S1600576718011974 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3553, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

šŸ¦šŸ¦šŸ¦ šŸ‘‰ Tweet for this paper šŸ‘ˆ šŸ¦šŸ¦šŸ¦

editorialbot commented 1 year ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3563
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04397
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

arfon commented 1 year ago

@andyfaff, @daguiam ā€“ many thanks for your reviews here and to @jgostick for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you āœØ

@RBrearton ā€“ your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04397/status.svg)](https://doi.org/10.21105/joss.04397)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04397">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04397/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04397/status.svg
   :target: https://doi.org/10.21105/joss.04397

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: