search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: GHEtool: An open-source tool for borefield sizing in Python #4406

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@wouterpeere<!--end-author-handle-- (Wouter Peere) Repository: https://github.com/wouterpeere/GHEtool Branch with paper.md (empty if default branch): main Version: v2.0.4 Editor: !--editor-->@crvernon<!--end-editor-- Reviewers: @jasondegraw, @nmstreethran Archive: 10.5281/zenodo.7004037

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127"><img src="https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127/status.svg)](https://joss.theoj.org/papers/0ae2224874ee0139d6f28baa48fe9127)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@jasondegraw & @nmstreethran, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @nmstreethran

📝 Checklist for @jasondegraw

wouterpeere commented 2 years ago

The version of GHEtool is v2.0.3 and not anymore the v2.0.0 listed in this thread ...

crvernon commented 2 years ago

@wouterpeere does this correspond to a new release that contains your updated paper revisions from today? It looks like your latest version was v2.0.3 from 5 days ago.

wouterpeere commented 2 years ago

@crvernon Right, I forgot about the paper changes. The version is now v2.0.4, the DOI is also updated to this new version: 10.5281/zenodo.7004037

crvernon commented 2 years ago

@editorialbot set v2.0.4 as version

editorialbot commented 2 years ago

Done! version is now v2.0.4

crvernon commented 2 years ago

@editorialbot set 10.5281/zenodo.7004037 as archive

editorialbot commented 2 years ago

Done! Archive is now 10.5281/zenodo.7004037

crvernon commented 2 years ago

@wouterpeere - thanks for putting together a really nice software product! Thanks to @nmstreethran and @jasondegraw for a constructive and timely review!

I am recommending that your submission be accepted. An EIC will review this shortly and confirm final publication if all goes well.

crvernon commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.rser.2019.04.045 is OK
- 10.26868/25222708.2021.30180 is OK
- 10.1016/j.enconman.2014.11.009 is OK
- 10.1016/j.energy.2017.01.097 is OK
- 10.3390/en13236203 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3439, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

wouterpeere commented 2 years ago

@crvernon Thank you for your guidance through this review process!!

kyleniemeyer commented 2 years ago

Hi @wouterpeere, I made a few minor edits to the paper: https://github.com/wouterpeere/GHEtool/pull/16

Can you merge these? I will then accept your submission.

wouterpeere commented 2 years ago

Hi @wouterpeere, I made a few minor edits to the paper: wouterpeere/GHEtool#16

Can you merge these? I will then accept your submission.

Hi @kyleniemeyer , I merged you're changes. Do I need to update the archive and version also?

kyleniemeyer commented 2 years ago

@wouterpeere thanks, and no, that's not necessary since the software did not change. I'll move forward with accepting now

kyleniemeyer commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 2 years ago

@editorialbot accept

editorialbot commented 2 years ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3441
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04406
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 2 years ago

Congratulations @wouterpeere on your article's publication in JOSS!

Many thanks to @jasondegraw and @nmstreethran for reviewing this, and @crvernon for editing.

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04406/status.svg)](https://doi.org/10.21105/joss.04406)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04406">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04406/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04406/status.svg
   :target: https://doi.org/10.21105/joss.04406

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: