openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: MSG: A software package for interpolating stellar spectra in pre-calculated grids #4446

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@rhdtownsend<!--end-author-handle-- (Richard Townsend) Repository: https://github.com/rhdtownsend/msg-joss.git Branch with paper.md (empty if default branch): Version: v1.0-rc1 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/05878cc0f603208c8dedc6e9c57f9677"><img src="https://joss.theoj.org/papers/05878cc0f603208c8dedc6e9c57f9677/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/05878cc0f603208c8dedc6e9c57f9677/status.svg)](https://joss.theoj.org/papers/05878cc0f603208c8dedc6e9c57f9677)

Author instructions

Thanks for submitting your paper to JOSS @rhdtownsend. Currently, there isn't an JOSS editor assigned to your paper.

@rhdtownsend if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.01 s (283.6 files/s, 27368.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1             10              0             90
Markdown                         1             12              0             81
-------------------------------------------------------------------------------
SUM:                             2             22              0            171
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 529

editorialbot commented 2 years ago

Failed to discover a valid open source license

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1051/0004-6361/201732484 may be a valid DOI for title: A collection of model stellar spectra for spectral types B to early-M
- 10.1051/0004-6361/201423945 may be a valid DOI for title: Determining stellar atmospheric parameters and chemical abundances of FGK stars with iSpec
- 10.1051/0004-6361/201219330 may be a valid DOI for title: The AMBRE project: A new synthetic grid of high-resolution FGKM stellar spectra
- 10.1051/0004-6361/201219058 may be a valid DOI for title: A new extensive library of PHOENIX stellar atmospheres and synthetic spectra
- 10.1086/660019 may be a valid DOI for title: Grids of ATLAS9 Model Atmospheres and MOOG Synthetic Spectra
- 10.1086/511270 may be a valid DOI for title: A Grid of NLTE Line-blanketed Model Atmospheres of Early B-Type Stars
- 10.1093/mnras/stt130 may be a valid DOI for title: On the interpolation of model atmospheres and high-resolution synthetic stellar spectra
- 10.1051/0004-6361/202038066 may be a valid DOI for title: Creating and using large grids of precalculated model atmospheres for a rapid analysis of stellar spectra

INVALID DOIs

- None
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 2 years ago

@rhdtownsend - we require the submitted repository to include both software and a paper. This appears to just be a paper, but no software. I'm going to mark it as withdrawn, and request that you add the paper.md and paper.bib files to the repo that contains the software, then you should submit that. Also, note that the repo is probably https://github.com/rhdtownsend/msg (note https://github.com/rhdtownsend/msg.git)

danielskatz commented 2 years ago

@editorialbot withdraw

editorialbot commented 2 years ago

Paper withdrawn.