openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: MSG: A software package for interpolating stellar spectra in pre-calculated grids #4462

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@rhdtownsend<!--end-author-handle-- (Richard Townsend) Repository: https://github.com/rhdtownsend/msg Branch with paper.md (empty if default branch): joss Version: v1.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: !--reviewers-list-->@AWehrhahn<!--end-reviewers-list-- Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fdb605600d48545f98dfb9f825dc833d"><img src="https://joss.theoj.org/papers/fdb605600d48545f98dfb9f825dc833d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fdb605600d48545f98dfb9f825dc833d/status.svg)](https://joss.theoj.org/papers/fdb605600d48545f98dfb9f825dc833d)

Author instructions

Thanks for submitting your paper to JOSS @rhdtownsend. Currently, there isn't an JOSS editor assigned to your paper.

@rhdtownsend if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.16 s (397.9 files/s, 242942.5 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
C                                        2           2105           9887          17931
Python                                  10            706           1056           2238
reStructuredText                        30            808           1040            703
Cython                                   1            196             27            256
Markdown                                 2             24              0            162
make                                     3             57             35            128
TeX                                      1             10              0             90
Jupyter Notebook                         1              0            475             67
Fortran 90                               1             34             14             61
Bourne Again Shell                       1             27             10             55
C/C++ Header                             1             17             20             54
Bourne Shell                             5             15              6             31
JSON                                     1              0              0             30
YAML                                     2              7             15             25
Windows Module Definition                1              0              0             17
CSS                                      1              6              5             16
---------------------------------------------------------------------------------------
SUM:                                    63           4012          12590          21864
---------------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 529

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1051/0004-6361/201732484 may be a valid DOI for title: A collection of model stellar spectra for spectral types B to early-M
- 10.1051/0004-6361/201423945 may be a valid DOI for title: Determining stellar atmospheric parameters and chemical abundances of FGK stars with iSpec
- 10.1051/0004-6361/201219330 may be a valid DOI for title: The AMBRE project: A new synthetic grid of high-resolution FGKM stellar spectra
- 10.1051/0004-6361/201219058 may be a valid DOI for title: A new extensive library of PHOENIX stellar atmospheres and synthetic spectra
- 10.1086/660019 may be a valid DOI for title: Grids of ATLAS9 Model Atmospheres and MOOG Synthetic Spectra
- 10.1086/511270 may be a valid DOI for title: A Grid of NLTE Line-blanketed Model Atmospheres of Early B-Type Stars
- 10.1093/mnras/stt130 may be a valid DOI for title: On the interpolation of model atmospheres and high-resolution synthetic stellar spectra
- 10.1051/0004-6361/202038066 may be a valid DOI for title: Creating and using large grids of precalculated model atmospheres for a rapid analysis of stellar spectra

INVALID DOIs

- None
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 2 years ago

Hi @rhdtownsend, we will use this pre-review issue to find an editor and reviewers for your submission. Any recommendations you might have for the latter would be welcome.

As we are getting started, can you take a look at those missing DOIs from your references?

kyleniemeyer commented 2 years ago

Hi @christinahedges, are you available to edit this submission? Thanks!

kyleniemeyer commented 2 years ago

@editorialbot invite @christinahedges as editor

editorialbot commented 2 years ago

Invitation to edit this submission sent!

rhdtownsend commented 2 years ago

Fixed the DOIs — thanks! This is a new process for me, so getting used to what’s expected.

On Jun 9, 2022, at 5:45 PM, Kyle Niemeyer @.**@.>> wrote:

Hi @rhdtownsendhttps://github.com/rhdtownsend, we will use this pre-review issue to find an editor and reviewers for your submission. Any recommendations you might have for the latter would be welcome.

As we are getting started, can you take a look at those missing DOIs from your references?

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/4462#issuecomment-1151689209, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADIYU4FDKVJPLVKIHLLAMQLVOJXYVANCNFSM5YLTLRZQ. You are receiving this because you were mentioned.Message ID: @.***>

Kevin-Mattheus-Moerman commented 2 years ago

@editorialbot invite @christinahedges as editor

editorialbot commented 2 years ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 2 years ago

@christinahedges are you able to help with this one?

Kevin-Mattheus-Moerman commented 2 years ago

@editorialbot invite @xuanxu as editor

editorialbot commented 2 years ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 2 years ago

@xuanxu can you edit this one?

arfon commented 2 years ago

@editorialbot assign me as editor

editorialbot commented 2 years ago

Assigned! @arfon is now the editor

arfon commented 2 years ago

@rhdtownsend – thanks for your submission to JOSS. Could you suggest a few names (ideally folks you know are on GitHub( that might be able to provide a good review here?

rhdtownsend commented 2 years ago

Sure —

Carlos Allende Prieto — https://github.com/callendeprieto Dan Forman-Mackey — https://github.com/dfm (also a JOSS editor, I believe) Hugo Tabernero — https://github.com/hmtabernero Ansgar Wehrhahn — https://github.com/AWehrhahn

cheers,

Rich

On Jun 26, 2022, at 2:31 PM, Arfon Smith @.**@.>> wrote:

@rhdtownsendhttps://github.com/rhdtownsend – thanks for your submission to JOSS. Could you suggest a few names (ideally folks you know are on GitHub( that might be able to provide a good review here?

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/4462#issuecomment-1166624147, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADIYU4CU2HMINHAGSE3WLULVRCVX5ANCNFSM5YLTLRZQ. You are receiving this because you were mentioned.Message ID: @.***>

arfon commented 2 years ago

@callendeprieto @hmtabernero @AWehrhahn – would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The software under consideration is

MSG: A software package for interpolating stellar spectra in pre-calculated grids

AWehrhahn commented 2 years ago

Sure. When do you need the review?

arfon commented 2 years ago

@AWehrhahn – ideally in the next 2-4 weeks?

AWehrhahn commented 2 years ago

Ok, where do I submit the review?

arfon commented 2 years ago

@editorialbot add @AWehrhahn as reviewer

editorialbot commented 2 years ago

@AWehrhahn added to the reviewers list!

arfon commented 2 years ago

@editorialbot start review

editorialbot commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4602.

arfon commented 2 years ago

Ok, where do I submit the review?

@AWehrhahn – please follow the instructions over in #4602 for how to submit the review. Many thanks!