openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: PyDDSBB: A Python Package for Simulation-Optimization using Data-Driven Branch-and-Bound Techniques #4514

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@Suryateja-Ravutla<!--end-author-handle-- (Suryateja Ravutla) Repository: https://github.com/DDPSE/PyDDSBB Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/09422c9b91f06c4db528afa8083f0825"><img src="https://joss.theoj.org/papers/09422c9b91f06c4db528afa8083f0825/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/09422c9b91f06c4db528afa8083f0825/status.svg)](https://joss.theoj.org/papers/09422c9b91f06c4db528afa8083f0825)

Author instructions

Thanks for submitting your paper to JOSS @Suryateja-Ravutla. Currently, there isn't an JOSS editor assigned to your paper.

@Suryateja-Ravutla if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (606.5 files/s, 91512.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          11             91            417           1289
Markdown                         5             31              0            189
Jupyter Notebook                 1              0            577            124
TeX                              1             10              0            116
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            19            133            998           1736
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 1019

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.compchemeng.2017.09.017 may be a valid DOI for title: Advances in surrogate based modeling, feasibility analysis, and optimization: A review
- 10.1007/s10898-021-01045-8 may be a valid DOI for title: Data-driven spatial branch-and-bound algorithms for box-constrained simulation-based optimization
- 10.1007/s10898-012-9951-y may be a valid DOI for title: Derivative-free optimization: a review of algorithms and comparison of software implementations
- 10.1016/j.ejor.2015.12.018 may be a valid DOI for title: Global optimization advances in mixed-integer nonlinear programming, MINLP, and constrained derivative-free optimization, CDFO
- 10.1002/cite.201800091 may be a valid DOI for title: Overview of surrogate modeling in chemical process engineering
- 10.1007/s12532-011-0026-8 may be a valid DOI for title: Pyomo: modeling and solving mathematical programs in Python

INVALID DOIs

- None
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 2 years ago

@editorialbot query scope

@Suryateja-Ravutla – thanks for your submission to JOSS. As this is on the smaller side of what we typically publish in JOSS I'm going to flag this for a scope review by the wider editorial team. This will likely take a week or so.

editorialbot commented 2 years ago

Submission flagged for editorial review.

danielskatz commented 2 years ago

👋 @Suryateja-Ravutla - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission is not currently ready for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

The issues are the amount of substantial scholarly effort (which is borderline), and the lack of 1. packaging, 2. documentation, and 3. tests. The editors do think this is useful software, and would be pleased to see a resubmitted package that addresses the three issues above.

danielskatz commented 2 years ago

@editorialbot reject

editorialbot commented 2 years ago

Paper rejected.