openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: FastGeodis: Fast Generalised Geodesic Distance Transform #4523

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@masadcv<!--end-author-handle-- (Muhammad Asad) Repository: https://github.com/masadcv/FastGeodis Branch with paper.md (empty if default branch): Version: v1.0.0rc4 Editor: !--editor-->@vissarion<!--end-editor-- Reviewers: @yhtang, @jacobmerson, @bencardoen Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d0b6e3daa4b22fec471691c6f1c60e2a"><img src="https://joss.theoj.org/papers/d0b6e3daa4b22fec471691c6f1c60e2a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d0b6e3daa4b22fec471691c6f1c60e2a/status.svg)](https://joss.theoj.org/papers/d0b6e3daa4b22fec471691c6f1c60e2a)

Author instructions

Thanks for submitting your paper to JOSS @masadcv. Currently, there isn't an JOSS editor assigned to your paper.

@masadcv if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.11 s (481.3 files/s, 219327.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      13           2424           2495           9164
SVG                              1              0              0           2671
Python                          10            313            284           1002
CSS                              4            190             38            779
Jupyter Notebook                 5              0           1029            589
C++                              2             91            112            416
CUDA                             1             65             58            381
HTML                             1             20              4            218
YAML                             3             27              5            177
Markdown                         4             79              0            172
TeX                              1             11              0            137
C/C++ Header                     2             32             50            130
DOS Batch                        1              8              1             26
make                             1              4              7             11
TOML                             1              0              0              7
reStructuredText                 1              2              8              2
-------------------------------------------------------------------------------
SUM:                            51           3266           4091          15882
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 639

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1007/978-3-540-88682-2_9 may be a valid DOI for title: Geos: Geodesic image segmentation
- 10.1145/1409625.1409626 may be a valid DOI for title: Parallel algorithms for approximation of distance maps on parametric surfaces
- 10.1016/0167-8655(96)00010-4 may be a valid DOI for title: New geodosic distance transforms for gray-scale images

INVALID DOIs

- None
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 2 years ago

@masadcv thanks for this JOSS submission. I am the AEiC on call this week and here to help process the initial steps for this work. Before we proceed, can you check the following:

Kevin-Mattheus-Moerman commented 2 years ago

@editorialbot invite @vissarion as editor

editorialbot commented 2 years ago

Invitation to edit this submission sent!

vissarion commented 2 years ago

@editorialbot assign @vissarion as editor

editorialbot commented 2 years ago

Assigned! @vissarion is now the editor

vissarion commented 2 years ago

Hi @bencardoen, @kris-rowe, @yhtang, @jacobmerson, @yuhc would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

masadcv commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

masadcv commented 2 years ago

@editorialbot check references

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-540-88682-2_9 is OK
- 10.1145/1409625.1409626 is OK
- 10.1016/0167-8655(96)00010-4 is OK

MISSING DOIs

- None

INVALID DOIs

- None
masadcv commented 2 years ago

Hi @Kevin-Mattheus-Moerman, Many thanks for starting the review thread. I have fixed the missing DOI and regenerated the paper. Looking forward!

yhtang commented 2 years ago

Hi @vissarion, I'd be happy to review this submission.

vissarion commented 2 years ago

@editorialbot add @yhtang as reviewer

editorialbot commented 2 years ago

@yhtang added to the reviewers list!

kris-rowe commented 2 years ago

@vissarion very recently I agreed to review another paper, so I will sit this one out unless it is not possible to find a second reviewer

jacobmerson commented 2 years ago

@vissarion I can review this paper

yuhc commented 2 years ago

@vissarion I'll have no internet access for the next 10 days. I can help if more reviewers are needed at that time.

bencardoen commented 2 years ago

@vissarion I can review but only starting in ~ 2 weeks due to health issues, if you need review sooner than that, then I'm afraid I'm unable to help.

vissarion commented 2 years ago

@editorialbot add @jacobmerson as reviewer

editorialbot commented 2 years ago

@jacobmerson added to the reviewers list!

vissarion commented 2 years ago

@bencardoen ~ 2 weeks is OK I would like to add you as a 3rd reviewer if you agree

bencardoen commented 2 years ago

@vissarion sure, sounds good :+1:

vissarion commented 2 years ago

@editorialbot add @bencardoen as reviewer

editorialbot commented 2 years ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

vissarion commented 2 years ago

@editorialbot add @bencardoen as reviewer

editorialbot commented 2 years ago

@bencardoen added to the reviewers list!

vissarion commented 2 years ago

@editorialbot start review

editorialbot commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4532.