search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: xtal2png: A Python package for representing crystal structure as PNG files #4528

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@sgbaird<!--end-author-handle-- (Sterling Baird) Repository: https://github.com/sparks-baird/xtal2png Branch with paper.md (empty if default branch): main Version: 0.9.4 Editor: !--editor-->@rkurchin<!--end-editor-- Reviewers: @dandavies99, @PeterKraus Archive: 10.5281/zenodo.6941663

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0c704f6ae9739c1e97e05ae0ad57aecb"><img src="https://joss.theoj.org/papers/0c704f6ae9739c1e97e05ae0ad57aecb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0c704f6ae9739c1e97e05ae0ad57aecb/status.svg)](https://joss.theoj.org/papers/0c704f6ae9739c1e97e05ae0ad57aecb)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dandavies99 & @PeterKraus, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @PeterKraus

📝 Checklist for @dandavies99

rkurchin commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/ARXIV.1610.02415 is OK
- 10.1021/acscentsci.7b00572 is OK
- 10.48550/ARXIV.1910.00617 is OK
- 10.1038/s41467-020-19964-7 is OK
- 10.48550/ARXIV.1609.02907 is OK
- 10.1016/j.commatsci.2012.10.028 is OK
- 10.1016/j.matt.2021.11.032 is OK
- 10.1145/3528233.3530757 is OK
- 10.48550/ARXIV.2204.00056 is OK
- 10.1038/s41524-021-00545-1 is OK
- 10.26434/chemrxiv.11869026.v1 is OK
- 10.1021/ci00057a005 is OK
- 10.48550/ARXIV.1710.10324 is OK
- 10.1103/PhysRevLett.120.145301 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:warning: Error prepararing paper acceptance. The generated XML metadata file is invalid. 

IDREFS attribute rid references an unknown ID "ref-sahariaPaletteImagetoImageDiffusion2022"
sgbaird commented 2 years ago

Ah... woops. I thought I had changed it back to sahariaPaletteImagetoImageDiffusion2022, but looks like it stayed as sahariaPaletteImagetoImageDiffusion2022a.

sgbaird commented 2 years ago

Version: v0.9.4 DOI: 10.5281/zenodo.6941663

sgbaird commented 2 years ago

@editorialbot check references

editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/ARXIV.1610.02415 is OK
- 10.1021/acscentsci.7b00572 is OK
- 10.48550/ARXIV.1910.00617 is OK
- 10.1038/s41467-020-19964-7 is OK
- 10.48550/ARXIV.1609.02907 is OK
- 10.1016/j.commatsci.2012.10.028 is OK
- 10.1016/j.matt.2021.11.032 is OK
- 10.1145/3528233.3530757 is OK
- 10.48550/ARXIV.2204.00056 is OK
- 10.1038/s41524-021-00545-1 is OK
- 10.26434/chemrxiv.11869026.v1 is OK
- 10.1021/ci00057a005 is OK
- 10.48550/ARXIV.1710.10324 is OK
- 10.1103/PhysRevLett.120.145301 is OK

MISSING DOIs

- None

INVALID DOIs

- None
rkurchin commented 2 years ago

@editorialbot set 0.9.4 as version

editorialbot commented 2 years ago

Done! version is now 0.9.4

rkurchin commented 2 years ago

@editorialbot set 10.5281/zenodo.6941663 as archive

editorialbot commented 2 years ago

Done! Archive is now 10.5281/zenodo.6941663

rkurchin commented 2 years ago

@editorialbot recommend-accept

(my apologies for the extra delay fixing this very tiny thing 😆 )

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/ARXIV.1610.02415 is OK
- 10.1021/acscentsci.7b00572 is OK
- 10.48550/ARXIV.1910.00617 is OK
- 10.1038/s41467-020-19964-7 is OK
- 10.48550/ARXIV.1609.02907 is OK
- 10.1016/j.commatsci.2012.10.028 is OK
- 10.1016/j.matt.2021.11.032 is OK
- 10.1145/3528233.3530757 is OK
- 10.48550/ARXIV.2204.00056 is OK
- 10.1038/s41524-021-00545-1 is OK
- 10.26434/chemrxiv.11869026.v1 is OK
- 10.1021/ci00057a005 is OK
- 10.48550/ARXIV.1710.10324 is OK
- 10.1103/PhysRevLett.120.145301 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3409, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 2 years ago

@editorialbot accept

editorialbot commented 2 years ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3410
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04528
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 2 years ago

@dandavies99, @PeterKraus – many thanks for your reviews here and to @rkurchin for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@sgbaird – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04528/status.svg)](https://doi.org/10.21105/joss.04528)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04528">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04528/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04528/status.svg
   :target: https://doi.org/10.21105/joss.04528

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: