openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
706 stars 37 forks source link

[PRE REVIEW]: geostan: An R package for Bayesian spatial analysis #4578

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@ConnorDonegan<!--end-author-handle-- (Connor Donegan) Repository: https://github.com/ConnorDonegan/geostan Branch with paper.md (empty if default branch): JOSS Version: V0.3.0 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @wcjochem, @becarioprecario Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b"><img src="https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b/status.svg)](https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b)

Author instructions

Thanks for submitting your paper to JOSS @ConnorDonegan. Currently, there isn't a JOSS editor assigned to your paper.

@ConnorDonegan if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (1193.1 files/s, 211612.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            41           1300            133           6559
R                               29            213           2464           3141
TeX                              3             63              0            496
CSS                              3             98             52            442
JavaScript                       3             64             32            256
Markdown                         3             93              0            240
Rmd                              3            191            295            125
XML                              1              0              0            123
YAML                             3              3              4             85
SVG                              1              0              1             11
Bourne Shell                     2              4              2              4
C/C++ Header                     1              0              1              0
-------------------------------------------------------------------------------
SUM:                            93           2029           2984          11482
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 1047

editorialbot commented 2 years ago

Failed to discover a valid open source license

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.3390/ijerph18136856 is OK
- 10.2307/2532039 is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK

MISSING DOIs

- 10.1016/j.spasta.2020.100450 may be a valid DOI for title: Bayesian estimation of spatial filters with Moran’s eigenvectors and hierarchical shrinkage priors
- 10.1111/j.1467-8306.2005.00484.x may be a valid DOI for title: Effective geographic sample size in the presence of spatial autocorrelation
- 10.1016/c2017-0-01015-7 may be a valid DOI for title: Spatial Regression Analysis Using Eigenvector Spatial Filtering
- 10.1111/j.1538-4632.2007.00708.x may be a valid DOI for title: Beyond Moran’s I: Testing for spatial dependence based on the spatial autoregressive model
- 10.1016/j.csda.2008.07.033 may be a valid DOI for title: Statistical analysis of small-area data based on independence, spatial, non-hierarchical, and hierarchical models
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 may be a valid DOI for title: Disease mapping with errors in covariates
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m may be a valid DOI for title: Spatio-temporal models with errors in covariates: mapping Ohio lung cancer mortality
- 10.1111/j.2517-6161.1974.tb00999.x may be a valid DOI for title: Spatial interaction and the statistical analysis of lattice systems
- 10.1007/bf00116466 may be a valid DOI for title: Bayesian image restoration, with two applications in spatial statistics
- 10.1177/0962280216660421 may be a valid DOI for title: An intuitive Bayesian spatial model for disease mapping that accounts for scaling
- 10.1016/j.sste.2019.100301 may be a valid DOI for title: Bayesian hierarchical spatial models: Implementing the Besag York Mollié model in stan
- 10.18637/jss.v063.i18 may be a valid DOI for title: Comparing Implementations of Estimation Methods for Spatial Econometrics
- 10.1111/j.1538-4632.1995.tb00338.x may be a valid DOI for title: Local indicators of spatial association—LISA

INVALID DOIs

- None
ConnorDonegan commented 2 years ago

A few potential reviewers: Volkerschmid becarioprecario wcjochem

ConnorDonegan commented 2 years ago

@editorialbot commands

editorialbot commented 2 years ago

Hello @ConnorDonegan, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Get a link to the complete list of reviewers
@editorialbot list reviewers
ConnorDonegan commented 2 years ago

@editorialbot generate my checklist

editorialbot commented 2 years ago

@ConnorDonegan I can't do that because you are not a reviewer

Kevin-Mattheus-Moerman commented 2 years ago

@ConnorDonegan I am an AEiC with JOSS and here to help with initial steps before we proceed. Can you check the following:

ConnorDonegan commented 2 years ago

@editorialbot check references

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK

MISSING DOIs

- 10.1111/j.1538-4632.1995.tb00338.x may be a valid DOI for title: Local indicators of spatial association—LISA

INVALID DOIs

- None
ConnorDonegan commented 2 years ago

@editorialbot check references

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- None

INVALID DOIs

- None
ConnorDonegan commented 2 years ago

@Kevin-Mattheus-Moerman Thanks, I think I've addresses those issues now.

Kevin-Mattheus-Moerman commented 2 years ago

@editorialbot check repository

editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (1178.2 files/s, 208931.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            41           1300            133           6559
R                               29            213           2464           3141
TeX                              3             63              0            493
CSS                              3             98             52            442
JavaScript                       3             64             32            256
Markdown                         3             93              0            240
Rmd                              3            191            295            125
XML                              1              0              0            123
YAML                             3              3              4             85
SVG                              1              0              1             11
Bourne Shell                     2              4              2              4
C/C++ Header                     1              0              1              0
-------------------------------------------------------------------------------
SUM:                            93           2029           2984          11479
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 1047

Kevin-Mattheus-Moerman commented 2 years ago

@ConnorDonegan thanks for making those changes. Note I have just waitlisted this submission. This is because all editors in this domain are currently busy handling other submissions. We will assign an editor to handle this work as soon as one becomes available.

arfon commented 2 years ago

@editorialbot invite @jbytecode as editor

:wave: @jbytecode – would you be willing to edit this submission for us? I realize it's a little out of your area 😄

editorialbot commented 2 years ago

Invitation to edit this submission sent!

jbytecode commented 2 years ago

@editorialbot assign me as editor

@arfon - of course, gladly :)

editorialbot commented 2 years ago

Assigned! @jbytecode is now the editor

jbytecode commented 2 years ago

👋👋👋 Dear @Volkerschmid, @becarioprecario, @wcjochem 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: "geostan: An R package for Bayesian spatial analysis". You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/4578).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a seperate thread. In that thread, there will be 20 check items for each single reviewer.

Thank you in advance!

jbytecode commented 2 years ago

@ConnorDonegan - Thank you for submitting your paper for JOSS. I am the handling editor.

The reviewers you suggested seem to be inactive for a while. I will wait for a couple of days to get a response (Because it is the vacation time for much of us).

Thank you in advance.

jbytecode commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

wcjochem commented 2 years ago

Dear @jbytecode this sounds like a very interesting submission. Unfortunately, I'm working on another JOSS review currently and with other projects deadlines and upcoming leave I wouldn't be available to help to start with this until mid-September.

jbytecode commented 2 years ago

@wcjochem - thank you for the response. If you can start about 15th Sep, it is okay to me. Would you like me to assign you now?

wcjochem commented 2 years ago

@jbytecode Yes, I'll accept this assignment and can start in mid-September.

jbytecode commented 2 years ago

@editorialbot add @wcjochem as reviewer

editorialbot commented 2 years ago

@wcjochem added to the reviewers list!

jbytecode commented 2 years ago

👋👋👋 Dear @nuest, @cole-brokamp 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

A reviewer has already accepted our invitation, we need a second one.

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: "geostan: An R package for Bayesian spatial analysis". You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/4578).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a seperate thread. In that thread, there will be 20 check items for each single reviewer.

Thank you in advance!

cole-brokamp commented 2 years ago

Hi @jbytecode —- I don’t feel like I would be able to give a quality review here. Although I work with place-based data a lot, I don’t do any spatial analyses and I’ve never done Bayesian modeling nor used Stan.

jbytecode commented 2 years ago

@cole-brokamp - thank you for the response. Hope we can work on future projects.

becarioprecario commented 2 years ago

Hi,

I can review this paper.

Best,

Virgilio


De: Mehmet Hakan Satman @.> Enviado: domingo, 28 de agosto de 2022 15:39 Para: openjournals/joss-reviews @.> Cc: Virgilio Gómez Rubio @.>; Mention @.> Asunto: Re: [openjournals/joss-reviews] [PRE REVIEW]: geostan: An R package for Bayesian spatial analysis (Issue #4578)

@cole-brokamphttps://github.com/cole-brokamp - thank you for the response. Hope we can work on future projects.

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/4578#issuecomment-1229459065, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABYD6WWGGKLGNV2ITMY24KLV3NTYFANCNFSM533NOVAA. You are receiving this because you were mentioned.Message ID: @.***>

jbytecode commented 2 years ago

@editorialbot add @becarioprecario as reviewer

editorialbot commented 2 years ago

@becarioprecario added to the reviewers list!

jbytecode commented 2 years ago

@editorialbot start review

editorialbot commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4716.