openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: RTMsim - A Julia module for filling simulations in Resin Transfer Moulding with the Finite Area Method #4598

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@obertscheiderfhwn<!--end-author-handle-- (Christof Obertscheider) Repository: https://github.com/obertscheiderfhwn/RTMsim Branch with paper.md (empty if default branch): Version: v1.0.1 Editor: !--editor-->@Fei-Tao<!--end-editor-- Reviewers: @duhd1993, @bbrelje Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ac97b5f0bc886be23981c56fe9673ca2"><img src="https://joss.theoj.org/papers/ac97b5f0bc886be23981c56fe9673ca2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ac97b5f0bc886be23981c56fe9673ca2/status.svg)](https://joss.theoj.org/papers/ac97b5f0bc886be23981c56fe9673ca2)

Author instructions

Thanks for submitting your paper to JOSS @obertscheiderfhwn. Currently, there isn't a JOSS editor assigned to your paper.

@obertscheiderfhwn if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (275.3 files/s, 135503.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                            2            149            252           2369
Markdown                         2             88              0            265
TeX                              1             43              0            255
YAML                             1              1              4             18
DOS Batch                        1              0              0              1
-------------------------------------------------------------------------------
SUM:                             7            281            256           2908
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 2174

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/pc.23474 is OK
- 10.1590/S1678-58782012000200001 is OK
- 10.1007/BF01448839 is OK
- 10.1063/1.350236 is OK
- 10.1177/0021998318780209 is OK
- 10.1016/j.compositesa.2019.03.006 is OK

MISSING DOIs

- Errored finding suggestions for "Reinforcement learning for Resin Transfer Moulding", please try later
- Errored finding suggestions for "NASA STRuctrual ANalysis (NASTRAN)", please try later
- Errored finding suggestions for "An Introduction to Computational Fluid Dynamics: T...", please try later
- Errored finding suggestions for "Liquid moulding technologies - Resin transfer moul...", please try later
- Errored finding suggestions for "Development of a next generation composite - Annul...", please try later
- Errored finding suggestions for "An Evaluation of the Reproducibility of Capacitive...", please try later
- 10.1016/0956-7143(94)90031-0 may be a valid DOI for title: Flow and rheology in polymer composites manufacturing

INVALID DOIs

- https://doi.org/10.1002/pen.760311613 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.compfluid.2011.11.003 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.ijmultiphaseflow.2011.05.002 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.compfluid.2018.02.017 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.compfluid.2013.04.002 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/0301-9322(88)90006-7 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 2 years ago

@obertscheiderfhwn can you check/fix those potentially missing/invalid DOIs? :point_up: You can check the references again by calling: @editorialbot check references, and you can call @editorialbot generate pdf to update the draft.

Kevin-Mattheus-Moerman commented 2 years ago

@obertscheiderfhwn I've waitlisted this submission just now since the editors in the domain are all busy handling other submissions. We will assign an editor once one becomes available.

Kevin-Mattheus-Moerman commented 2 years ago

@kyleniemeyer do you think you can help edit this one once you are available?

obertscheiderfhwn commented 2 years ago

@editorialbot commands

editorialbot commented 2 years ago

Hello @obertscheiderfhwn, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Get a link to the complete list of reviewers
@editorialbot list reviewers
obertscheiderfhwn commented 2 years ago

@editorialbot check references

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/0021998318780209 is OK
- 10.1002/pc.23474 is OK
- 10.1016/j.compfluid.2011.11.003 is OK

MISSING DOIs

- 10.1016/0956-7143(94)90031-0 may be a valid DOI for title: Flow and rheology in polymer composites manufacturing

INVALID DOIs

- None
obertscheiderfhwn commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

obertscheiderfhwn commented 2 years ago

@editorialbot check references

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/0021998318780209 is OK
- 10.1002/pc.23474 is OK
- 10.1016/j.compfluid.2011.11.003 is OK

MISSING DOIs

- None

INVALID DOIs

- None
obertscheiderfhwn commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Fei-Tao commented 2 years ago

@editorialbot assign me as editor

editorialbot commented 2 years ago

Assigned! @Fei-Tao is now the editor

Fei-Tao commented 2 years ago

@obertscheiderfhwn if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Fei-Tao commented 2 years ago

@helgee This paper is related to composites manufacturing, which belongs to aerospace engineering in general. if you'd like to review this submission, please comment here! Feel free to unsubscribe from this issue if you are not interested.

Fei-Tao commented 2 years ago

👋🏻 Hi, @ericneiva, @ketch,@bbrelje, @kylebeggs, @duhd1993 if you'd like to review this submission, please comment here! Feel free to unsubscribe from this issue if you are not interested.

kylebeggs commented 2 years ago

@Fei-Tao Unfortunately, I don't have time the next few weeks. If it is still needed then, ping me again.

ericneiva commented 2 years ago

@Fei-Tao thanks for the invitation. I am afraid I won't be able to take on any review until the second half of September. If you still need me by then, do not hesitate to get back to me.

Fei-Tao commented 2 years ago

@kylebeggs @ericneiva, thank you for your quick response. I will wait for the other reviewer's response. I will let you know if I still need your help. Thank you for your time!

ketch commented 2 years ago

@Fei-Tao I don't think I have the appropriate expertise.

Fei-Tao commented 2 years ago

@ketch since finite area method is a variant of the finite volume method, I thought you have the expertise on this topic. Thank you for your prompt response. Have a good day.

duhd1993 commented 2 years ago

Hi @Fei-Tao Thanks for the opportunity. I'd like to help with review the package and paper.

Fei-Tao commented 2 years ago

@editorialbot add @duhd1993 as reviewer

editorialbot commented 2 years ago

@duhd1993 added to the reviewers list!

Fei-Tao commented 2 years ago

@duhd1993 thank you for accept to review this paper. We will start the reviewing process after we find another reviewer.

bbrelje commented 2 years ago

@Fei-Tao I can do it

Fei-Tao commented 2 years ago

@bbrelje Great! Thanks for helping review this submission.

Fei-Tao commented 2 years ago

@editorialbot add @bbrelje as reviewer

editorialbot commented 2 years ago

@bbrelje added to the reviewers list!

Fei-Tao commented 2 years ago

@editorialbot start review

editorialbot commented 2 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4763.

Fei-Tao commented 2 years ago

Thanks everyone! Looking forward to your reviews in https://github.com/openjournals/joss-reviews/issues/4763.