openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
704 stars 37 forks source link

[PRE REVIEW]: DART: Dynamic Animation and Robotics Toolkit #460

Closed whedon closed 6 years ago

whedon commented 6 years ago

Submitting author: @jslee02 (Jeongseok Lee) Repository: https://github.com/dartsim/dart Version: 6.3.0 Editor: @Kevin-Mattheus-Moerman Reviewer: @bmagyar

Author instructions

Thanks for submitting your paper to JOSS @jslee02. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@jslee02 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 6 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @labarba it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
arfon commented 6 years ago

👋 @labarba - the submitting author suggested you as the editor.

jslee02 commented 6 years ago

Thank you for initiating this process!

I have a question about ORCID and am asking the question here because I couldn't find an available email address to the editors of JOSS.

Unfortunately, we don't have the ORCID for one of the authors because he has passed away. What could we do in this case? We could make one for him, but I wonder if it would be preferred to just leaving it empty or 0000-0000-0000-0000.

arfon commented 6 years ago

@jslee02 - it's ok to omit the ORCID field for the author who has passed away.

jslee02 commented 6 years ago

@arfon Thanks! Will do so.

jslee02 commented 6 years ago

Potential reviewers: @mosteo, @katyhuff, @betatim, @pragyansmita, @kyleniemeyer

betatim commented 6 years ago

I'd be happy to look at this.

Kevin-Mattheus-Moerman commented 6 years ago

I've also pinged my colleagues at MIT Biomechatronics

Kevin-Mattheus-Moerman commented 6 years ago

I can be editor if @labarba can't take this one

labarba commented 6 years ago

Feel free to take it, @Kevin-Mattheus-Moerman.

Kevin-Mattheus-Moerman commented 6 years ago

@whedon assign @kevin-mattheus-moerman as editor

Kevin-Mattheus-Moerman commented 6 years ago

@whedon assign @Kevin-Mattheus-Moerman as editor

Kevin-Mattheus-Moerman commented 6 years ago

@arfon I'm trying to assign myself as editor. It seems whedon removed lorena but it does not look like it assigned me. Can you see what is going on?

kyleniemeyer commented 6 years ago

@Kevin-Mattheus-Moerman you are listed as editor above, no? it looks like @whedon just didn't assign you to the issue.

Kevin-Mattheus-Moerman commented 6 years ago

@kyleniemeyer @arfon thanks yep it is all good

arfon commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago
https://github.com/openjournals/joss-papers/blob/joss.00460/10.21105.joss.00460.pdf
arfon commented 6 years ago

☝️ @Kevin-Mattheus-Moerman - Whedon can now try and compile the PDF for you. Looks like this worked (I'm trying to catch errors with the papers before they even get to the review stage now).

jslee02 commented 6 years ago

There was a correction of the affiliations. Let me regenerate the PDF.

jslee02 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
Kevin-Mattheus-Moerman commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago
PDF failed to compile for issue #460 with the following error: 

 Can't find any papers to compile :-(
arfon commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago
https://github.com/openjournals/joss-papers/blob/joss.00460/joss.00460/10.21105.joss.00460.pdf
whedon commented 6 years ago
https://github.com/openjournals/joss-papers/blob/joss.00460/joss.00460/10.21105.joss.00460.pdf
Kevin-Mattheus-Moerman commented 6 years ago

@bmagyar I know @danielskatz just pinged you to review over at https://github.com/openjournals/joss-reviews/issues/477,... but if this submission interests you as well it would be great if you could assist with review here too.

jslee02 commented 6 years ago

@Kevin-Mattheus-Moerman I'm not trying to involve in the reviewer matching process, but I just wonder if you saw @betatim's comment above that he's interested in looking at this submission.

bmagyar commented 6 years ago

Hi guys,

Yes, I'd be pretty interested in reviewing this one actually! The only downside is that I can only start it over the holidays.

On Dec 12, 2017 5:43 AM, "Jeongseok Lee" notifications@github.com wrote:

@Kevin-Mattheus-Moerman https://github.com/kevin-mattheus-moerman I'm not trying to involve in the reviewer matching process, but I just wonder if you saw @betatim https://github.com/betatim's comment https://github.com/openjournals/joss-reviews/issues/460#issuecomment-345426150 above that he's interested in looking at this submission.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/460#issuecomment-350951407, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXH4c39Br67dsIYmc9qN6CexvBBUQDhks5s_hJ7gaJpZM4Qfx9R .

Kevin-Mattheus-Moerman commented 6 years ago

Great @bmagyar ! Starting over the holidays is fine.

Kevin-Mattheus-Moerman commented 6 years ago

@jslee02 thanks for your inquiry. I was hoping to recruit more than 1 reviewer and also include a robotics specialist. It seems we have exactly that now so we are good to start. Both @bmagyar and @betatim will be reviewers.

Kevin-Mattheus-Moerman commented 6 years ago

@whedon assign @bmagyar as reviewer

whedon commented 6 years ago

OK, the reviewer is @bmagyar

Kevin-Mattheus-Moerman commented 6 years ago

@whedon start review magic-word=bananas

whedon commented 6 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/500. Feel free to close this issue now!