search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[REVIEW]: fseval: A Benchmarking Framework for Feature Selection and Feature Ranking Algorithms #4611

Closed editorialbot closed 1 year ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@dunnkers<!--end-author-handle-- (Jeroen Gerard Sebastiaan Overschie) Repository: https://github.com/dunnkers/fseval Branch with paper.md (empty if default branch): paper Version: 3.1.0 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @mcasl, @estefaniatalavera Archive: 10.5281/zenodo.7343417

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d850aeb67247318aeef735d5eca95c1c"><img src="https://joss.theoj.org/papers/d850aeb67247318aeef735d5eca95c1c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d850aeb67247318aeef735d5eca95c1c/status.svg)](https://joss.theoj.org/papers/d850aeb67247318aeef735d5eca95c1c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mcasl & @estefaniatalavera, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @mcasl

📝 Checklist for @estefaniatalavera

arfon commented 1 year ago

DOI is now resolving but we'll need to re-reaccept when we figure out the capitalisation issue.

danielskatz commented 1 year ago

While we wait for the final name fix, thanks to @mcasl and @estefaniatalavera for reviewing, and to @diehlpk for editing!! We couldn't do this without you

tarleb commented 1 year ago

It seems to be limited to the HTML presentation; both the PDF and JATS have the correct capitalization. Not sure what might be causing this.

arfon commented 1 year ago

@xuanxu - perhaps this is theoj Gem doing something weird here?

xuanxu commented 1 year ago

Yes, the parsing was taking the second names as a dropping particle. Reaccepting the paper after this change should fix it.

dunnkers commented 1 year ago

Yes, the parsing was taking the second names as a dropping particle. Reaccepting the paper after this change should fix it.

That's awesome @xuanxu . PR approved & merged ✓

danielskatz commented 1 year ago

@editorialbot reaccept

editorialbot commented 1 year ago 
Rebuilding paper!
editorialbot commented 1 year ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/3757

danielskatz commented 1 year ago

All now looks good to me - thanks @arfon and @xuanxu !!

danielskatz commented 1 year ago

And congratulations to @dunnkers and co-authors!!

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04611/status.svg)](https://doi.org/10.21105/joss.04611)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04611">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04611/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04611/status.svg
   :target: https://doi.org/10.21105/joss.04611

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: