search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[REVIEW]: graphenv: a Python library for reinforcement learning on graph search spaces #4621

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@pstjohn<!--end-author-handle-- (Peter C. St. John) Repository: https://github.com/NREL/graph-env/ Branch with paper.md (empty if default branch): Version: v0.1.3 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @iammix, @vwxyzjn, @Viech, @idoby Archive: 10.5281/zenodo.7030161

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1d1427f9c72a4a7fb9ac2a53506e0733"><img src="https://joss.theoj.org/papers/1d1427f9c72a4a7fb9ac2a53506e0733/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1d1427f9c72a4a7fb9ac2a53506e0733/status.svg)](https://joss.theoj.org/papers/1d1427f9c72a4a7fb9ac2a53506e0733)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@iammix & @vwxyzjn & @Viech & @idoby, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @iammix

📝 Checklist for @vwxyzjn

📝 Checklist for @idoby

📝 Checklist for @Viech

editorialbot commented 2 years ago

Done! version is now v0.1.3

osorensen commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1806.01261 is OK
- 10.11578/dc.20201221.3 is OK
- 10.48550/arXiv.1606.01540 is OK
- 10.48550/arXiv.1712.09381 is OK
- 10.1016/j.patter.2021.100361 is OK
- 10.1039/d1sc02770k is OK
- 10.1038/s41597-020-00588-x is OK
- 10.1038/s41467-020-16201-z is OK
- 10.1038/s42256-022-00506-3 is OK
- 10.1007/978-3-030-50426-7_33 is OK
- 10.48550/arXiv.2011.06069 is OK
- 10.1038/s41598-019-47148-x is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3486, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

osorensen commented 2 years ago

Thanks for your very good and useful reviews @iammix, @vwxyzjn, @Viech, @idoby.

Thanks for responding so quickly @pstjohn, and congratulations with a very nice piece of software and a well written paper.

The editor in chief will take over from here.

arfon commented 2 years ago

@editorialbot accept

editorialbot commented 2 years ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3505
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04621
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 2 years ago

@iammix, @vwxyzjn, @Viech, @idoby – many thanks for your reviews here and to @osorensen for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@pstjohn – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04621/status.svg)](https://doi.org/10.21105/joss.04621)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04621">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04621/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04621/status.svg
   :target: https://doi.org/10.21105/joss.04621

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: