editorialbot commented 2 years ago

Submitting author: !--author-handle-->@minaskar@dfm<!--end-editor-- Reviewers: @kazewong, @marylou-gabrie Archive: 10.5281/zenodo.7308533

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e7d10f594f5c8eb682d29dd84aaf71be"><img src="https://joss.theoj.org/papers/e7d10f594f5c8eb682d29dd84aaf71be/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e7d10f594f5c8eb682d29dd84aaf71be/status.svg)](https://joss.theoj.org/papers/e7d10f594f5c8eb682d29dd84aaf71be)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kazewong & @marylou-gabrie, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @kazewong

📝 Checklist for @marylou-gabrie

editorialbot commented 2 years ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 2 years ago

Software report:

github.com/AlDanial/cloc v 1.88  T=0.20 s (723.0 files/s, 229491.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      12           2426           2523           9374
SVG                              6              0             13           9319
HTML                            17           1199            251           5692
CSS                             10            398            138           3169
PO File                         45           1087              0           2444
Python                          20            667           1528           2163
reStructuredText                14            286            146            503
Jupyter Notebook                13              0           2499            445
Markdown                         4             95              0            311
YAML                             4             22             17            132
TeX                              1              8              0             66
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           148           6200           7123          33653
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

editorialbot commented 2 years ago

Wordcount for paper.md is 1254

editorialbot commented 2 years ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1214/06-ba127 may be a valid DOI for title: Nested sampling for general Bayesian computation

INVALID DOIs

- None

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 2 years ago

@kazewong, @marylou-gabrie — This is the review thread for the paper. All of our communications will happen here from now on. Thanks again for agreeing to participate!

Please read the "Reviewer instructions & questions" in the first comment above, and generate your checklists by commenting @editorialbot generate my checklist on this issue ASAP. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#4634 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please try to make a start ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

kazewong commented 2 years ago

Review checklist for @kazewong

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the https://github.com/minaskar/pocomc?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@minaskar) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

marylou-gabrie commented 2 years ago

Review checklist for @marylou-gabrie

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the https://github.com/minaskar/pocomc?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@minaskar) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

dfm commented 2 years ago

@kazewong, @marylou-gabrie — Just a quick check in here to keep this on your radar. Let us know if you run into any issues!

marylou-gabrie commented 2 years ago

A few questions:

What does the scale quantity logged in the results refer to? I did not find an explanation in the documentation.
Is there a way to access the trained flow (or flows)? This is definitely for advanced usage, but maybe it would be good to have a way to assess the quality of training of the flow model. Then, one could assess whether it is necessary to play with the training/config parameters to speedup the sampling.
What is the training loss function for the flow? I might have missed something but I did not find this info, neither in the JOSS submission nor in the accompanying paper.
Are the authors aware of typical cases in which the method fails? If yes it would be interesting to add a concise mention to limitations.

Overall comment:

Overall the documentation is well detailed and the effort to automate the sequential scheme is remarkable. The paper gives a concise overview of the method, directed to a wise audience. I do note that the specifics of the algorithms and many related references are instead in the accompanying paper (submitted to a different venue I imagine).

Minor:

The correlation coefficient threshold changes notation between the "Background"section of the docs (CC) and the "Advanced Guide"(gamma).

kazewong commented 2 years ago

Questions/comments related to unchecked items

[ ] Performance/Summary: See this thread https://github.com/minaskar/pocomc/issues/17#issue-1352355283
[x] Community Guideline: I don't see any comments for seeking support. Per the checklist, I think the Authors should add some guideline to seeking support.
[x] State-of-the-field/references: I think there are missing references which @marylou-gabrie have also flagged. For state-of-the-field, specifically related to code, I don't think it is any big issue, but the authors should add a couple references related to previous studies that didn't come with open-source codes. Once the authors added the reference suggested by @marylou-gabrie, I am happy to check both boxes out.

minaskar commented 2 years ago

Thank you both for your comments!

@marylou-gabrie

The scale variable refers to the ratio of the Metropolis proposal scale (in latent space) to the optimal proposal scale 2.38/Sqrt(D). It is a metric of the preconditioner's performance (i.e. 1 corresponds to perfect preconditioning). I'll make sure we include an explanation in the docs.
The trained flow can be accessed using the Flow class method of the sampler.
The flow loss function is the usual forward KL divergence $D_{KL}[p|q]$.
Cases in which PMC (and thus pocoMC) might not be the best choice are discussed in the Discussion section of the accompanying paper and include high-dimensional targets and/or cases in which the likelihood evaluation is cheap compared to the flow training cost. Of course, one can construct artificial cases in which the multimodality is so strong that the flow is not expressive enough to capture it. Since the code is intended for astronomical/cosmological research we do not expect any such difficulties.

@kazewong

Regarding performance please see the response and our questions in the aforementioned thread.
Brief instructions regarding users seeking support are available in the CONTRIBUTING.md guide and the main page of the docs.
We are more than happy to add the missing references.

marylou-gabrie commented 1 year ago

Thanks @minaskar for your helpful answers.

My only remaining question is how do you evaluate the forward KL: using which samples (and potential reweighting) to approximate the expectation over $p$ (where $p$ is the succesively annealed distribution if I am not mistaken)?

Please let us know when the missing references have been added to the paper.

After that, all good for me.

kazewong commented 1 year ago

I have added comments in the discussion thread in the code repo. Once that is addressed, I will be happy with the submission.

dfm commented 1 year ago

@minaskar — I wanted to check in here since I think we're waiting on your responses to @kazewong, @marylou-gabrie's final small comments. Let us know if anything isn't clear or if you've addressed these issues. Thanks!

minaskar commented 1 year ago

@marylou-gabrie We're currently using the samples from the current annealed distribution in order to train the flow that will serve as the preconditioner for the next annealed distribution. Since the beta-spacings are small enough we found no benefit in reweighting the samples.

@dfm Thanks for the reminder and apologies for the delayed response, we will address the remaining comments during the next few days.

minaskar commented 1 year ago

Hi @kazewong and @marylou-gabrie,

I've added the missing references and fixed the minor issues. Let me know if there's anything else missing.

dfm commented 1 year ago

@kazewong, @marylou-gabrie — Can you both take a look at @minaskar's responses to your feedback and let us know if there are any remaining issues? Thanks!!

marylou-gabrie commented 1 year ago

Thanks Minas and Dan, that's all good for me.

dfm commented 1 year ago

@kazewong — Any updates from your end? Let us know if there are any remaining issues!

(Aside: @marylou-gabrie it looks like your authorship checkbox got unchecked - was that on purpose?)

kazewong commented 1 year ago

All green from me

dfm commented 1 year ago

@kazewong — Great! In that case can you update your checklist above? I'm still seeing some boxes unchecked. Thanks!

kazewong commented 1 year ago

@dfm all checked.

dfm commented 1 year ago

@kazewong, @marylou-gabrie — Thanks both for your reviews and all of your suggestions for pocoMC!! I really appreciate the time that you took for this process.

@minaskar — I have a few last checks that I need to do (although I probably can't get to them today), then I'll have some final things that I need from you before acceptance. I'll have an update for you in the next day or two. Thanks for your patience!

dfm commented 1 year ago

@editorialbot check references

dfm commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1093/mnras/stac2272 may be a valid DOI for title: Accelerating astronomical and cosmological inference with Preconditioned Monte Carlo
- 10.1214/06-ba127 may be a valid DOI for title: Nested sampling for general Bayesian computation
- 10.1073/pnas.2109420119 may be a valid DOI for title: Adaptive Monte Carlo augmented with normalizing flows
- 10.1093/mnras/staa1469 may be a valid DOI for title: Accelerated Bayesian inference using deep learning

INVALID DOIs

- None

minaskar commented 1 year ago

@marylou-gabrie @kazewong, thanks a lot for the reviews, and of course, @dfm for taking care of everything.

Regarding the DOIs, I can verify that those four suggestions are correct. Should I add them to the reference list?

dfm commented 1 year ago

@minaskar don't worry about the DOIs: I'll have some larger edits to the bibliography that will include them!

dfm commented 1 year ago

@minaskar — I've opened a PR with some minor edits to the paper. After merging or responding to that, here are the final steps that I'll need from you:

Take one last read through the manuscript to make sure that you're happy with it (it's harder to make changes later!), especially the author names and affiliations. I've taken a pass and it looks good to me!
Increment the version number of the software and report that version number back here.
Create an archived release of that version of the software (using Zenodo or something similar). Please make sure that the metadata (title and author list) exactly match the paper. Then report the DOI of the release back to this thread.

minaskar commented 1 year ago

@dfm I merged the PR (actually made a new PR and merged it to the dev branch first, as the main is protected).

Version number is 0.2.3 and DOI is 10.5281/zenodo.7306240

dfm commented 1 year ago

@minaskar — Great! Can you make an updated archive using a clean checkout or directly from this zip file: https://github.com/minaskar/pocomc/archive/refs/tags/0.2.3.zip ? The version at 10.5281/zenodo.7306240 contains a lot of temporary files and build products. Thanks!

minaskar commented 1 year ago

@dfm Done, the new DOI is 10.5281/zenodo.7308366

minaskar commented 1 year ago

@dfm DOI is 10.5281/zenodo.7308533 and version number is 0.2.4

dfm commented 1 year ago

@editorialbot set 0.2.4 as version

editorialbot commented 1 year ago

Done! version is now 0.2.4

dfm commented 1 year ago

@editorialbot set 10.5281/zenodo.7308533 as archive

editorialbot commented 1 year ago

Done! Archive is now 10.5281/zenodo.7308533

dfm commented 1 year ago

@editorialbot check references

dfm commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stac2272 is OK
- 10.1146/annurev-astro-082214-122339 is OK
- 10.1214/06-ba127 is OK
- 10.1111/j.1467-9868.2006.00553.x is OK
- 10.1073/pnas.2109420119 is OK
- 10.1073/pnas.2109420119 is OK
- 10.1093/mnras/staa1469 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3702, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stac2272 is OK
- 10.1146/annurev-astro-082214-122339 is OK
- 10.1214/06-ba127 is OK
- 10.1111/j.1467-9868.2006.00553.x is OK
- 10.1073/pnas.2109420119 is OK
- 10.1073/pnas.2109420119 is OK
- 10.1093/mnras/staa1469 is OK

MISSING DOIs

- None

INVALID DOIs

- None

dfm commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

openjournals / joss-reviews

[REVIEW]: pocoMC: A Python package for accelerated Bayesian inference in astronomy and cosmology #4634

Status

Reviewer instructions & questions

Checklists

Review checklist for @kazewong

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @marylou-gabrie

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

A few questions:

Overall comment:

Minor:

Questions/comments related to unchecked items