openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[REVIEW]: POSSA: Power simulation for sequential analyses and multiple hypotheses #4643

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@gasparl<!--end-author-handle-- (Gáspár Lukács) Repository: https://github.com/gasparl/possa/ Branch with paper.md (empty if default branch): Version: v0.6.1 Editor: !--editor-->@fboehm<!--end-editor-- Reviewers: @mingzehuang, @mmrabe Archive: 10.5281/zenodo.7027767

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3018b5213b07c69049bec226949b29f7"><img src="https://joss.theoj.org/papers/3018b5213b07c69049bec226949b29f7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3018b5213b07c69049bec226949b29f7/status.svg)](https://joss.theoj.org/papers/3018b5213b07c69049bec226949b29f7)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mingzehuang & @mmrabe, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fboehm know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @mmrabe

📝 Checklist for @mingzehuang

fboehm commented 2 years ago

@editorialbot recommend-accept

editorialbot commented 2 years ago
Attempting dry run of processing paper acceptance...
editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/ejsp.2023 is OK
- 10.1093/biomet/64.2.191 is OK
- 10.1177/0146167220913363 is OK
- 10.4324/9780203771587 is OK
- 10.5334/irsp.181 is OK
- 10.5964/meth.2811 is OK
- 10.1111/2041-210X.12504 is OK
- 10.1177/2515245920951503 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3483, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

fboehm commented 2 years ago

@gasparl - an editor-in-chief will soon review the submission before accepting it for publication. Monitor this thread to see their comments.

arfon commented 2 years ago

@editorialbot accept

editorialbot commented 2 years ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3485
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04643
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 2 years ago

@mingzehuang, @mmrabe – many thanks for your reviews here and to @fboehm for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@gasparl – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04643/status.svg)](https://doi.org/10.21105/joss.04643)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04643">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04643/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04643/status.svg
   :target: https://doi.org/10.21105/joss.04643

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

gasparl commented 2 years ago

Thanks very much @arfon, and once again to @fboehm as well. Always a pleasure to publish with JOSS.