[REVIEW]: ur-scape: harnessing data for stakeholder participation in city-making processes

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@luyuhao0326@hugoledoux<!--end-editor-- Reviewers: @winstonyym, @cforgaci Archive: 10.3929/ethz-b-000578490

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a26d6189208eb13b4f406922ee875891"><img src="https://joss.theoj.org/papers/a26d6189208eb13b4f406922ee875891/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a26d6189208eb13b4f406922ee875891/status.svg)](https://joss.theoj.org/papers/a26d6189208eb13b4f406922ee875891)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@winstonyym & @cforgaci, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @winstonyym

📝 Checklist for @cforgaci

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/23998083211016122 is OK
- 10.1016/j.compenvurbsys.2022.101825 is OK
- 10.1057/udi.2010.25 is OK
- 10.1038/467912a is OK
- 10.3390/ijgi9010049 is OK
- 10.1007/978-3-319-18368-8_1 is OK
- 10.1111/1475-5661.00062 is OK
- 10.1038/sdata.2017.1 is OK
- 10.1007/978-3-319-08299-8_21 is OK
- 10.2104/ag060022 is OK
- 10.1177/08854122211068526 is OK
- 10.1177/0739456X15581606 is OK
- 10.1038/sdata.2017.4 is OK

MISSING DOIs

- 10.1080/01944360903409493 may be a valid DOI for title: Planning support systems for cities and regions

INVALID DOIs

- 10.1007/978-3-642-37533-0noAccesstrue is INVALID

luyuhao0326 commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/23998083211016122 is OK
- 10.1016/j.compenvurbsys.2022.101825 is OK
- 10.1057/udi.2010.25 is OK
- 10.1038/467912a is OK
- 10.3390/ijgi9010049 is OK
- 10.1007/978-3-319-18368-8_1 is OK
- 10.1111/1475-5661.00062 is OK
- 10.1038/sdata.2017.1 is OK
- 10.1007/978-3-319-08299-8_21 is OK
- 10.2104/ag060022 is OK
- 10.1177/08854122211068526 is OK
- 10.1177/0739456X15581606 is OK
- 10.1038/sdata.2017.4 is OK

MISSING DOIs

- 10.1080/01944360903409493 may be a valid DOI for title: Planning support systems for cities and regions

INVALID DOIs

- 10.1007/978-3-642-37533-0noAccesstrue is INVALID

luyuhao0326 commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/23998083211016122 is OK
- 10.1016/j.compenvurbsys.2022.101825 is OK
- 10.1057/udi.2010.25 is OK
- 10.1038/467912a is OK
- 10.1080/01944360903409493 is OK
- 10.3390/ijgi9010049 is OK
- 10.1007/978-3-642-37533-0 is OK
- 10.1007/978-3-319-18368-8_1 is OK
- 10.1111/1475-5661.00062 is OK
- 10.1038/sdata.2017.1 is OK
- 10.1007/978-3-319-08299-8_21 is OK
- 10.2104/ag060022 is OK
- 10.1177/08854122211068526 is OK
- 10.1177/0739456X15581606 is OK
- 10.1038/sdata.2017.4 is OK

MISSING DOIs

- None

INVALID DOIs

- None

luyuhao0326 commented 1 year ago

@hugoledoux References are now fixed.

hugoledoux commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

hugoledoux commented 1 year ago

@openjournals/sbcs-eics the DOIs have been fixed and thus the formal acceptance can be done. I imagine this doesn't necessitate a new DOI/version since it was just removing the http://doi.org/ from the .bib? If it does, let us know here.

arfon commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3732, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/23998083211016122 is OK
- 10.1016/j.compenvurbsys.2022.101825 is OK
- 10.1057/udi.2010.25 is OK
- 10.1038/467912a is OK
- 10.1080/01944360903409493 is OK
- 10.3390/ijgi9010049 is OK
- 10.1007/978-3-642-37533-0 is OK
- 10.1007/978-3-319-18368-8_1 is OK
- 10.1111/1475-5661.00062 is OK
- 10.1038/sdata.2017.1 is OK
- 10.1007/978-3-319-08299-8_21 is OK
- 10.2104/ag060022 is OK
- 10.1177/08854122211068526 is OK
- 10.1177/0739456X15581606 is OK
- 10.1038/sdata.2017.4 is OK

MISSING DOIs

- None

INVALID DOIs

- None

arfon commented 1 year ago

@luyuhao0326 – I found a few typos in your paper. Could you please merge this PR? https://github.com/UrbanRuralSystems/ur-scape/pull/13

arfon commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3734, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/23998083211016122 is OK
- 10.1016/j.compenvurbsys.2022.101825 is OK
- 10.1057/udi.2010.25 is OK
- 10.1038/467912a is OK
- 10.1080/01944360903409493 is OK
- 10.3390/ijgi9010049 is OK
- 10.1007/978-3-642-37533-0 is OK
- 10.1007/978-3-319-18368-8_1 is OK
- 10.1111/1475-5661.00062 is OK
- 10.1038/sdata.2017.1 is OK
- 10.1007/978-3-319-08299-8_21 is OK
- 10.2104/ag060022 is OK
- 10.1177/08854122211068526 is OK
- 10.1177/0739456X15581606 is OK
- 10.1038/sdata.2017.4 is OK

MISSING DOIs

- None

INVALID DOIs

- None

arfon commented 1 year ago

@luyuhao0326 – apologies but I have one more fix. The references aren't rendering properly and this PR should fix it: https://github.com/UrbanRuralSystems/ur-scape/pull/14

luyuhao0326 commented 1 year ago

@arfon PR merged! And thanks for checking this for us. I should have done this myself first. Overall, this has been a very enjoyable and productive process with JOSS. Look forward to engaging with you, @hugoledoux, and other editors in the coming years.

arfon commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3737, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1177/23998083211016122 is OK
- 10.1016/j.compenvurbsys.2022.101825 is OK
- 10.1057/udi.2010.25 is OK
- 10.1038/467912a is OK
- 10.1080/01944360903409493 is OK
- 10.3390/ijgi9010049 is OK
- 10.1007/978-3-642-37533-0 is OK
- 10.1007/978-3-319-18368-8_1 is OK
- 10.1111/1475-5661.00062 is OK
- 10.1038/sdata.2017.1 is OK
- 10.1007/978-3-319-08299-8_21 is OK
- 10.2104/ag060022 is OK
- 10.1177/08854122211068526 is OK
- 10.1177/0739456X15581606 is OK
- 10.1038/sdata.2017.4 is OK

MISSING DOIs

- None

INVALID DOIs

- None

arfon commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3739
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04664
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 1 year ago

@winstonyym, @cforgaci – many thanks for your reviews here and to @hugoledoux for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@luyuhao0326 – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04664/status.svg)](https://doi.org/10.21105/joss.04664)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04664">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04664/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04664/status.svg
   :target: https://doi.org/10.21105/joss.04664

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews