[REVIEW]: PoUnce: A framework for automatized uncertainty quantification simulations on high-performance clusters

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@JakobBD@Nikoleta-v3<!--end-editor-- Reviewers: @georgiastuart, @salrm8 Archive: 10.5281/zenodo.7600634

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c62521adac904e832a1ac4130406f80f"><img src="https://joss.theoj.org/papers/c62521adac904e832a1ac4130406f80f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c62521adac904e832a1ac4130406f80f/status.svg)](https://joss.theoj.org/papers/c62521adac904e832a1ac4130406f80f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@georgiastuart & @salrm8, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Nikoleta-v3 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @georgiastuart

📝 Checklist for @salrm8

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1287/opre.1070.0496 is OK
- 10.1007/3-540-45346-6_5 is OK
- 10.1137/16M1082469 is OK
- 10.1137/15M1046472 is OK
- 10.2172/1177077 is OK
- 10.1016/j.jocs.2020.101204 is OK
- 10.1137/S1064827503427741 is OK
- 10.1016/j.jocs.2015.08.008 is OK
- 10.21105/joss.02871 is OK
- 10.1061/9780784413609.257 is OK
- 10.1142/S2591728518500445 is OK
- 10.5281/zenodo.16303 is OK
- 10.5281/zenodo.21389 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3938, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 1 year ago

👋 @xuanxu - can you take a look at the proof, and specifically, the final reference. Note that the journal title starts with a ";", which is unusual, and there seems to be a space missing between the paper title and the journal title, perhaps because of the journal title starting with a special character?

It seems like this might be a bug somewhere in our pandoc/bibtex processing code - what do you think?

xuanxu commented 1 year ago

Yes, looks like a format problem... invoking @tarleb

danielskatz commented 1 year ago

👋 @tarleb - any news on this?

tarleb commented 1 year ago

Sorry, I was out for some weeks and slowly working through the backlog. Taking a look now.

tarleb commented 1 year ago

Thanks for the patience. I tried to debug this, but the only thing I can state for certain is that this is somehow due to our citation style (APA). Some styles like chicago-author-date do not have this problem, while the nature style keeps the period but drops the space.

I'll will keep digging, but for now I'd recommend this workaround:

  journal = {{\tt ;login:} The USENIX Magazine},

This is a hack which does two things: First, the initial character in the journal name above is an invisible ZERO WIDTH SPACE. This ensures that the journal name does not start with punctuation, so the article title gets properly terminated with a period. Second, we mark the string ;login: as code, which prevents unwanted capitalization to ;Login:; this seems in line with how the journal title is styled on the cover.

danielskatz commented 1 year ago

@JakobBD - if you can make this change, we'll try the processing again.

JakobBD commented 1 year ago

Done!

danielskatz commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1287/opre.1070.0496 is OK
- 10.1007/3-540-45346-6_5 is OK
- 10.1137/16M1082469 is OK
- 10.1137/15M1046472 is OK
- 10.2172/1177077 is OK
- 10.1016/j.jocs.2020.101204 is OK
- 10.1137/S1064827503427741 is OK
- 10.1016/j.jocs.2015.08.008 is OK
- 10.21105/joss.02871 is OK
- 10.1061/9780784413609.257 is OK
- 10.1142/S2591728518500445 is OK
- 10.5281/zenodo.16303 is OK
- 10.5281/zenodo.21389 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3968, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 1 year ago

👋 @tarleb - This doesn't seem to have worked - the space between the paper title and the ";" in the journal name is still not there.

tarleb commented 1 year ago

The hack wasn't applied in full, the ZERO WIDTH SPACE is missing. I'll open a PR.

Edit: PR JakobBD/pounce#2

tarleb commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3972
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04683
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 1 year ago

Congratulations to @JakobBD (Jakob Dürrwächter) and co-authors!

And thanks to @georgiastuart and @salrm8 for reviewing, and to @Nikoleta-v3 for editing! We couldn't do this without you.

Thanks also to @tarleb and @xuanxu for help with one odd bug

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04683/status.svg)](https://doi.org/10.21105/joss.04683)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04683">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04683/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04683/status.svg
   :target: https://doi.org/10.21105/joss.04683

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews