openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: Scientific Computational Imaging Code (SCICO) #4690

Closed editorialbot closed 2 years ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@bwohlberg<!--end-author-handle-- (Brendt Wohlberg) Repository: https://github.com/lanl/scico Branch with paper.md (empty if default branch): joss-paper Version: v0.0.2 Editor: !--editor-->@danielskatz<!--end-editor-- Reviewers: @vitorsr, @DanNixon, @lucaferranti Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9c65b12d2b4be53b25a01943484cff22"><img src="https://joss.theoj.org/papers/9c65b12d2b4be53b25a01943484cff22/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9c65b12d2b4be53b25a01943484cff22/status.svg)](https://joss.theoj.org/papers/9c65b12d2b4be53b25a01943484cff22)

Author instructions

Thanks for submitting your paper to JOSS @bwohlberg. Currently, there isn't a JOSS editor assigned to your paper.

@bwohlberg if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.39 s (468.8 files/s, 81283.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         133           4946           6265          14317
reStructuredText                24           1028            450           1833
TeX                              2             67              0            789
Bourne Shell                     7             82             69            402
SVG                              1              0              0            396
YAML                            11             45             75            374
Markdown                         1            113              0            238
make                             2             29              6            151
CSS                              1             50             10            130
TOML                             1              3              1             31
INI                              1              0              0              5
-------------------------------------------------------------------------------
SUM:                           184           6363           6876          18666
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 3328

editorialbot commented 2 years ago

:warning: An error happened when generating the pdf.

arfon commented 2 years ago

@bwohlberg – please fix the whitespace in your paper to match our example – YAML is whitespace sensitive.

Screenshot 2022-08-20 at 08 32 45

Also, I'm not sure that adding those extra packages in the header-includes section will work here, but we can try :-)

bwohlberg commented 2 years ago

@bwohlberg – please fix the whitespace in your paper to match our example – YAML is whitespace sensitive.

Sorry about that. We fixed the header a while back, but somehow the bad indentation seems to have made its way back in. It's fixed now.

Also, I'm not sure that adding those extra packages in the header-includes section will work here, but we can try :-)

It worked when we built the paper in the joss github workflow or using the docker image.

bwohlberg commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:warning: An error happened when generating the pdf.

bwohlberg commented 2 years ago

@arfon: As requested, a list of suggested reviewers:

jwbuurlage mh-skjelvareid alberto-battistel vitorsr DanNixon grlee77 lheagy

bwohlberg commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:warning: An error happened when generating the pdf.

bwohlberg commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 2 years ago

@bwohlberg – thanks for fixing up the paper. While we look for an editor to pick up this submission could you please take a look at substantially reducing the size of your paper please? As a guideline, JOSS papers should be between 250 -- 1000 words (yours is upwards of 3000 currently).

danielskatz commented 2 years ago

@bwohlberg - I'll edit this submission. Please let me know when you have reduced the size of the paper, then we can get started

danielskatz commented 2 years ago

@editorialbot assign me as editor

editorialbot commented 2 years ago

Assigned! @danielskatz is now the editor

bwohlberg commented 2 years ago

@arfon: Would you please consider granting an exception on the word count guideline?

We've put considerable effort into writing what we believe is a coherent overview of the purpose and features of the package described by the paper. The "additional" detail addresses the high-level design and usage of the package, and does not involve the sort of API-level details that clearly belong in the project documentation. Cutting it by a factor of three would turn it into a completely different document, and involve removal of a great deal of valuable content.

danielskatz commented 2 years ago

We (I and @arfon) think this paper needs to be reduced in size. JOSS papers are meant to stand in for the software, not completely document it. Specifically, I suggest that the section "Solving Imaging Inverse Problems in SCICO" could be dramatically reduced, with most of the existing content of this section being moved to a webpage that the shortened section could point to for more details.

While I sympathize with the effort you've put into writing this, the JOSS guidance is quite clear about what a JOSS paper should (and should not) include, and has been in place for years, so I think moving this content to the software repo outside of the paper is the best way to not waste this effort and still meet the JOSS requirements.

We can be somewhat loose in terms of the 1000-word maximum for a paper, but this paper far exceeds that limit and does need to be reduced to get much closer to it.

bwohlberg commented 2 years ago

Understood. We'll cut it down to the brief abstract-like document that is expected. We had been thinking of JOSS as an alternative venue for the sort of papers that are published in the SciPy Proceedings.

danielskatz commented 2 years ago

If you want to publish a long paper about the software, you might want to consider options in https://www.software.ac.uk/which-journals-should-i-publish-my-software

bwohlberg commented 2 years ago

Thanks for the suggestion. We already looked there, but none of the other options are ideal. Some of the most promising looking ones seem to be defunct, and the remaining ones that might be suitable for the type of software presented in this paper are run by publishing companies with a poor reputation in terms of open science.

danielskatz commented 2 years ago

We are happy to have your submission, but I did want to offer alternatives. Did you consider JORS? That might meet your needs, though the review process can be somewhat slow

bwohlberg commented 2 years ago

JORS was one of the more promising ones I looked at, but my impression from their template for software description papers is that they also expect something much shorter than our paper. But if you think I'm being overly pessimistic, perhaps it's worth asking them for clarification.

As a matter of interest, why the strict length constraint for JOSS? I'm sure many other authors would also be interested in a venue for more SciPy-like papers.

bwohlberg commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

bwohlberg commented 2 years ago

@editorialbot commands

editorialbot commented 2 years ago

Hello @bwohlberg, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Get a link to the complete list of reviewers
@editorialbot list reviewers
bwohlberg commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:warning: An error happened when generating the pdf.

bwohlberg commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 2 years ago

You can certainly write to JORS. The reason for the length limit on JOSS papers is that we want to focus on the software, which ideally would be reviewed and published as is, along with documentation. However, the current scholarly publishing system basically requires papers, so we wanted to create a way that authors could do a little extra work on top of their software to get credit in the current system. See the developer friendly heading in https://joss.theoj.org/about and https://www.arfon.org/announcing-the-journal-of-open-source-software

danielskatz commented 2 years ago

Do you want to proceed with the review of the software and your shortened paper?

bwohlberg commented 2 years ago

Yes, please. We may consider publishing a much longer paper in the future, but that would be a completely independent document.

danielskatz commented 2 years ago

👋 @jwbuurlage - Are you able to review this JOSS submission?

danielskatz commented 2 years ago

👋 @mh-skjelvareid - Are you able to review this JOSS submission?

danielskatz commented 2 years ago

👋 @alberto-battistel - Are you able to review this JOSS submission?

danielskatz commented 2 years ago

👋 @vitorsr - Are you able to review this JOSS submission?

mh-skjelvareid commented 2 years ago

👋 @mh-skjelvareid - Are you able to review this JOSS submission?

@danielskatz I'm very sorry, but I don't currently have time to review this submission.

vitorsr commented 2 years ago

👋 @vitorsr - Are you able to review this JOSS submission?

I would be happy to.

danielskatz commented 2 years ago

Thanks @vitorsr - I'll assign you, but we won't start the review until we find one more reviewer.

danielskatz commented 2 years ago

@editorialbot add @vitorsr as reviewer

editorialbot commented 2 years ago

@vitorsr added to the reviewers list!

danielskatz commented 2 years ago

👋 @DanNixon - Are you able to review this JOSS submission?

danielskatz commented 2 years ago

👋 @grlee77 - Are you able to review this JOSS submission?

danielskatz commented 2 years ago

👋 @lheagy - Are you able to review this JOSS submission?

vitorsr commented 2 years ago

Thanks @vitorsr - I'll assign you, but we won't start the review until we find one more reviewer.

Thanks for assigning me. If you wouldn't mind my suggesting, I find it would be best if we had more than two reviewers for this submission given the size of the project.

danielskatz commented 2 years ago

We can try... Do you have any thoughts of any complementary reviewers we should ask?

DanNixon commented 2 years ago

wave @DanNixon - Are you able to review this JOSS submission?

I'm happy to.