openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: riversCentralAsia: An R package for hydrological modelling #4695

Closed editorialbot closed 1 year ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@mabesa<!--end-author-handle-- (Beatrice Marti) Repository: https://github.com/hydrosolutions/riversCentralAsia/ Branch with paper.md (empty if default branch): paper Version: v1.1.0 Editor: !--editor-->@crvernon<!--end-editor-- Reviewers: @mengqi-z, @tonyewong Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2d590dd5b3a8cfa397f4079e79844c3f"><img src="https://joss.theoj.org/papers/2d590dd5b3a8cfa397f4079e79844c3f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2d590dd5b3a8cfa397f4079e79844c3f/status.svg)](https://joss.theoj.org/papers/2d590dd5b3a8cfa397f4079e79844c3f)

Author instructions

Thanks for submitting your paper to JOSS @mabesa. Currently, there isn't a JOSS editor assigned to your paper.

@mabesa if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago

Couldn't check the bibtex because branch name is incorrect: https://github.com/hydrosolutions/riversCentralAsia/tree/paper

editorialbot commented 2 years ago

Couldn't check the bibtex because branch name is incorrect: https://github.com/hydrosolutions/riversCentralAsia/tree/paper

editorialbot commented 2 years ago

:warning: An error happened when generating the pdf.

arfon commented 2 years ago

@editorialbot set paper as branch

editorialbot commented 2 years ago

Done! branch is now paper

arfon commented 2 years ago

@editorialbot check repository

editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.25 s (721.3 files/s, 162639.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      16           3226           2940          12182
HTML                            65           2062            205           7872
TeX                              3            289              0           3640
R                               64            421           1109           2340
Markdown                         9            399              0           1122
XML                              5              0              0            956
CSS                              6             60             37            627
Rmd                              6            229            320            394
Sass                             1              4              0             71
YAML                             3              3              4             61
SVG                              1              0              1             11
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                           180           6693           4616          29277
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 615

editorialbot commented 2 years ago

Failed to discover a valid open source license

arfon commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mabesa commented 2 years ago

Hi, thanks for editing! Here is a list of suitable candidates from the joss_reviewer list: tonyewong, kharos, thodson-usgs, babakmohammadi, MoLi7, kauedesousa, Nasrinattar26, jkpierce/, mikemahoney218, alessandroamaranto, mps9506, puruckertom, dm807cam, wincowgerDEV, richardsc, jmp75, crvernon, zgxn, arbennett, mikejohnson51.

arfon commented 2 years ago

@editorialbot invite @crvernon as editor

πŸ‘‹ @crvernon – would you be willing to edit this submission for JOSS?

editorialbot commented 2 years ago

Invitation to edit this submission sent!

crvernon commented 2 years ago

@editorialbot assign @crvernon as editor

Happy to help!

editorialbot commented 2 years ago

Assigned! @crvernon is now the editor

crvernon commented 2 years ago

:wave: @mabesa - - I'll be your topic editor for this submission.

The first step in this pre-review is to find at least 2 reviewers. I see you have provided a list of reviewers already πŸ™ . I'll get started with some invites to review.

crvernon commented 2 years ago

πŸ‘‹ - @MoLi7 Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

crvernon commented 2 years ago

:wave: - @mengqi-z Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

mengqi-z commented 2 years ago

Hi @crvernon, thank you for the invitation. Yes, I am happy to review this paper.

crvernon commented 2 years ago

@editorialbot add @mengqi-z as reviewer

editorialbot commented 2 years ago

@mengqi-z added to the reviewers list!

crvernon commented 1 year ago

πŸ‘‹ - @tonyewong Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

tonyewong commented 1 year ago

Hello, and thanks for the invitation!

I'd be happy to help... with the caveat that I'm traveling for the next 2 weeks so during that time my access to email (edit: and internet/work time in general) may be a bit sporadic. If that's no problem, then please feel free to add me to the reviewers list!

crvernon commented 1 year ago

@tonyewong that is A-OK. I'll go ahead and add you and get this review kicked off.

crvernon commented 1 year ago

πŸ‘‹ - Alright @mabesa , @mengqi-z , and @tonyewong I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

crvernon commented 1 year ago

@editorialbot add @tonyewong as reviewer

editorialbot commented 1 year ago

@tonyewong added to the reviewers list!

crvernon commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4805.