[REVIEW]: Choco-solver: A Java library for constraint programming

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@cprudhom@jbytecode<!--end-editor-- Reviewers: @skadio, @ozgurakgun Archive: 10.5281/zenodo.7185962

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c4e6329e6ef023c0b856ad6722ec8e34"><img src="https://joss.theoj.org/papers/c4e6329e6ef023c0b856ad6722ec8e34/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c4e6329e6ef023c0b856ad6722ec8e34/status.svg)](https://joss.theoj.org/papers/c4e6329e6ef023c0b856ad6722ec8e34)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@skadio & @ozgurakgun, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @skadio

📝 Checklist for @ozgurakgun

jbytecode commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 1 year ago

Dear @cprudhom,

[X] The paper seems improved now. Thank you for applying the corrections.
[ ] Please read the paper pdf carefully, one more time, correct any issue if exists. Please perform a full grammar check.
[ ] Create a tagged release in the software repository. Report the version here. The version should be in form of vx.y.z, e.g. v1.2.3.
[ ] Create a Zenodo archive of the repository in https://zenodo.org/
[ ] The Zenodo archive (with the same name/title with the JOSS paper) should have the correct metadata, e.g. author names, ORCIDs, the title of the archive. Please set the archive title as the paper title.
[ ] Please provide the tagged release id, zenodo archive DOI, and Zenodo archive URL here.

Thank you in advance.

jbytecode commented 1 year ago

@cprudhom - please also check the lines 88,89,90: The list is not rendered properly.

Edit: The PR (https://github.com/chocoteam/choco-solver/pull/944) solves this.

jbytecode commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

cprudhom commented 1 year ago

I have just made some syntax adjustments

cprudhom commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

cprudhom commented 1 year ago

@jbytecode

Create a tagged release in the software repository ... The version should be in form of vx.y.z, e.g. v1.2.3.

Our release versioning system is based on Maven and does not show the v. Is this necessary?

jbytecode commented 1 year ago

@cprudhom - please create a tagged release in github and use this information in zenodo. this tagged release will be registered snapshot of the review.

cprudhom commented 1 year ago

@jbytecode

I believe everything is ready:

tagged release : v4.10.10
Zenodo archive DOI : 10.5281/zenodo.7185962
Zenodo archive URL : https://zenodo.org/record/7185962#.Y0WCVuxBxjw

jbytecode commented 1 year ago

@editorialbot set v4.10.10 as version

editorialbot commented 1 year ago

Done! version is now v4.10.10

jbytecode commented 1 year ago

@cprudhom - It seems the ORCID of the co-author is missing in the paper. Please merge the pull request: https://github.com/chocoteam/choco-solver/pull/947

jbytecode commented 1 year ago

@editorialbot set 10.5281/zenodo.7185962 as archive

editorialbot commented 1 year ago

Done! Archive is now 10.5281/zenodo.7185962

cprudhom commented 1 year ago

@cprudhom - It seems the ORCID of the co-author is missing in the paper. Please merge the pull request: chocoteam/choco-solver#947

Right, thank you. Does it require a new release?

jbytecode commented 1 year ago

@editorialbot generate pdf

@cprudhom - no, the release and archive is okay.

I am re-generating the pdf, please have a proof read and ping me again.

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

cprudhom commented 1 year ago

@jbytecode I think the sub-section Applications is useless. I can fix that if you want, otherwise, I'm ok with the article

jbytecode commented 1 year ago

@cprudhom - the review has been completed so it is usual to go on with the typo and language corrections. I am now recommending an accept. Thank you for your edits.

@skadio, @ozgurakgun - Thank you so much again, for your great effort and consuming your time for the JOSS review, hope to work on future projects.

The final decision will be made by one of our editor-in-chiefs.

jbytecode commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3610, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/0004-3702(80)90051-X is OK
- 10.1016/0895-7177(93)90068-A is OK
- 10.1007/BF00137870 is OK
- 10.1007/3-540-49481-2_30 is OK
- 10.1007/11564751_71 is OK
- 10.1007/11564751_18 is OK
- 10.1007/11493853_7 is OK
- 10.1145/1452044.1452046 is OK
- 10.1007/978-3-642-04244-7_54 is OK
- 10.1007/s10601-014-9166-6 is OK
- 10.1007/s10601-013-9151-5 is OK
- 10.1007/978-3-642-29828-8_15 is OK
- 10.1007/978-3-540-30201-8_41 is OK
- 10.1109/TCIAIG.2011.2159716 is OK
- 10.29007/b4dz is OK
- 10.1007/s10601-015-9223-9 is OK
- 10.1007/978-3-319-23219-5_2 is OK
- 10.1109/ictai.2017.00164 is OK
- 10.1109/ICTAI.2019.00019 is OK
- 10.4230/LIPIcs.CP.2021.9 is OK
- 10.1016/j.simpa.2021.100085 is OK
- 10.1007/978-3-030-78375-4_8 is OK
- 10.1007/978-3-319-44953-1_40 is OK
- 10.1109/SCC.2019.00017 is OK
- 10.1016/j.eswa.2021.116149 is OK
- 10.1007/s10601-021-09324-7 is OK
- 10.1007/978-3-031-08011-1_21 is OK

MISSING DOIs

- None

INVALID DOIs

- None

jbytecode commented 1 year ago

@cprudhom - the orchid part is updated, please apply the PR

jbytecode commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 1 year ago

@cprudhom - interestingly the orchid is not shown properly, could you please solve this?

cprudhom commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 1 year ago

@editorialbot recommend-accept

@cprudhom - thanks!

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3611, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/0004-3702(80)90051-X is OK
- 10.1016/0895-7177(93)90068-A is OK
- 10.1007/BF00137870 is OK
- 10.1007/3-540-49481-2_30 is OK
- 10.1007/11564751_71 is OK
- 10.1007/11564751_18 is OK
- 10.1007/11493853_7 is OK
- 10.1145/1452044.1452046 is OK
- 10.1007/978-3-642-04244-7_54 is OK
- 10.1007/s10601-014-9166-6 is OK
- 10.1007/s10601-013-9151-5 is OK
- 10.1007/978-3-642-29828-8_15 is OK
- 10.1007/978-3-540-30201-8_41 is OK
- 10.1109/TCIAIG.2011.2159716 is OK
- 10.29007/b4dz is OK
- 10.1007/s10601-015-9223-9 is OK
- 10.1007/978-3-319-23219-5_2 is OK
- 10.1109/ictai.2017.00164 is OK
- 10.1109/ICTAI.2019.00019 is OK
- 10.4230/LIPIcs.CP.2021.9 is OK
- 10.1016/j.simpa.2021.100085 is OK
- 10.1007/978-3-030-78375-4_8 is OK
- 10.1007/978-3-319-44953-1_40 is OK
- 10.1109/SCC.2019.00017 is OK
- 10.1016/j.eswa.2021.116149 is OK
- 10.1007/s10601-021-09324-7 is OK
- 10.1007/978-3-031-08011-1_21 is OK

MISSING DOIs

- None

INVALID DOIs

- None

kthyng commented 1 year ago

Everything looks good!

kthyng commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3612
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04708
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 1 year ago

Congratulations on your new publication to @cprudhomand! Many thanks to editor @jbytecode and reviewers @skadio and @ozgurakgun for your time, hard work, and expertise!!

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04708/status.svg)](https://doi.org/10.21105/joss.04708)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04708">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04708/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04708/status.svg
   :target: https://doi.org/10.21105/joss.04708

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

skadio commented 1 year ago

Thank you all, especially to our editors @kthyng and @jbytecode for holding our hand throughout!

Congratulations @cprudhom

cprudhom commented 1 year ago

Thank you @ozgurakgun and @skadio for your reviews and @jbytecode for your help.

cprudhom commented 1 year ago

I have a last question. When I look at the page that hosts the article, I see some the following tags: ANTLR and R. Can these tags be changed to more relevant ones ? Thank you

cprudhom commented 1 year ago

Thank you @jbytecode Do you know whether such a procedure is possible on https://joss.theoj.org/papers/10.21105/joss.04708 too?

jbytecode commented 1 year ago

maybe @xuanxu can help you about this issue.

cprudhom commented 1 year ago

@xuanxu Do I need to open a specific issue for the tag problem?

xuanxu commented 1 year ago

@xuanxu Do I need to open a specific issue for the tag problem?

No need, I'm going to take a look at how to best update that metadata

openjournals / joss-reviews