[REVIEW]: **geostan**: An R package for Bayesian spatial analysis

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@ConnorDonegan@jbytecode<!--end-editor-- Reviewers: @wcjochem, @becarioprecario Archive: 10.5281/zenodo.7311716

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b"><img src="https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b/status.svg)](https://joss.theoj.org/papers/8505b8bf1923490258ef23a1eea6138b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@wcjochem & @becarioprecario, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @becarioprecario

📝 Checklist for @wcjochem

jbytecode commented 1 year ago

@ConnorDonegan - the item

Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

belongs to the documentation rather than the software paper, I think the most suitable place to host them is the repository - not the paper. @wcjochem makes the final decision, of course.

ConnorDonegan commented 1 year ago

I would not object to that, @jbytecode. I've also added this to the README for the github repo and to the main website.

The website/readme now has this:

Support

All functions and methods are documented (with examples) on the website reference page. See the package vignettes for more on exploratory spatial data analysis and spatial modeling.

To ask questions, report a bug, or discuss ideas for improvements or new features please visit the Issues page, start a discussion, or submit a pull request.

wcjochem commented 1 year ago

Thanks @ConnorDonegan for these revisions. I agree with @jbytecode the contributing guidelines are most appropriate in the README/website. I think you have addressed all my issues, so I'm happy to complete my review now. Thanks!

jbytecode commented 1 year ago

Since our reviewers have completed their reviews I can start my editorial tasks.

jbytecode commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.1093/biomet/10.1.179 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1111/gean.12215 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.1111/rssa.12378 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1111/j.1467-9868.2008.00700.x is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- 10.2139/ssrn.2420725 may be a valid DOI for title: What regional scientists need to know about spatial econometrics

INVALID DOIs

- None

jbytecode commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ConnorDonegan commented 1 year ago

@jbytecode I've now updated the paper.md and pdf file to no longer include the section on user support.

@editorialbot generate pdf

jbytecode commented 1 year ago

@editorialbot check references

jbytecode commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 1 year ago

@ConnorDonegan - I have just sent a pull request that includes some corrections/additions to the manuscript and bibtex. Please review the changes and apply them if you are agreed with them. Thank you in advance.

jbytecode commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.1093/biomet/10.1.179 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1111/gean.12215 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.1111/rssa.12378 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1111/j.1467-9868.2008.00700.x is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- 10.2139/ssrn.2420725 may be a valid DOI for title: What regional scientists need to know about spatial econometrics

INVALID DOIs

- None

jbytecode commented 1 year ago

@ConnorDonegan - could you please fix the missing DOI issue as the editorialbot suggested?

ConnorDonegan commented 1 year ago

The journal article has been listed on site called SSRN, and it has a DOI. However, the journal article itself has no DOI associated with the 'real' publication. So this one will be missing a doi, unless you prefer I add the SSRN doi

jbytecode commented 1 year ago

@ConnorDonegan - I have performed a DOI search using this site and it redirects to the page. So, it is okay, imo.

ConnorDonegan commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ConnorDonegan commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.1093/biomet/10.1.179 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1111/gean.12215 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.2139/ssrn.2420725 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.1111/rssa.12378 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1111/j.1467-9868.2008.00700.x is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

jbytecode commented 1 year ago

Dear @ConnorDonegan

[x] I've just sent a PR for a small typo issue in the bibtex, please apply it.
[x] Please read the paper pdf carefully, one more time, correct any issue if exists. Please perform a full grammar check.
[x] Create a tagged release in the software repository. Report the version here. The version should be in form of vx.y.z, e.g. v1.2.3.
[x] Create a Zenodo archive of the repository in https://zenodo.org/
[x] The Zenodo archive (with the same name/title with the JOSS paper) should have the correct metadata, e.g. author names, ORCIDs, the title of the archive. Please set the archive title as the paper title.
[x] Please provide the tagged release id, zenodo archive DOI, and Zenodo archive URL here.

Thank you in advance.

ConnorDonegan commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ConnorDonegan commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 1 year ago

@ConnorDonegan - The manuscript now looks fine.

ConnorDonegan commented 1 year ago

I tagged a new release in the geostan repository: v0.4.1

jbytecode commented 1 year ago

@editorialbot set v0.4.1 as version

editorialbot commented 1 year ago

Done! version is now v0.4.1

ConnorDonegan commented 1 year ago

zenodo url: https://zenodo.org/record/7311716

zenodo doi: 10.5281/zenodo.7311716.svg

jbytecode commented 1 year ago

@editorialbot set 10.5281/zenodo.7311716 as archive

editorialbot commented 1 year ago

Done! Archive is now 10.5281/zenodo.7311716

jbytecode commented 1 year ago

@ConnorDonegan - Thank you. I am now recommending an acceptance. The final decision will be made by one of our editor-in-chiefs. Congratulations!

jbytecode commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

ConnorDonegan commented 1 year ago

Thanks @jbytecode, @wcjochem and @jbytecode for a smooth and productive editorial experience.

editorialbot commented 1 year ago

:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.

ID tblU003Amodels already defined

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.1093/biomet/10.1.179 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1111/gean.12215 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.2139/ssrn.2420725 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.1111/rssa.12378 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1111/j.1467-9868.2008.00700.x is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

jbytecode commented 1 year ago

@openjournals/dev - I need your help, thank you in advance!

tarleb commented 1 year ago

This looks like a pandoc bug. As a workaround, the \label should be moved directly below the \caption of the table.

jbytecode commented 1 year ago

@ConnorDonegan - could you please help changing the markdown as suggested?

jbytecode commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3717, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/3ey65 is OK
- 10.1016/j.spasta.2020.100450 is OK
- 10.3390/ijerph18136856 is OK
- 10.1093/biomet/10.1.179 is OK
- 10.2307/2532039 is OK
- 10.1111/j.1467-8306.2005.00484.x is OK
- 10.1016/C2017-0-01015-7 is OK
- 10.1111/j.1538-4632.2007.00708.x is OK
- 10.1016/j.apgeog.2013.08.013 is OK
- 10.1007/s13524-016-0499-1 is OK
- 10.1111/gean.12215 is OK
- 10.1016/j.csda.2008.07.033 is OK
- 10.1002/(sici)1097-0258(19970415)16:7<741::aid-sim501>3.0.co;2-1 is OK
- 10.1002/(sici)1097-0258(19980930)17:18<2025::aid-sim865>3.0.co;2-m is OK
- 10.1111/j.2517-6161.1974.tb00999.x is OK
- 10.1007/BF00116466 is OK
- 10.1177/0962280216660421 is OK
- 10.2139/ssrn.2420725 is OK
- 10.1016/j.sste.2019.100301 is OK
- 10.1111/rssa.12378 is OK
- 10.18637/jss.v063.i18 is OK
- 10.1111/j.1467-9868.2008.00700.x is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.5281/zenodo.1308151 is OK
- 10.18637/jss.v092.i10 is OK
- 10.1214/17-BA1091 is OK
- 10.1111/j.1538-4632.1995.tb00338.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

arfon commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

openjournals / joss-reviews