openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
701 stars 36 forks source link

[PRE REVIEW]: simcardems: A FEniCS-based cardiac electro-mechanics solver #4745

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@finsberg<!--end-author-handle-- (Henrik Nicolay Topnes Finsberg) Repository: https://github.com/ComputationalPhysiology/simcardems Branch with paper.md (empty if default branch): master Version: v2022.3.0 Editor: !--editor-->@AoifeHughes<!--end-editor-- Reviewers: @mbarzegary, @sdelandtsheer Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/28986461c27b8a76c8ac5a43dc57e8dc"><img src="https://joss.theoj.org/papers/28986461c27b8a76c8ac5a43dc57e8dc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/28986461c27b8a76c8ac5a43dc57e8dc/status.svg)](https://joss.theoj.org/papers/28986461c27b8a76c8ac5a43dc57e8dc)

Author instructions

Thanks for submitting your paper to JOSS @finsberg. Currently, there isn't a JOSS editor assigned to your paper.

@finsberg if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (815.7 files/s, 122101.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          36           1100            573           5870
Markdown                        13            472              0           1527
YAML                             5             33              5            182
TeX                              2             11              0            120
make                             3             34              7             95
JSON                             5              0              0             47
reStructuredText                 3             27             28             37
Dockerfile                       1              3              1              7
-------------------------------------------------------------------------------
SUM:                            68           1680            614           7885
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 509

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01848 is OK

MISSING DOIs

- 10.21105/joss.01539 may be a valid DOI for title: pulse: A python package based on FEniCS for solving problems in cardiac mechanics
- 10.21105/joss.00224 may be a valid DOI for title: cbcbeat: an adjoint-enabled framework for computational cardiac electrophysiology
- 10.3389/fphys.2018.01431 may be a valid DOI for title: GEMS: A fully integrated PETSc-based solver for coupled cardiac electromechanics and bidomain simulations
- 10.1016/j.yjmcc.2017.03.008 may be a valid DOI for title: A model of cardiac contraction based on novel measurements of tension development in human cardiomyocytes

INVALID DOIs

- None
finsberg commented 1 year ago

@whedon check references

editorialbot commented 1 year ago

My name is now @editorialbot

finsberg commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01539 is OK
- 10.21105/joss.00224 is OK
- 10.3389/fphys.2018.01431 is OK
- 10.21105/joss.01848 is OK
- 10.1016/j.yjmcc.2017.03.008 is OK

MISSING DOIs

- None

INVALID DOIs

- None
finsberg commented 1 year ago

cmorris2945 mbarzegary storyetfall sdelandtsheer

kthyng commented 1 year ago

Hi @AoifeHughes! Is this anywhere near your area of expertise?

kthyng commented 1 year ago

@editorialbot invite @AoifeHughes as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

AoifeHughes commented 1 year ago

Sure, I'd be glad to handle as editor!

kthyng commented 1 year ago

@editorialbot assign @AoifeHughes as editor

editorialbot commented 1 year ago

Assigned! @AoifeHughes is now the editor

AoifeHughes commented 1 year ago

Hi @cmorris2945, @mbarzegary, @storyetfall, @sdelandtsheer, as per the submitting author's suggestions would any of you like to / feel able to review this?

cmorris2945 commented 1 year ago

Sorry, what's the issue here? I don't know what a "DOI" is? This has to do with something about tagging electro-cardiac data or something?

mbarzegary commented 1 year ago

hi, sure, will be a pleasure to help reviewing this submission.

cmorris2945 commented 1 year ago

Ok, what's the submission about?

finsberg commented 1 year ago

Ok, what's the submission about?

@cmorris2945 You can read more about the submission here: https://github.com/ComputationalPhysiology/simcardems but in short it is a library for performing cardiac electro-mechanics simulations

sdelandtsheer commented 1 year ago

Sure, I have time to review this submission later this week

AoifeHughes commented 1 year ago

@editorialbot add @mbarzegary as reviewer

editorialbot commented 1 year ago

@mbarzegary added to the reviewers list!

AoifeHughes commented 1 year ago

@editorialbot add @sdelandtsheer as reviewer

editorialbot commented 1 year ago

@sdelandtsheer added to the reviewers list!

AoifeHughes commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4753.

AoifeHughes commented 1 year ago

Fantastic @mbarzegary and @sdelandtsheer thanks for agreeing! We can get this show on the road :)

cmorris2945 commented 1 year ago

Ok, what's the submission about?

@cmorris2945 You can read more about the submission here: https://github.com/ComputationalPhysiology/simcardems but in short it is a library for performing cardiac electro-mechanics simulations

Ok, what's the submission about?

@cmorris2945 You can read more about the submission here: https://github.com/ComputationalPhysiology/simcardems but in short it is a library for performing cardiac electro-mechanics simulations

ok thanks

kthyng commented 1 year ago

@cmorris2945 Sorry there must have been some confusion with the text in this issue — DOI is about references in the paper associated with this submission (Digital Object Identifier), not about the submission software itself. Looks like the submission has two reviewers so the review has begun, but thank you for your interest!