openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
696 stars 36 forks source link

[PRE REVIEW]: Software Design and User Interface of ESPnet-SE++: Speech Enhancement for Robust Speech Processing #4746

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@neillu23<!--end-author-handle-- (Yen-Ju Lu) Repository: https://github.com/espnet/espnet Branch with paper.md (empty if default branch): Version: v.202207 Editor: !--editor-->@faroit<!--end-editor-- Reviewers: @joimort, @justusschock Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f518d0b78a29ab6521936834e5d90ef1"><img src="https://joss.theoj.org/papers/f518d0b78a29ab6521936834e5d90ef1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f518d0b78a29ab6521936834e5d90ef1/status.svg)](https://joss.theoj.org/papers/f518d0b78a29ab6521936834e5d90ef1)

Author instructions

Thanks for submitting your paper to JOSS @neillu23. Currently, there isn't a JOSS editor assigned to your paper.

@neillu23 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=3.31 s (972.8 files/s, 111238.3 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                         1007          25350          26885         130838
Bourne Shell                    964          17053          12389          79472
YAML                            907           3338           4936          32481
Markdown                        241           5145              0          20076
Perl                             56            589           1062           3412
MATLAB                           14            415            490           1691
diff                             12             49            392           1068
make                              2             49             17            188
CMake                             1             40             39            169
TeX                               1             22              0            156
Bourne Again Shell                5             24              6             73
Cython                            1             10              3             36
DOS Batch                         1              8              1             27
reStructuredText                  5             26             37             20
JSON                              2              0              0              2
--------------------------------------------------------------------------------
SUM:                           3219          52118          46257         269709
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 3712

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 1 year ago

Hi @neillu23! Your paper is too long. Please read the docs for details about how to write your paper.

kthyng commented 1 year ago

@neillu23 Our relevant editors are busy at the moment so I'll add this submission to the waitlist. Thanks for your patience.

Kevin-Mattheus-Moerman commented 1 year ago

@neillu23 did you see this comment :point_down: ?

Hi @neillu23! Your paper is too long. Please read the docs for details about how to write your paper.

Can you work on changing the paper according to our guidelines? You can call @editorialbot generate pdf here to update the paper.

Kevin-Mattheus-Moerman commented 1 year ago

@neillu23 the editors in this domain (audio/speech processing) are still all preoccupied with other submissions. We shall have to remain patient a bit longer I'm afraid.

Kevin-Mattheus-Moerman commented 1 year ago

@faroit @bmcfee if you can handle another submission let me know, otherwise we shall keep this as waitlisted for now. Thanks.

neillu23 commented 1 year ago

@neillu23 did you see this comment 👇 ?

Hi @neillu23! Your paper is too long. Please read the docs for details about how to write your paper.

Can you work on changing the paper according to our guidelines? You can call @editorialbot generate pdf here to update the paper.

Hi @Kevin-Mattheus-Moerman, thank you for your response! @simpleoier and I are now working on reducing the word count of the paper. We will further update the information here.

faroit commented 1 year ago

@Kevin-Mattheus-Moerman I can handle that starting next week

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot invite @faroit as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 year ago

@faroit do you mind if we assign this to you now? We have a growing backlog and it would be nice to get it off our desk onto yours :) starting next week or the week after (or whenever you are ready) is fine.

faroit commented 1 year ago

@editorialbot assign @faroit as editor

editorialbot commented 1 year ago

Assigned! @faroit is now the editor

faroit commented 1 year ago

Hi @neillu23, thanks for your submission to JOSS! I will be serving as the editor for this. We'll use this issue to identify reviewers and resolve technical issues.

It would be great to have reviewers with domain knowledge who also have experience with speech frameworks... I have a few potential reviewers in mind:

faroit commented 1 year ago

@neillu23 please update us on the potential reviewer list and add your own suggestions if you have some.

faroit commented 1 year ago

@neillu23 please update us on the reviewer proposals. I would like to proceed with the reviewer invitations.

neillu23 commented 1 year ago

@faroit sorry we missed your previous message. We are discussing potential reviewers and we will get back to you soon!

faroit commented 1 year ago

@neillu23 please update us on the reviewer proposals. If you need more, we can pause the review process at any time.

faroit commented 1 year ago

@editorialbot remind @neillu23 in 7 days

editorialbot commented 1 year ago

Reminder set for @neillu23 in 7 days

editorialbot commented 1 year ago

:wave: @neillu23, please update us on how things are progressing here (this is an automated reminder).

neillu23 commented 1 year ago

Hi @faroit, all the reviewers you mentioned are a good fit for our work! I believe @ jonashaag, @ jordipons and @ TParcollet would be more close to this paper.

However, we haven't finished reducing the word count, so can you help us temporarily suspend the review process? I apologize for any inconvenience caused to you!

faroit commented 1 year ago

However, we haven't finished reducing the word count, so can you help us temporarily suspend the review process? I apologize for any inconvenience caused to you!

@neillu23 we could do that but I would like to highly encourage you to not suspend the review for this reason. I think reducing the word count can be done with small amount of effort. Let us know you decided soon.

neillu23 commented 1 year ago

@faroit thank you very much for the suggestion! We will continue to work on it, and we aim to finish it in one or two weeks. @simpleoier and I will continue to update progress

faroit commented 1 year ago

@neillu23 great. Please let us know when the paper is ready.

faroit commented 1 year ago

@editorialbot remind @neillu23 in 7 days

editorialbot commented 1 year ago

Reminder set for @neillu23 in 7 days

editorialbot commented 1 year ago

:wave: @neillu23, please update us on how things are progressing here (this is an automated reminder).

faroit commented 1 year ago

@neillu23 is there a progress on the updated paper?

I would suggest that if you can't get the paper ready by next week, we think about pausing the review until you find the time. Does that sound okay to you?

faroit commented 1 year ago

Reminder set for @neillu23 in 7 days

faroit commented 1 year ago

@neillu23 please let me know if you want to continue with the review process in the next 7 days. If I don't hear from you, I will pause the review

neillu23 commented 1 year ago

@faroit sorry for the inconvenience, we have finished reducing the word count and made a PR (https://github.com/espnet/espnet/pull/4844). After the other authors check the draft again, we can merge the PR and proceed. Thank you very much for your help and I hope you have a wonderful New Year!

neillu23 commented 1 year ago

Hi @faroit, thank you very much for the help, we have merged the PR (https://github.com/espnet/espnet/pull/4844) and are ready to continue the review process!

faroit commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

faroit commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1109/slt48900.2021.9383615 may be a valid DOI for title: ESPnet-SE: End-to-end speech enhancement and separation toolkit designed for ASR integration
- 10.21437/interspeech.2022-10727 may be a valid DOI for title: ESPnet-SE++: Speech Enhancement for Robust Speech Recognition, Translation, and Understanding
- 10.1109/icassp40776.2020.9053512 may be a valid DOI for title: ESPnet-TTS: Unified, reproducible, and integratable open source end-to-end text-to-speech toolkit
- 10.18653/v1/2020.acl-demos.34 may be a valid DOI for title: ESPnet-ST: All-in-One Speech Translation Toolkit
- 10.1109/icassp43922.2022.9747674 may be a valid DOI for title: ESPnet-SLU: Advancing spoken language understanding through ESPnet
- 10.21437/interspeech.2018-1456 may be a valid DOI for title: ESPnet: End-to-End Speech Processing Toolkit
- 10.21437/interspeech.2020-1673 may be a valid DOI for title: Asteroid: the PyTorch-based audio source separation toolkit for researchers
- 10.1109/icassp40776.2020.9054266 may be a valid DOI for title: Dual-path rnn: efficient long sequence modeling for time-domain single-channel speech separation
- 10.1109/icassp.2018.8462116 may be a valid DOI for title: Tasnet: time-domain audio separation network for real-time, single-channel speech separation
- 10.1109/taslp.2019.2915167 may be a valid DOI for title: Conv-tasnet: Surpassing ideal time–frequency magnitude masking for speech separation
- 10.1109/icassp.2019.8683855 may be a valid DOI for title: SDR–half-baked or well done?
- 10.1109/icassp.2001.941023 may be a valid DOI for title: Perceptual evaluation of speech quality (PESQ)-a new method for speech quality assessment of telephone networks and codecs
- 10.1109/icassp.2017.7952154 may be a valid DOI for title: Permutation invariant training of deep models for speaker-independent multi-talker speech separation

INVALID DOIs

- None
faroit commented 1 year ago

@neillu23 thanks this looks good now and I'm happy to continue the review process!

faroit commented 1 year ago

👋 @jonashaag @adefossez @jordipons @santi-pdp @TParcollet @popcornell @boeddeker @TE-StefanUhlich @ykoyama58 - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The software under review is espnet.

This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place.

popcornell commented 1 year ago

@faroit I think I can't as I am one of the authors no ?

faroit commented 1 year ago

@popcornell Oops. I somehow haven't seen your name. Yes this would be a COI

TParcollet commented 1 year ago

Hi, I have worked closely with some people in the author list unfortunately...

boeddeker commented 1 year ago

I am on the ESPnet-SE paper, is that a COI?

faroit commented 1 year ago

@boeddeker i think thats borderline yes, unfortunately

faroit commented 1 year ago

👋 @mmmaat @ynop @ykoyama58 @pzelasko @FilipeChagasDev @hadware - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The software under review is espnet.

This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place.

faroit commented 1 year ago

@neillu23 I have to admit that it is very difficult to get reviewers for this submission as its a very high-profile software package with many contributors (and hence lots of potential conflict-of-interests). I did another round of social media activity to gather for more reviewers - but without much success. If you have, please post other potential reviewers here as well. Thanks you for your patience.

faroit commented 1 year ago

@neillu23 can you please help me out with some potential reviewers?