openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: directChillFoam: an OpenFOAM application for direct-chill casting #4802

Closed editorialbot closed 1 year ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@blebon<!--end-author-handle-- (Bruno Lebon) Repository: https://github.com/blebon/directChillFoam Branch with paper.md (empty if default branch): Version: OF9.0.1 Editor: !--editor-->@meg-simula<!--end-editor-- Reviewers: @chennachaos, @bzindovic Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/71097ad0617d8fd3da4c5196877ccb73"><img src="https://joss.theoj.org/papers/71097ad0617d8fd3da4c5196877ccb73/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/71097ad0617d8fd3da4c5196877ccb73/status.svg)](https://joss.theoj.org/papers/71097ad0617d8fd3da4c5196877ccb73)

Author instructions

Thanks for submitting your paper to JOSS @blebon. Currently, there isn't a JOSS editor assigned to your paper.

@blebon if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 years ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 years ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (793.5 files/s, 103833.9 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               8            376            229           1600
C/C++ Header                     13            461            565            889
Python                            7            142            125            508
reStructuredText                  8            226            391            188
TeX                               1             18              0            186
Markdown                          5             70              0            177
DOS Batch                         1              8              1             26
Bourne Again Shell                3             17             13             22
YAML                              1              1              4             18
make                              1              4              7              9
--------------------------------------------------------------------------------
SUM:                             48           1323           1335           3623
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 2 years ago

Wordcount for paper.md is 633

editorialbot commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0364-5916(02)00037-8 is OK
- 10.1201/9781420062823 is OK
- 10.1201/b17270 is OK
- 10.1016/j.ijheatmasstransfer.2017.10.033 is OK
- 10.1007/s11663-017-1016-7 is OK
- 10.3390/ma12193262 is OK
- 10.1016/j.ultsonch.2019.02.002 is OK
- 10.1016/j.apm.2019.08.032 is OK
- 10.1007/s11663-017-1016-7 is OK
- 10.1080/10426914.2014.921698 is OK
- 10.1016/j.jmatprotec.2021.117170 is OK
- 10.1016/j.jmrt.2021.03.061 is OK
- 10.1016/j.apm.2017.09.034 is OK
- 10.4028/www.scientific.net/MSF.765.291 is OK
- 10.1016/j.jmatprotec.2021.117116 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

blebon commented 2 years ago

There are only two OpenFOAM reviewers on the spreadsheet:

This is an active OpenFOAM developer but he is not on the reviewer list:

These are active researchers working on solidification with OpenFOAM and on Github. They are not on the reviewers list:

Otherwise, these are more active CFD reviewers from the list, but they don't seem to work on OpenFOAM:

blebon commented 2 years ago

Fixed references and resized DC casting figure.

@editorialbot generate pdf

blebon commented 2 years ago

@editorialbot generate pdf

editorialbot commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 2 years ago

@blebon – thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

kthyng commented 1 year ago

@meg-simula could you edit this submission?

kthyng commented 1 year ago

@editorialbot invite @meg-simula as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

meg-simula commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @meg-simula, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author or reviewer to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for archive
@editorialbot set 10.21105/zenodo.12345 as archive

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Open the review issue
@editorialbot start review
meg-simula commented 1 year ago

@editorialbot assign @meg-simula as editor

editorialbot commented 1 year ago

Assigned! @meg-simula is now the editor

meg-simula commented 1 year ago

Thanks @blebon for your submission! My first impression is that this looks very much ready for review. I'll reach out to potential reviewers in this thread and get back to you.

meg-simula commented 1 year ago

:wave: @ancolli, @chennachaos, @jayten, @bzindovic, @florianwechsung would you be available to review this submission for JOSS? Your expertise and contribution would be much appreciated. Do take a look at the JOSS reviewer guidelines here:

https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

and please respond in this pre-review issue.

ancolli commented 1 year ago

Sorry, I do not have time!

El vie, 21 oct 2022 a las 13:41, Marie E Rognes @.***>) escribió:

👋 @ancolli https://github.com/ancolli, @chennachaos https://github.com/chennachaos, @jayten https://github.com/jayten, @bzindovic https://github.com/bzindovic, @florianwechsung https://github.com/florianwechsung would you be available to review this submission for JOSS? Your expertise and contribution would be much appreciated. Do take a look at the JOSS reviewer guidelines here:

https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

and please respond in this pre-review issue.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/4802#issuecomment-1287202683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3U7KKAVRIINSS62D2PIT3WELBUDANCNFSM6AAAAAAQW4IYGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Dr. Colli, Alejandro Nicolás Research Associate - CONICET (https://www.conicet.gov.ar/?lan=en) Chief of Practical Applications - FIQ - UNL (https://www.fiq.unl.edu.ar) PRELINE - Facultad de Ingeniería Química Santiago del Estero 2829, Santa Fe, Argentina Telephone: +54 342 457-1164 Int. 2609 Mobile: +54 9 342 4188321

chennachaos commented 1 year ago

Thanks, @meg-simula! I will be happy to review this.

meg-simula commented 1 year ago

@editorialbot add @chennachaos as reviewer

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

meg-simula commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @meg-simula, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for archive
@editorialbot set 10.21105/zenodo.12345 as archive

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Open the review issue
@editorialbot start review
meg-simula commented 1 year ago

@editorialbot add @chennachaos as reviewer

editorialbot commented 1 year ago

@chennachaos added to the reviewers list!

bzindovic commented 1 year ago

Thanks @meg-simula. I'd be happy to review this research.

meg-simula commented 1 year ago

@editorialbot add @bzindovic as reviewer

editorialbot commented 1 year ago

@bzindovic added to the reviewers list!

meg-simula commented 1 year ago

Excellent, thanks @chennachaos and @bzindovic for the prompt responses, and let's get this review started.

meg-simula commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4871.